New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 628690 link

Starred by 2 users
Status: Fixed
Owner:
█ wangyix@chromium.org
Last visit > 30 days ago
Closed: Mar 2017
Cc:
eranm@chromium.org
est...@chromium.org
asymmetric@chromium.org
eroman@chromium.org
rsleevi@chromium.org
mmenke@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug-Regression



Sign in to add a comment

Pretty printing of CERT_CT_COMPLIANCE_CHECKED in NetLogs doesn't work

Project Member Reported by eroman@chromium.org, Jul 15 2016 
When loading NetLogs the certificates attached to CERT_CT_COMPLIANCE_CHECKED events are not properly formatted (see attached image).

There appears to be special code to handle this, but likely regressed with https://codereview.chromium.org/1578993003/ which changed the structure of the logged data.
netlog.png
53.4 KB View Download

Comment 1 by eroman@chromium.org, Oct 19 2016

Owner: wangyix@chromium.org
Status: Assigned (was: Untriaged)
Project Member

Comment 2 by bugdroid1@chromium.org, Oct 26 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8f0859349b48a31b0317096f5a5cd8931b629fcc

commit 8f0859349b48a31b0317096f5a5cd8931b629fcc
Author: wangyix <wangyix@google.com>
Date: Wed Oct 26 01:45:41 2016

Pretty print CERT_CT_COMPLIANCE_CHECKED events in the NetLog viewer.

In net-internals's events viewer, certificates attached to CERT_CT_COMPLIANCE_CHECKED events are now properly pretty-printed instead of being printed all in one line.

BUG= 628690 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2447803002
Cr-Commit-Position: refs/heads/master@{#427572}

[modify] https://crrev.com/8f0859349b48a31b0317096f5a5cd8931b629fcc/chrome/browser/resources/net_internals/log_view_painter.js
[modify] https://crrev.com/8f0859349b48a31b0317096f5a5cd8931b629fcc/chrome/test/data/webui/net_internals/log_view_painter.js

Comment 3 by wangyix@chromium.org, Mar 15 2017

Status: Fixed (was: Assigned)

Comment 4 by rsleevi@chromium.org, Mar 15 2017

Labels: M-59
Looks like this was M-59, but feel free to update if not.
►

Sign in to add a comment