New issue
Advanced search Search tips

Issue 628685 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jul 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Feature

Blocked on:
issue 628460

Blocking:
issue 628781



Sign in to add a comment

Throw NotSupportedError when merchant requests Android Pay, but it does not have cards on file

Project Member Reported by rouslan@chromium.org, Jul 15 2016

Issue description

^^^^^
 
Blocking: 628781
Project Member

Comment 2 by bugdroid1@chromium.org, Jul 20 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/036c952c9a98ce9b25d7020fe865727b172d501a

commit 036c952c9a98ce9b25d7020fe865727b172d501a
Author: rouslan <rouslan@chromium.org>
Date: Wed Jul 20 15:07:56 2016

NotSupportedError for payment apps without instruments.

If the merchant website requests only a payment app that happens to not
have any payment instruments and no ability to add an instrument from
within PaymentRequest UI, then reject the show() promise with
NotSupportedError.

BUG= 628685 

Review-Url: https://codereview.chromium.org/2159513002
Cr-Commit-Position: refs/heads/master@{#406558}

[modify] https://crrev.com/036c952c9a98ce9b25d7020fe865727b172d501a/chrome/android/java/src/org/chromium/chrome/browser/payments/AutofillPaymentApp.java
[modify] https://crrev.com/036c952c9a98ce9b25d7020fe865727b172d501a/chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java
[modify] https://crrev.com/036c952c9a98ce9b25d7020fe865727b172d501a/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestPaymentAppTest.java

Labels: Merge-Request-53 M-53
Would like to merge 036c952c9a98ce9b25d7020fe865727b172d501a into M-53.

Comment 4 by dimu@google.com, Jul 22 2016

Labels: -Merge-Request-53 Merge-Approved-53 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M53 (branch: 2785)
Project Member

Comment 5 by bugdroid1@chromium.org, Jul 22 2016

Labels: -merge-approved-53 merge-merged-2785
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/23b5a62b04e4594c310a80c9f0646cd87918101e

commit 23b5a62b04e4594c310a80c9f0646cd87918101e
Author: Rouslan Solomakhin <rouslan@chromium.org>
Date: Fri Jul 22 16:22:59 2016

[Merge M-53] NotSupportedError for payment apps without instruments.

If the merchant website requests only a payment app that happens to not
have any payment instruments and no ability to add an instrument from
within PaymentRequest UI, then reject the show() promise with
NotSupportedError.

BUG= 628685 

Review-Url: https://codereview.chromium.org/2159513002
Cr-Commit-Position: refs/heads/master@{#406558}
(cherry picked from commit 036c952c9a98ce9b25d7020fe865727b172d501a)

Review URL: https://codereview.chromium.org/2173893002 .

Cr-Commit-Position: refs/branch-heads/2785@{#298}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}

[modify] https://crrev.com/23b5a62b04e4594c310a80c9f0646cd87918101e/chrome/android/java/src/org/chromium/chrome/browser/payments/AutofillPaymentApp.java
[modify] https://crrev.com/23b5a62b04e4594c310a80c9f0646cd87918101e/chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java
[modify] https://crrev.com/23b5a62b04e4594c310a80c9f0646cd87918101e/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestPaymentAppTest.java

Status: Fixed (was: Started)
Components: -UI>Browser>Autofill>Payments UI>Browser>Payments

Sign in to add a comment