Refactor LayerTreeHost, setup a LayerTree class that will be used by internal cc classes.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e43518a18ef7736ece1beadde0c7e57e5ed7dd88 commit e43518a18ef7736ece1beadde0c7e57e5ed7dd88 Author: xingliu <xingliu@chromium.org> Date: Thu Jul 28 23:59:47 2016 Set up a LayerTree class to split the LayerTreeHost. The LayerTree class is the main thread counter-part to the LayerTreeImpl, which will own the root layer and other tree state. Data and functionality will be incrementally moved to this class as we eliminate dependencies of internal cc class and the embedder to LayerTree from the host. This patch moves the Registration/Unregistration logic for maintaining a map of layers tied to a host and tracking of dirty layers that need to push properties in the next commit, to the LayerTree. BUG= 628683 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel Review-Url: https://codereview.chromium.org/2159513003 Cr-Commit-Position: refs/heads/master@{#408518} [modify] https://crrev.com/e43518a18ef7736ece1beadde0c7e57e5ed7dd88/cc/BUILD.gn [modify] https://crrev.com/e43518a18ef7736ece1beadde0c7e57e5ed7dd88/cc/cc.gyp [modify] https://crrev.com/e43518a18ef7736ece1beadde0c7e57e5ed7dd88/cc/layers/layer.cc [modify] https://crrev.com/e43518a18ef7736ece1beadde0c7e57e5ed7dd88/cc/layers/layer.h [modify] https://crrev.com/e43518a18ef7736ece1beadde0c7e57e5ed7dd88/cc/layers/layer_proto_converter.cc [modify] https://crrev.com/e43518a18ef7736ece1beadde0c7e57e5ed7dd88/cc/layers/layer_proto_converter_unittest.cc [modify] https://crrev.com/e43518a18ef7736ece1beadde0c7e57e5ed7dd88/cc/layers/layer_unittest.cc [modify] https://crrev.com/e43518a18ef7736ece1beadde0c7e57e5ed7dd88/cc/layers/picture_layer.cc [modify] https://crrev.com/e43518a18ef7736ece1beadde0c7e57e5ed7dd88/cc/proto/BUILD.gn [add] https://crrev.com/e43518a18ef7736ece1beadde0c7e57e5ed7dd88/cc/proto/layer_tree.proto [modify] https://crrev.com/e43518a18ef7736ece1beadde0c7e57e5ed7dd88/cc/proto/layer_tree_host.proto [modify] https://crrev.com/e43518a18ef7736ece1beadde0c7e57e5ed7dd88/cc/test/fake_layer_tree_host.cc [add] https://crrev.com/e43518a18ef7736ece1beadde0c7e57e5ed7dd88/cc/trees/layer_tree.cc [add] https://crrev.com/e43518a18ef7736ece1beadde0c7e57e5ed7dd88/cc/trees/layer_tree.h [modify] https://crrev.com/e43518a18ef7736ece1beadde0c7e57e5ed7dd88/cc/trees/layer_tree_host.cc [modify] https://crrev.com/e43518a18ef7736ece1beadde0c7e57e5ed7dd88/cc/trees/layer_tree_host.h [modify] https://crrev.com/e43518a18ef7736ece1beadde0c7e57e5ed7dd88/cc/trees/layer_tree_host_unittest.cc [modify] https://crrev.com/e43518a18ef7736ece1beadde0c7e57e5ed7dd88/cc/trees/layer_tree_host_unittest_scroll.cc [modify] https://crrev.com/e43518a18ef7736ece1beadde0c7e57e5ed7dd88/cc/trees/layer_tree_host_unittest_serialization.cc [modify] https://crrev.com/e43518a18ef7736ece1beadde0c7e57e5ed7dd88/cc/trees/tree_synchronizer.cc [modify] https://crrev.com/e43518a18ef7736ece1beadde0c7e57e5ed7dd88/cc/trees/tree_synchronizer.h [modify] https://crrev.com/e43518a18ef7736ece1beadde0c7e57e5ed7dd88/cc/trees/tree_synchronizer_unittest.cc
The first setup CL has been merged, there are still lots to do, (me and khushal both works on this), so temporarily keep the bug here.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/806556451c84f03082ece3818862bbc22fd2727b commit 806556451c84f03082ece3818862bbc22fd2727b Author: khushalsagar <khushalsagar@chromium.org> Date: Wed Aug 17 01:36:26 2016 cc: Move data to LayerTree from LayerTreeHost. Move bulk of the tree state from LayerTreeHost to LayerTree. The LayerTree mirrors LayerTreeImpl in terms of what it stores and is used to push the corresponding properties to LayerTreeImpl during commit. BUG= 628683 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel Review-Url: https://codereview.chromium.org/2183403002 Cr-Commit-Position: refs/heads/master@{#412413} [modify] https://crrev.com/806556451c84f03082ece3818862bbc22fd2727b/cc/debug/invalidation_benchmark.cc [modify] https://crrev.com/806556451c84f03082ece3818862bbc22fd2727b/cc/layers/heads_up_display_unittest.cc [modify] https://crrev.com/806556451c84f03082ece3818862bbc22fd2727b/cc/layers/layer.cc [modify] https://crrev.com/806556451c84f03082ece3818862bbc22fd2727b/cc/layers/layer_position_constraint_unittest.cc [modify] https://crrev.com/806556451c84f03082ece3818862bbc22fd2727b/cc/layers/layer_proto_converter.h [modify] https://crrev.com/806556451c84f03082ece3818862bbc22fd2727b/cc/layers/layer_unittest.cc [modify] https://crrev.com/806556451c84f03082ece3818862bbc22fd2727b/cc/layers/painted_scrollbar_layer.cc [modify] https://crrev.com/806556451c84f03082ece3818862bbc22fd2727b/cc/layers/picture_layer.cc [modify] https://crrev.com/806556451c84f03082ece3818862bbc22fd2727b/cc/layers/picture_layer_unittest.cc [modify] https://crrev.com/806556451c84f03082ece3818862bbc22fd2727b/cc/layers/scrollbar_layer_unittest.cc [modify] https://crrev.com/806556451c84f03082ece3818862bbc22fd2727b/cc/layers/surface_layer_unittest.cc [modify] https://crrev.com/806556451c84f03082ece3818862bbc22fd2727b/cc/layers/texture_layer_unittest.cc [modify] https://crrev.com/806556451c84f03082ece3818862bbc22fd2727b/cc/output/delegating_renderer_unittest.cc [modify] https://crrev.com/806556451c84f03082ece3818862bbc22fd2727b/cc/proto/layer_tree.proto [modify] https://crrev.com/806556451c84f03082ece3818862bbc22fd2727b/cc/proto/layer_tree_host.proto [modify] https://crrev.com/806556451c84f03082ece3818862bbc22fd2727b/cc/test/fake_layer_tree_host.cc [modify] https://crrev.com/806556451c84f03082ece3818862bbc22fd2727b/cc/test/fake_layer_tree_host.h [modify] https://crrev.com/806556451c84f03082ece3818862bbc22fd2727b/cc/test/layer_tree_pixel_test.cc [modify] https://crrev.com/806556451c84f03082ece3818862bbc22fd2727b/cc/test/layer_tree_test.cc [modify] https://crrev.com/806556451c84f03082ece3818862bbc22fd2727b/cc/test/layer_tree_test.h [modify] https://crrev.com/806556451c84f03082ece3818862bbc22fd2727b/cc/trees/layer_tree.cc [modify] https://crrev.com/806556451c84f03082ece3818862bbc22fd2727b/cc/trees/layer_tree.h [modify] https://crrev.com/806556451c84f03082ece3818862bbc22fd2727b/cc/trees/layer_tree_host.cc [modify] https://crrev.com/806556451c84f03082ece3818862bbc22fd2727b/cc/trees/layer_tree_host.h [modify] https://crrev.com/806556451c84f03082ece3818862bbc22fd2727b/cc/trees/layer_tree_host_common.cc [modify] https://crrev.com/806556451c84f03082ece3818862bbc22fd2727b/cc/trees/layer_tree_host_common_perftest.cc [modify] https://crrev.com/806556451c84f03082ece3818862bbc22fd2727b/cc/trees/layer_tree_host_common_unittest.cc [modify] https://crrev.com/806556451c84f03082ece3818862bbc22fd2727b/cc/trees/layer_tree_host_perftest.cc [modify] https://crrev.com/806556451c84f03082ece3818862bbc22fd2727b/cc/trees/layer_tree_host_pixeltest_filters.cc [modify] https://crrev.com/806556451c84f03082ece3818862bbc22fd2727b/cc/trees/layer_tree_host_pixeltest_readback.cc [modify] https://crrev.com/806556451c84f03082ece3818862bbc22fd2727b/cc/trees/layer_tree_host_pixeltest_tiles.cc [modify] https://crrev.com/806556451c84f03082ece3818862bbc22fd2727b/cc/trees/layer_tree_host_unittest.cc [modify] https://crrev.com/806556451c84f03082ece3818862bbc22fd2727b/cc/trees/layer_tree_host_unittest_animation.cc [modify] https://crrev.com/806556451c84f03082ece3818862bbc22fd2727b/cc/trees/layer_tree_host_unittest_context.cc [modify] https://crrev.com/806556451c84f03082ece3818862bbc22fd2727b/cc/trees/layer_tree_host_unittest_copyrequest.cc [modify] https://crrev.com/806556451c84f03082ece3818862bbc22fd2727b/cc/trees/layer_tree_host_unittest_damage.cc [modify] https://crrev.com/806556451c84f03082ece3818862bbc22fd2727b/cc/trees/layer_tree_host_unittest_occlusion.cc [modify] https://crrev.com/806556451c84f03082ece3818862bbc22fd2727b/cc/trees/layer_tree_host_unittest_picture.cc [modify] https://crrev.com/806556451c84f03082ece3818862bbc22fd2727b/cc/trees/layer_tree_host_unittest_proxy.cc [modify] https://crrev.com/806556451c84f03082ece3818862bbc22fd2727b/cc/trees/layer_tree_host_unittest_scroll.cc [modify] https://crrev.com/806556451c84f03082ece3818862bbc22fd2727b/cc/trees/layer_tree_host_unittest_serialization.cc [modify] https://crrev.com/806556451c84f03082ece3818862bbc22fd2727b/cc/trees/layer_tree_host_unittest_video.cc [modify] https://crrev.com/806556451c84f03082ece3818862bbc22fd2727b/cc/trees/property_tree_builder.cc [modify] https://crrev.com/806556451c84f03082ece3818862bbc22fd2727b/cc/trees/remote_channel_impl.cc [modify] https://crrev.com/806556451c84f03082ece3818862bbc22fd2727b/cc/trees/tree_synchronizer.cc [modify] https://crrev.com/806556451c84f03082ece3818862bbc22fd2727b/content/browser/renderer_host/compositor_impl_android.cc [modify] https://crrev.com/806556451c84f03082ece3818862bbc22fd2727b/content/renderer/gpu/render_widget_compositor.cc [modify] https://crrev.com/806556451c84f03082ece3818862bbc22fd2727b/content/renderer/render_view_browsertest.cc [modify] https://crrev.com/806556451c84f03082ece3818862bbc22fd2727b/third_party/WebKit/Source/platform/graphics/compositing/PaintArtifactCompositor.cpp [modify] https://crrev.com/806556451c84f03082ece3818862bbc22fd2727b/third_party/WebKit/Source/platform/graphics/compositing/PaintArtifactCompositorTest.cpp [modify] https://crrev.com/806556451c84f03082ece3818862bbc22fd2727b/third_party/WebKit/Source/platform/testing/WebLayerTreeViewImplForTesting.cpp [modify] https://crrev.com/806556451c84f03082ece3818862bbc22fd2727b/ui/compositor/compositor.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2f03c7f2b75275f951efaf6b5e5f61cc52d74a8e commit 2f03c7f2b75275f951efaf6b5e5f61cc52d74a8e Author: rnk <rnk@chromium.org> Date: Wed Aug 17 17:10:59 2016 Revert of cc: Move data to LayerTree from LayerTreeHost. (patchset #9 id:160001 of https://codereview.chromium.org/2183403002/ ) Reason for revert: Invalid cast breaks CFI build, which is shipping on Linux soon Original issue's description: > cc: Move data to LayerTree from LayerTreeHost. > > Move bulk of the tree state from LayerTreeHost to LayerTree. The > LayerTree mirrors LayerTreeImpl in terms of what it stores and is used > to push the corresponding properties to LayerTreeImpl during commit. > > BUG= 628683 > CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel > > Committed: https://crrev.com/806556451c84f03082ece3818862bbc22fd2727b > Cr-Commit-Position: refs/heads/master@{#412413} TBR=enne@chromium.org,loyso@chromium.org,vollick@chromium.org,piman@chromium.org,khushalsagar@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= 628683 Review-Url: https://codereview.chromium.org/2253143002 Cr-Commit-Position: refs/heads/master@{#412569} [modify] https://crrev.com/2f03c7f2b75275f951efaf6b5e5f61cc52d74a8e/cc/debug/invalidation_benchmark.cc [modify] https://crrev.com/2f03c7f2b75275f951efaf6b5e5f61cc52d74a8e/cc/layers/heads_up_display_unittest.cc [modify] https://crrev.com/2f03c7f2b75275f951efaf6b5e5f61cc52d74a8e/cc/layers/layer.cc [modify] https://crrev.com/2f03c7f2b75275f951efaf6b5e5f61cc52d74a8e/cc/layers/layer_position_constraint_unittest.cc [modify] https://crrev.com/2f03c7f2b75275f951efaf6b5e5f61cc52d74a8e/cc/layers/layer_proto_converter.h [modify] https://crrev.com/2f03c7f2b75275f951efaf6b5e5f61cc52d74a8e/cc/layers/layer_unittest.cc [modify] https://crrev.com/2f03c7f2b75275f951efaf6b5e5f61cc52d74a8e/cc/layers/painted_scrollbar_layer.cc [modify] https://crrev.com/2f03c7f2b75275f951efaf6b5e5f61cc52d74a8e/cc/layers/picture_layer.cc [modify] https://crrev.com/2f03c7f2b75275f951efaf6b5e5f61cc52d74a8e/cc/layers/picture_layer_unittest.cc [modify] https://crrev.com/2f03c7f2b75275f951efaf6b5e5f61cc52d74a8e/cc/layers/scrollbar_layer_unittest.cc [modify] https://crrev.com/2f03c7f2b75275f951efaf6b5e5f61cc52d74a8e/cc/layers/surface_layer_unittest.cc [modify] https://crrev.com/2f03c7f2b75275f951efaf6b5e5f61cc52d74a8e/cc/layers/texture_layer_unittest.cc [modify] https://crrev.com/2f03c7f2b75275f951efaf6b5e5f61cc52d74a8e/cc/output/delegating_renderer_unittest.cc [modify] https://crrev.com/2f03c7f2b75275f951efaf6b5e5f61cc52d74a8e/cc/proto/layer_tree.proto [modify] https://crrev.com/2f03c7f2b75275f951efaf6b5e5f61cc52d74a8e/cc/proto/layer_tree_host.proto [modify] https://crrev.com/2f03c7f2b75275f951efaf6b5e5f61cc52d74a8e/cc/test/fake_layer_tree_host.cc [modify] https://crrev.com/2f03c7f2b75275f951efaf6b5e5f61cc52d74a8e/cc/test/fake_layer_tree_host.h [modify] https://crrev.com/2f03c7f2b75275f951efaf6b5e5f61cc52d74a8e/cc/test/layer_tree_pixel_test.cc [modify] https://crrev.com/2f03c7f2b75275f951efaf6b5e5f61cc52d74a8e/cc/test/layer_tree_test.cc [modify] https://crrev.com/2f03c7f2b75275f951efaf6b5e5f61cc52d74a8e/cc/test/layer_tree_test.h [modify] https://crrev.com/2f03c7f2b75275f951efaf6b5e5f61cc52d74a8e/cc/trees/layer_tree.cc [modify] https://crrev.com/2f03c7f2b75275f951efaf6b5e5f61cc52d74a8e/cc/trees/layer_tree.h [modify] https://crrev.com/2f03c7f2b75275f951efaf6b5e5f61cc52d74a8e/cc/trees/layer_tree_host.cc [modify] https://crrev.com/2f03c7f2b75275f951efaf6b5e5f61cc52d74a8e/cc/trees/layer_tree_host.h [modify] https://crrev.com/2f03c7f2b75275f951efaf6b5e5f61cc52d74a8e/cc/trees/layer_tree_host_common.cc [modify] https://crrev.com/2f03c7f2b75275f951efaf6b5e5f61cc52d74a8e/cc/trees/layer_tree_host_common_perftest.cc [modify] https://crrev.com/2f03c7f2b75275f951efaf6b5e5f61cc52d74a8e/cc/trees/layer_tree_host_common_unittest.cc [modify] https://crrev.com/2f03c7f2b75275f951efaf6b5e5f61cc52d74a8e/cc/trees/layer_tree_host_perftest.cc [modify] https://crrev.com/2f03c7f2b75275f951efaf6b5e5f61cc52d74a8e/cc/trees/layer_tree_host_pixeltest_filters.cc [modify] https://crrev.com/2f03c7f2b75275f951efaf6b5e5f61cc52d74a8e/cc/trees/layer_tree_host_pixeltest_readback.cc [modify] https://crrev.com/2f03c7f2b75275f951efaf6b5e5f61cc52d74a8e/cc/trees/layer_tree_host_pixeltest_tiles.cc [modify] https://crrev.com/2f03c7f2b75275f951efaf6b5e5f61cc52d74a8e/cc/trees/layer_tree_host_unittest.cc [modify] https://crrev.com/2f03c7f2b75275f951efaf6b5e5f61cc52d74a8e/cc/trees/layer_tree_host_unittest_animation.cc [modify] https://crrev.com/2f03c7f2b75275f951efaf6b5e5f61cc52d74a8e/cc/trees/layer_tree_host_unittest_context.cc [modify] https://crrev.com/2f03c7f2b75275f951efaf6b5e5f61cc52d74a8e/cc/trees/layer_tree_host_unittest_copyrequest.cc [modify] https://crrev.com/2f03c7f2b75275f951efaf6b5e5f61cc52d74a8e/cc/trees/layer_tree_host_unittest_damage.cc [modify] https://crrev.com/2f03c7f2b75275f951efaf6b5e5f61cc52d74a8e/cc/trees/layer_tree_host_unittest_occlusion.cc [modify] https://crrev.com/2f03c7f2b75275f951efaf6b5e5f61cc52d74a8e/cc/trees/layer_tree_host_unittest_picture.cc [modify] https://crrev.com/2f03c7f2b75275f951efaf6b5e5f61cc52d74a8e/cc/trees/layer_tree_host_unittest_proxy.cc [modify] https://crrev.com/2f03c7f2b75275f951efaf6b5e5f61cc52d74a8e/cc/trees/layer_tree_host_unittest_scroll.cc [modify] https://crrev.com/2f03c7f2b75275f951efaf6b5e5f61cc52d74a8e/cc/trees/layer_tree_host_unittest_serialization.cc [modify] https://crrev.com/2f03c7f2b75275f951efaf6b5e5f61cc52d74a8e/cc/trees/layer_tree_host_unittest_video.cc [modify] https://crrev.com/2f03c7f2b75275f951efaf6b5e5f61cc52d74a8e/cc/trees/property_tree_builder.cc [modify] https://crrev.com/2f03c7f2b75275f951efaf6b5e5f61cc52d74a8e/cc/trees/remote_channel_impl.cc [modify] https://crrev.com/2f03c7f2b75275f951efaf6b5e5f61cc52d74a8e/cc/trees/tree_synchronizer.cc [modify] https://crrev.com/2f03c7f2b75275f951efaf6b5e5f61cc52d74a8e/content/browser/renderer_host/compositor_impl_android.cc [modify] https://crrev.com/2f03c7f2b75275f951efaf6b5e5f61cc52d74a8e/content/renderer/gpu/render_widget_compositor.cc [modify] https://crrev.com/2f03c7f2b75275f951efaf6b5e5f61cc52d74a8e/content/renderer/render_view_browsertest.cc [modify] https://crrev.com/2f03c7f2b75275f951efaf6b5e5f61cc52d74a8e/third_party/WebKit/Source/platform/graphics/compositing/PaintArtifactCompositor.cpp [modify] https://crrev.com/2f03c7f2b75275f951efaf6b5e5f61cc52d74a8e/third_party/WebKit/Source/platform/graphics/compositing/PaintArtifactCompositorTest.cpp [modify] https://crrev.com/2f03c7f2b75275f951efaf6b5e5f61cc52d74a8e/third_party/WebKit/Source/platform/testing/WebLayerTreeViewImplForTesting.cpp [modify] https://crrev.com/2f03c7f2b75275f951efaf6b5e5f61cc52d74a8e/ui/compositor/compositor.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/86928f9503d820305efffe338712ab25a3f2f27d commit 86928f9503d820305efffe338712ab25a3f2f27d Author: khushalsagar <khushalsagar@chromium.org> Date: Wed Aug 17 21:49:05 2016 cc: Reland "Move data to LayerTree from LayerTreeHost." Move bulk of the tree state from LayerTreeHost to LayerTree. The LayerTree mirrors LayerTreeImpl in terms of what it stores and is used to push the corresponding properties to LayerTreeImpl during commit. The test was casting a MockLayerTree to a StrictMock<MockLayerTree>. Make sure to create the correct type. TBR=vollick,piman BUG= 628683 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel Review-Url: https://codereview.chromium.org/2251143002 Cr-Commit-Position: refs/heads/master@{#412655} [modify] https://crrev.com/86928f9503d820305efffe338712ab25a3f2f27d/cc/debug/invalidation_benchmark.cc [modify] https://crrev.com/86928f9503d820305efffe338712ab25a3f2f27d/cc/layers/heads_up_display_unittest.cc [modify] https://crrev.com/86928f9503d820305efffe338712ab25a3f2f27d/cc/layers/layer.cc [modify] https://crrev.com/86928f9503d820305efffe338712ab25a3f2f27d/cc/layers/layer_position_constraint_unittest.cc [modify] https://crrev.com/86928f9503d820305efffe338712ab25a3f2f27d/cc/layers/layer_proto_converter.h [modify] https://crrev.com/86928f9503d820305efffe338712ab25a3f2f27d/cc/layers/layer_unittest.cc [modify] https://crrev.com/86928f9503d820305efffe338712ab25a3f2f27d/cc/layers/painted_scrollbar_layer.cc [modify] https://crrev.com/86928f9503d820305efffe338712ab25a3f2f27d/cc/layers/picture_layer.cc [modify] https://crrev.com/86928f9503d820305efffe338712ab25a3f2f27d/cc/layers/picture_layer_unittest.cc [modify] https://crrev.com/86928f9503d820305efffe338712ab25a3f2f27d/cc/layers/scrollbar_layer_unittest.cc [modify] https://crrev.com/86928f9503d820305efffe338712ab25a3f2f27d/cc/layers/surface_layer_unittest.cc [modify] https://crrev.com/86928f9503d820305efffe338712ab25a3f2f27d/cc/layers/texture_layer_unittest.cc [modify] https://crrev.com/86928f9503d820305efffe338712ab25a3f2f27d/cc/output/delegating_renderer_unittest.cc [modify] https://crrev.com/86928f9503d820305efffe338712ab25a3f2f27d/cc/proto/layer_tree.proto [modify] https://crrev.com/86928f9503d820305efffe338712ab25a3f2f27d/cc/proto/layer_tree_host.proto [modify] https://crrev.com/86928f9503d820305efffe338712ab25a3f2f27d/cc/test/fake_layer_tree_host.cc [modify] https://crrev.com/86928f9503d820305efffe338712ab25a3f2f27d/cc/test/fake_layer_tree_host.h [modify] https://crrev.com/86928f9503d820305efffe338712ab25a3f2f27d/cc/test/layer_tree_pixel_test.cc [modify] https://crrev.com/86928f9503d820305efffe338712ab25a3f2f27d/cc/test/layer_tree_test.cc [modify] https://crrev.com/86928f9503d820305efffe338712ab25a3f2f27d/cc/test/layer_tree_test.h [modify] https://crrev.com/86928f9503d820305efffe338712ab25a3f2f27d/cc/trees/layer_tree.cc [modify] https://crrev.com/86928f9503d820305efffe338712ab25a3f2f27d/cc/trees/layer_tree.h [modify] https://crrev.com/86928f9503d820305efffe338712ab25a3f2f27d/cc/trees/layer_tree_host.cc [modify] https://crrev.com/86928f9503d820305efffe338712ab25a3f2f27d/cc/trees/layer_tree_host.h [modify] https://crrev.com/86928f9503d820305efffe338712ab25a3f2f27d/cc/trees/layer_tree_host_common.cc [modify] https://crrev.com/86928f9503d820305efffe338712ab25a3f2f27d/cc/trees/layer_tree_host_common_perftest.cc [modify] https://crrev.com/86928f9503d820305efffe338712ab25a3f2f27d/cc/trees/layer_tree_host_common_unittest.cc [modify] https://crrev.com/86928f9503d820305efffe338712ab25a3f2f27d/cc/trees/layer_tree_host_perftest.cc [modify] https://crrev.com/86928f9503d820305efffe338712ab25a3f2f27d/cc/trees/layer_tree_host_pixeltest_filters.cc [modify] https://crrev.com/86928f9503d820305efffe338712ab25a3f2f27d/cc/trees/layer_tree_host_pixeltest_readback.cc [modify] https://crrev.com/86928f9503d820305efffe338712ab25a3f2f27d/cc/trees/layer_tree_host_pixeltest_tiles.cc [modify] https://crrev.com/86928f9503d820305efffe338712ab25a3f2f27d/cc/trees/layer_tree_host_unittest.cc [modify] https://crrev.com/86928f9503d820305efffe338712ab25a3f2f27d/cc/trees/layer_tree_host_unittest_animation.cc [modify] https://crrev.com/86928f9503d820305efffe338712ab25a3f2f27d/cc/trees/layer_tree_host_unittest_context.cc [modify] https://crrev.com/86928f9503d820305efffe338712ab25a3f2f27d/cc/trees/layer_tree_host_unittest_copyrequest.cc [modify] https://crrev.com/86928f9503d820305efffe338712ab25a3f2f27d/cc/trees/layer_tree_host_unittest_damage.cc [modify] https://crrev.com/86928f9503d820305efffe338712ab25a3f2f27d/cc/trees/layer_tree_host_unittest_occlusion.cc [modify] https://crrev.com/86928f9503d820305efffe338712ab25a3f2f27d/cc/trees/layer_tree_host_unittest_picture.cc [modify] https://crrev.com/86928f9503d820305efffe338712ab25a3f2f27d/cc/trees/layer_tree_host_unittest_proxy.cc [modify] https://crrev.com/86928f9503d820305efffe338712ab25a3f2f27d/cc/trees/layer_tree_host_unittest_scroll.cc [modify] https://crrev.com/86928f9503d820305efffe338712ab25a3f2f27d/cc/trees/layer_tree_host_unittest_serialization.cc [modify] https://crrev.com/86928f9503d820305efffe338712ab25a3f2f27d/cc/trees/layer_tree_host_unittest_video.cc [modify] https://crrev.com/86928f9503d820305efffe338712ab25a3f2f27d/cc/trees/property_tree_builder.cc [modify] https://crrev.com/86928f9503d820305efffe338712ab25a3f2f27d/cc/trees/remote_channel_impl.cc [modify] https://crrev.com/86928f9503d820305efffe338712ab25a3f2f27d/cc/trees/tree_synchronizer.cc [modify] https://crrev.com/86928f9503d820305efffe338712ab25a3f2f27d/content/browser/renderer_host/compositor_impl_android.cc [modify] https://crrev.com/86928f9503d820305efffe338712ab25a3f2f27d/content/renderer/gpu/render_widget_compositor.cc [modify] https://crrev.com/86928f9503d820305efffe338712ab25a3f2f27d/content/renderer/render_view_browsertest.cc [modify] https://crrev.com/86928f9503d820305efffe338712ab25a3f2f27d/third_party/WebKit/Source/platform/graphics/compositing/PaintArtifactCompositor.cpp [modify] https://crrev.com/86928f9503d820305efffe338712ab25a3f2f27d/third_party/WebKit/Source/platform/graphics/compositing/PaintArtifactCompositorTest.cpp [modify] https://crrev.com/86928f9503d820305efffe338712ab25a3f2f27d/third_party/WebKit/Source/platform/testing/WebLayerTreeViewImplForTesting.cpp [modify] https://crrev.com/86928f9503d820305efffe338712ab25a3f2f27d/ui/compositor/compositor.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/95d9e6b63179642af8391906ccbe586bd3587b56 commit 95d9e6b63179642af8391906ccbe586bd3587b56 Author: xingliu <xingliu@chromium.org> Date: Thu Aug 18 03:53:08 2016 Refactor MutatorHostClient from LayerTreeHost to LayerTree. This is another CL for refactoring part of LayerTreeHost to LayerTree. Refactored MutatorHostClient, and also follow Khushal's other CL, to cache raw pointer of LayerTreeHost in LayerTree, and use unique_ptr to wrap LayerTree in LayerTreeHost. BUG= 628683 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel Review-Url: https://codereview.chromium.org/2216203002 Cr-Commit-Position: refs/heads/master@{#412727} [modify] https://crrev.com/95d9e6b63179642af8391906ccbe586bd3587b56/cc/animation/animation_host_perftest.cc [modify] https://crrev.com/95d9e6b63179642af8391906ccbe586bd3587b56/cc/debug/invalidation_benchmark.cc [modify] https://crrev.com/95d9e6b63179642af8391906ccbe586bd3587b56/cc/debug/invalidation_benchmark.h [modify] https://crrev.com/95d9e6b63179642af8391906ccbe586bd3587b56/cc/debug/micro_benchmark.cc [modify] https://crrev.com/95d9e6b63179642af8391906ccbe586bd3587b56/cc/debug/micro_benchmark.h [modify] https://crrev.com/95d9e6b63179642af8391906ccbe586bd3587b56/cc/debug/micro_benchmark_controller.cc [modify] https://crrev.com/95d9e6b63179642af8391906ccbe586bd3587b56/cc/debug/rasterize_and_record_benchmark.cc [modify] https://crrev.com/95d9e6b63179642af8391906ccbe586bd3587b56/cc/debug/rasterize_and_record_benchmark.h [modify] https://crrev.com/95d9e6b63179642af8391906ccbe586bd3587b56/cc/debug/unittest_only_benchmark.cc [modify] https://crrev.com/95d9e6b63179642af8391906ccbe586bd3587b56/cc/debug/unittest_only_benchmark.h [modify] https://crrev.com/95d9e6b63179642af8391906ccbe586bd3587b56/cc/layers/layer.cc [modify] https://crrev.com/95d9e6b63179642af8391906ccbe586bd3587b56/cc/layers/layer.h [modify] https://crrev.com/95d9e6b63179642af8391906ccbe586bd3587b56/cc/layers/layer_list_iterator_unittest.cc [modify] https://crrev.com/95d9e6b63179642af8391906ccbe586bd3587b56/cc/layers/layer_proto_converter.cc [modify] https://crrev.com/95d9e6b63179642af8391906ccbe586bd3587b56/cc/test/fake_layer_tree_host.cc [modify] https://crrev.com/95d9e6b63179642af8391906ccbe586bd3587b56/cc/test/layer_test_common.cc [modify] https://crrev.com/95d9e6b63179642af8391906ccbe586bd3587b56/cc/trees/draw_property_utils.cc [modify] https://crrev.com/95d9e6b63179642af8391906ccbe586bd3587b56/cc/trees/draw_property_utils.h [modify] https://crrev.com/95d9e6b63179642af8391906ccbe586bd3587b56/cc/trees/layer_tree.cc [modify] https://crrev.com/95d9e6b63179642af8391906ccbe586bd3587b56/cc/trees/layer_tree.h [modify] https://crrev.com/95d9e6b63179642af8391906ccbe586bd3587b56/cc/trees/layer_tree_host.cc [modify] https://crrev.com/95d9e6b63179642af8391906ccbe586bd3587b56/cc/trees/layer_tree_host.h [modify] https://crrev.com/95d9e6b63179642af8391906ccbe586bd3587b56/cc/trees/layer_tree_host_common.cc [modify] https://crrev.com/95d9e6b63179642af8391906ccbe586bd3587b56/cc/trees/layer_tree_host_common.h [modify] https://crrev.com/95d9e6b63179642af8391906ccbe586bd3587b56/cc/trees/layer_tree_host_common_unittest.cc [modify] https://crrev.com/95d9e6b63179642af8391906ccbe586bd3587b56/cc/trees/layer_tree_host_unittest.cc [modify] https://crrev.com/95d9e6b63179642af8391906ccbe586bd3587b56/cc/trees/layer_tree_host_unittest_animation.cc [modify] https://crrev.com/95d9e6b63179642af8391906ccbe586bd3587b56/cc/trees/layer_tree_host_unittest_serialization.cc [modify] https://crrev.com/95d9e6b63179642af8391906ccbe586bd3587b56/cc/trees/property_tree_builder.cc [modify] https://crrev.com/95d9e6b63179642af8391906ccbe586bd3587b56/cc/trees/property_tree_builder.h [modify] https://crrev.com/95d9e6b63179642af8391906ccbe586bd3587b56/cc/trees/tree_synchronizer.cc [modify] https://crrev.com/95d9e6b63179642af8391906ccbe586bd3587b56/cc/trees/tree_synchronizer_unittest.cc [modify] https://crrev.com/95d9e6b63179642af8391906ccbe586bd3587b56/content/renderer/gpu/gpu_benchmarking_extension.cc [modify] https://crrev.com/95d9e6b63179642af8391906ccbe586bd3587b56/content/renderer/gpu/render_widget_compositor.cc [modify] https://crrev.com/95d9e6b63179642af8391906ccbe586bd3587b56/third_party/WebKit/Source/platform/testing/WebLayerTreeViewImplForTesting.cpp [modify] https://crrev.com/95d9e6b63179642af8391906ccbe586bd3587b56/ui/compositor/compositor.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b1931ad10e9910d982447a98a661b135a84de319 commit b1931ad10e9910d982447a98a661b135a84de319 Author: khushalsagar <khushalsagar@chromium.org> Date: Thu Sep 15 02:07:51 2016 cc: Make LayerTreeHost a protected Layer member. Removes all external access to LayerTreeHost except for tests. Next change will remove it from Layer altogether. BUG= 628683 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel Review-Url: https://codereview.chromium.org/2331983002 Cr-Commit-Position: refs/heads/master@{#418756} [modify] https://crrev.com/b1931ad10e9910d982447a98a661b135a84de319/cc/layers/layer.h [modify] https://crrev.com/b1931ad10e9910d982447a98a661b135a84de319/cc/layers/layer_proto_converter_unittest.cc [modify] https://crrev.com/b1931ad10e9910d982447a98a661b135a84de319/cc/layers/layer_unittest.cc [modify] https://crrev.com/b1931ad10e9910d982447a98a661b135a84de319/cc/layers/nine_patch_layer_unittest.cc [modify] https://crrev.com/b1931ad10e9910d982447a98a661b135a84de319/cc/layers/painted_scrollbar_layer_unittest.cc [modify] https://crrev.com/b1931ad10e9910d982447a98a661b135a84de319/cc/layers/scrollbar_layer_unittest.cc [modify] https://crrev.com/b1931ad10e9910d982447a98a661b135a84de319/cc/layers/ui_resource_layer_unittest.cc [modify] https://crrev.com/b1931ad10e9910d982447a98a661b135a84de319/cc/test/fake_layer_tree_host.h [modify] https://crrev.com/b1931ad10e9910d982447a98a661b135a84de319/cc/trees/layer_tree.cc [modify] https://crrev.com/b1931ad10e9910d982447a98a661b135a84de319/cc/trees/layer_tree.h [modify] https://crrev.com/b1931ad10e9910d982447a98a661b135a84de319/cc/trees/layer_tree_host.cc [modify] https://crrev.com/b1931ad10e9910d982447a98a661b135a84de319/cc/trees/layer_tree_host.h [modify] https://crrev.com/b1931ad10e9910d982447a98a661b135a84de319/cc/trees/layer_tree_host_common_unittest.cc [modify] https://crrev.com/b1931ad10e9910d982447a98a661b135a84de319/cc/trees/layer_tree_host_unittest.cc [modify] https://crrev.com/b1931ad10e9910d982447a98a661b135a84de319/cc/trees/layer_tree_host_unittest_serialization.cc [modify] https://crrev.com/b1931ad10e9910d982447a98a661b135a84de319/cc/trees/property_tree_builder.cc [modify] https://crrev.com/b1931ad10e9910d982447a98a661b135a84de319/content/renderer/pepper/pepper_compositor_host.cc [modify] https://crrev.com/b1931ad10e9910d982447a98a661b135a84de319/third_party/WebKit/Source/platform/graphics/compositing/PaintArtifactCompositor.cpp [modify] https://crrev.com/b1931ad10e9910d982447a98a661b135a84de319/third_party/WebKit/Source/platform/testing/WebLayerTreeViewImplForTesting.cpp
Comment 1 by khushals...@chromium.org
, Jul 15 2016