New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 628678 link

Starred by 2 users

Issue metadata

Status: Archived
Owner:
Closed: Nov 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Feature



Sign in to add a comment

Build Annotator should "get latest" automatically

Project Member Reported by michae...@chromium.org, Jul 15 2016

Issue description

1. Load the build annotator yesterday:
https://chromiumos-build-annotator.googleplex.com/build_annotations/builds_list/master-chromium-pfq/

2. Load the build annotator today

Expected: the annotator loads with the latest build ID at the top.
Actual: the annotator is limited to the build ID you saw yesterday.

Why do we have to click "Get latest" and "Update list"? It would be nice for that to be done automatically, unless the user explicitly asks for a different build ID.

If there is a good reason it's like this, let's document that here :-)
 
Components: -Infra Infra>Platform
Labels: -Type-Bug Type-Feature
Smells like a low priority feature request.
Cc: benhenry@chromium.org
It is, but the current state makes the tool pretty confusing to use, so it's pretty bug-like.

That said, if we can get some traction on issue 580554 (support for internal waterfalls for SoM) which would unblock adding cros specific features (like annotation) to that (theoretically more maintainable) tool, we could prioritize SoM work instead...

Cc: martiniss@chromium.org
Components: Infra>Sheriffing
IIUC, issue 580554 is in progress and is "working" to some degree. Adding Steven as he has more context.
Cc: d...@chromium.org
cc-ing dan FYI

External waterfalls are showing up on sheriff-o-matic-staging.appspot.com just fine; internal needs a bit more work. I haven't had a chance to set that up yet, but I might have time tomorrow.

Comment 5 by d...@chromium.org, Jul 19 2016

Cc: -d...@chromium.org -benhenry@chromium.org -martiniss@chromium.org akes...@chromium.org dgarr...@chromium.org
This is not a Chrome Infrastructure service, so I don't think we can do much here. I don't actually know who owns it, but they probably should be owners. I'm going to switch this over to CrOS infra people and see if this is something they know about.
Owner: akes...@chromium.org
Our team build the tool, but I don't think it's been updated since the author left the team (pprabhu@).

Comment 7 by estaab@chromium.org, Jul 25 2016

Components: -Infra>Platform
Status: Assigned (was: Untriaged)
Owner: pprabhu@chromium.org
Prathmesh is back on the team. If you feel like taking a stab at this, by all means. Though I doubht it is worth more than an hour of effort (and it may well take longer then that due to bitrot in our annotator deployment process). If so, just wontfix.
Status: Started (was: Assigned)
Yay! pet project ;)
Cc: chingcodes@chromium.org
Project Member

Comment 12 by bugdroid1@chromium.org, Nov 10 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/431cbf6bf1f237b82677ff94d8a321516e61ba3a

commit 431cbf6bf1f237b82677ff94d8a321516e61ba3a
Author: Prathmesh Prabhu <pprabhu@chromium.org>
Date: Fri Nov 04 20:26:19 2016

lib: Use inspect to get entry point of script.

cros_build_lib was importing __main__ to get the path to the entry point
of the pythong script. Use the |inspect| module instead to avoid
importing __main__.
Importing __main__ is bad form when you don't control the entry points
of all users of your library. In particular, this failed when imported
from cq_stats appengine app. Autotest is another user where user of
chroimte/lib is not in chromite itself.

BUG= chromium:628678 
TEST=unittests, debug print of MachineDetails' return is unchanged.

Change-Id: I0a48b03cdb3c12e9ca8cf00e709d5b67044e3983
Reviewed-on: https://chromium-review.googlesource.com/407972
Commit-Ready: Prathmesh Prabhu <pprabhu@chromium.org>
Tested-by: Prathmesh Prabhu <pprabhu@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/431cbf6bf1f237b82677ff94d8a321516e61ba3a/lib/cros_build_lib.py

Project Member

Comment 13 by bugdroid1@chromium.org, Nov 10 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/3b60a87c44020d6af4d56bc3fd3ab4571a1da01a

commit 3b60a87c44020d6af4d56bc3fd3ab4571a1da01a
Author: Prathmesh Prabhu <pprabhu@chromium.org>
Date: Fri Nov 04 20:49:00 2016

cq_stats: Fix some system library dependencies.

Deal with bitrot in the cq_stats app.

lib/metrics now depends on ssl, so request appengine to provide that
library.
cros_build_lib now depends on signal. Fake that.

BUG= chromium:628678 
TEST=$./appengine/ae_shell cq_stats
     $./dev_appserver cq_stats/app.yaml
     ... loading <your_hostname>:8080 works again!

Change-Id: I4f2141d2d1256168fd884629d5187f5537893441
Reviewed-on: https://chromium-review.googlesource.com/407973
Commit-Ready: Prathmesh Prabhu <pprabhu@chromium.org>
Tested-by: Prathmesh Prabhu <pprabhu@chromium.org>
Reviewed-by: Don Garrett <dgarrett@chromium.org>

[modify] https://crrev.com/3b60a87c44020d6af4d56bc3fd3ab4571a1da01a/appengine/cq_stats/app.yaml
[modify] https://crrev.com/3b60a87c44020d6af4d56bc3fd3ab4571a1da01a/appengine/cq_stats/cq_stats/fake_system_modules.py

Project Member

Comment 14 by bugdroid1@chromium.org, Nov 18 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/4390a04d3fd66437f07a690f1893701ca1fda64d

commit 4390a04d3fd66437f07a690f1893701ca1fda64d
Author: Prathmesh Prabhu <pprabhu@chromium.org>
Date: Sat Nov 05 01:33:43 2016

cq_stats: Use GET url params instead of sessions.

Cookie based sessions should be used when we want to preserve user
history across page loads. In this case, we merely want to pre-populate
form data when returning to a page. GET args are much better suited to
this purpose: They allow exact URL sharing, and they're safer to be used
with the 'back' button and play better with multiple tabs.

As a side effect, the "Get latest" button is now gone. The default, no
GET arguments URL always shows the latest builds.

BUG= chromium:628678 
TEST=manually verified various flows on local devserver.

Change-Id: I1cd489c64b3c999b0ac720b5f35d8492f6b0a692
Reviewed-on: https://chromium-review.googlesource.com/407974
Tested-by: Prathmesh Prabhu <pprabhu@chromium.org>
Reviewed-by: Prathmesh Prabhu <pprabhu@chromium.org>

[modify] https://crrev.com/4390a04d3fd66437f07a690f1893701ca1fda64d/appengine/cq_stats/cq_stats/settings.py
[modify] https://crrev.com/4390a04d3fd66437f07a690f1893701ca1fda64d/appengine/cq_stats/build_annotations/templates/build_annotations/edit_annotations.html
[modify] https://crrev.com/4390a04d3fd66437f07a690f1893701ca1fda64d/appengine/cq_stats/build_annotations/views.py
[modify] https://crrev.com/4390a04d3fd66437f07a690f1893701ca1fda64d/appengine/cq_stats/build_annotations/static/build_annotations/base.js
[modify] https://crrev.com/4390a04d3fd66437f07a690f1893701ca1fda64d/appengine/cq_stats/build_annotations/templates/build_annotations/index.html

Status: Fixed (was: Started)

Comment 16 by dchan@google.com, Mar 4 2017

Labels: VerifyIn-58

Comment 17 by dchan@google.com, Apr 17 2017

Labels: VerifyIn-59

Comment 18 by dchan@google.com, May 30 2017

Labels: VerifyIn-60
Labels: VerifyIn-61

Comment 20 by dchan@chromium.org, Oct 14 2017

Status: Archived (was: Fixed)

Sign in to add a comment