Issue metadata
Sign in to add a comment
|
ICE restart between Chrome 52 and 53 has chance of completely breaking connection. |
||||||||||||||||||||||
Issue descriptionVersion: 53.0.2785.8, making connection to 52 or ealier. OS: Any What steps will reproduce the problem? (1) Make a connection between Chrome 53 and 52 or earlier. (2) Perform an ICE restart initiated by the opposite endpoint as which initiated the call. (If Chrome 53 initiated the call, Chrome 52 should initiate the ICE restart). What is the expected output? ICE restart works as expected. Connectivity isn't interrupted. What do you see instead? 50% chance of connection being completely broken. Please use labels and text to provide additional information. This is happening because in M53 we stopped switching ICE roles every time an ICE restart occurred. The assumption was that if communicating with an old endpoint that DOES always switch ICE roles, the role conflict resolution mechanism would select a role. However, a then-unknown bug causes the role conflict resolution mechanism to fail if an offer is sent in the reverse direction of the initial offer-answer. This could occur if, for example, Peer A initiated the call, but Peer B loses and regains Internet access and initiates an ICE restart. When this occurs, there's a 50% chance of a failure. This is because a tiebreaker determines who switches their role in case of a conflict. M53 can switch its role properly, but M52 and earlier cannot.
,
Jul 17 2016
Your change meets the bar and is auto-approved for M53 (branch: 2785)
,
Jul 18 2016
Please merge your change to M53 branch 2785 ASAP (latest by 4:00 PM PST on Monday, 07/18) in order to make it to M53 dev release next week before Beta promotion.
,
Jul 18 2016
,
Jul 18 2016
Is there a link for the aforementioned 'then-unknown' bug?
,
Jul 18 2016
I fixed it inadvertently before I knew it existed, so I didn't bother filing a bug. Here's one for posterity, though: https://bugs.chromium.org/p/webrtc/issues/detail?id=6121
,
Jul 18 2016
Merged by this CL: https://codereview.webrtc.org/2156253002/
,
Jul 18 2016
If this is already merged to M53, please remove "Merge-Approved-53" label and apply "merge-merged-53" label. Thank you.
,
Jul 18 2016
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by deadbeef@chromium.org
, Jul 16 2016Status: Fixed (was: Started)