ash_unittests build failures under "simple chrome" cros_sdk env |
||||||||||||
Issue description
When compiling ash_unittests under a "simple chrome" cros-sdk environment the following build error occurred:
In file included from ../../testing/gtest/include/gtest/gtest.h:1878:0,
from ../../ash/test/ash_test_base.h:18,
from ../../ash/system/chromeos/power/video_activity_notifier_unittest.cc:9:
../../ash/system/chromeos/power/video_activity_notifier_unittest.cc: In member function 'virtual void ash::VideoActivityNotifierTest_NotifyI
mmediatelyOnStateChange_Test::TestBody()':
../../testing/gtest/include/gtest/internal/gtest-internal.h:133:55: error: converting 'false' to pointer type for argument 1 of 'char testin
g::internal::IsNullLiteralHelper(testing::internal::Secret*)' [-Werror=conversion-null]
(sizeof(::testing::internal::IsNullLiteralHelper(x)) == 1)
^
../../testing/gtest/include/gtest/gtest_pred_impl.h:77:52: note: in definition of macro 'GTEST_ASSERT_'
if (const ::testing::AssertionResult gtest_ar = (expression)) \
^
../../testing/gtest/include/gtest/gtest_pred_impl.h:162:3: note: in expansion of macro 'GTEST_PRED_FORMAT2_'
GTEST_PRED_FORMAT2_(pred_format, v1, v2, GTEST_NONFATAL_FAILURE_)
^
../../testing/gtest/include/gtest/gtest.h:1927:3: note: in expansion of macro 'EXPECT_PRED_FORMAT2'
EXPECT_PRED_FORMAT2(::testing::internal:: \
^
../../testing/gtest/include/gtest/gtest.h:1928:32: note: in expansion of macro 'GTEST_IS_NULL_LITERAL_'
EqHelper<GTEST_IS_NULL_LITERAL_(expected)>::Compare, \
^
../../ash/system/chromeos/power/video_activity_notifier_unittest.cc:51:3: note: in expansion of macro 'EXPECT_EQ'
EXPECT_EQ(false, power_client_->PopVideoActivityReport());
^
A similar issue was fixed here:
https://crrev.com/2a2233d6b1718080cb0842751fd5030708a2340e
,
Jul 16 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5cbb8fc51771e06048c7fa3d7a62645a84887a94 commit 5cbb8fc51771e06048c7fa3d7a62645a84887a94 Author: robert.bradford <robert.bradford@intel.com> Date: Sat Jul 16 05:05:34 2016 ash: Use EXPECT_TRUE/FALSE vs EXPECT_EQ in VideoActivityNotifierTest This resolves build failures using gcc under "cros chrome-sdk" due to -Werror=conversion-null. See bug for full build error log. BUG= 628667 TEST=ash_unittests builds under "cros chrome-sdk" Review-Url: https://codereview.chromium.org/2155693003 Cr-Commit-Position: refs/heads/master@{#405935} [modify] https://crrev.com/5cbb8fc51771e06048c7fa3d7a62645a84887a94/ash/system/chromeos/power/video_activity_notifier_unittest.cc
,
Jul 18 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9f937f5b6731f71d199d00c34b895e10661bc13e commit 9f937f5b6731f71d199d00c34b895e10661bc13e Author: robert.bradford <robert.bradford@intel.com> Date: Mon Jul 18 17:30:48 2016 ash: Adjust ascii art comment to avoid looking like multiline comment When building ash_unittests under "simple chrome": cros chrome-sdk gcc is used. The comment in WindowModalityControllerTest looks like a multline comment, triggering -Werror=comment. This CL adjusts the ascii art to avoid triggering that error. BUG= 628667 TEST=ash_unittests builds under "cros chrome-sdk" Review-Url: https://codereview.chromium.org/2160603002 Cr-Commit-Position: refs/heads/master@{#406024} [modify] https://crrev.com/9f937f5b6731f71d199d00c34b895e10661bc13e/ash/wm/window_modality_controller_unittest.cc
,
Jul 18 2016
ash_unittests now builds fine under "simple chrome" with these changes integrated.
,
Aug 29 2016
,
Aug 29 2016
bulk verified
,
Sep 13 2016
This needs to be merged to 53 to fix issue 646424.
,
Sep 13 2016
,
Sep 13 2016
[Automated comment] Request affecting a post-stable build (M53), manual review required.
,
Sep 13 2016
Approving merge for M53 cros.
,
Sep 13 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7128fa473b1230227e5363ba0d6d3c70477accc4 commit 7128fa473b1230227e5363ba0d6d3c70477accc4 Author: Daniel Erat <derat@chromium.org> Date: Tue Sep 13 21:21:27 2016 ash: Adjust ascii art comment to avoid looking like multiline comment When building ash_unittests under "simple chrome": cros chrome-sdk gcc is used. The comment in WindowModalityControllerTest looks like a multline comment, triggering -Werror=comment. This CL adjusts the ascii art to avoid triggering that error. BUG= 628667 TEST=ash_unittests builds under "cros chrome-sdk" Review-Url: https://codereview.chromium.org/2160603002 Cr-Commit-Position: refs/heads/master@{#406024} (cherry picked from commit 9f937f5b6731f71d199d00c34b895e10661bc13e) Review URL: https://codereview.chromium.org/2339703002 . Cr-Commit-Position: refs/branch-heads/2785@{#883} Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382} [modify] https://crrev.com/7128fa473b1230227e5363ba0d6d3c70477accc4/ash/wm/window_modality_controller_unittest.cc
,
Sep 13 2016
,
Oct 7 2016
,
Oct 21 2016
Closing bug as per comment #4 |
||||||||||||
►
Sign in to add a comment |
||||||||||||
Comment 1 by robert.b...@intel.com
, Jul 15 2016