plugins/fullscreen-plugins-dont-reload.html Seems to have started at: https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20Leak/builds/21037 Possible culprit CL: https://codereview.chromium.org/2107233002 I've marked this as P1 as it is obscurring other failures on the same bot ... feel free to disable the test in the short term if that helps.
Issue 629058 has been merged into this issue.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fc7e3eb971fc7cdb22c69a57feb3ae741eb467ba commit fc7e3eb971fc7cdb22c69a57feb3ae741eb467ba Author: grt <grt@chromium.org> Date: Tue Jul 19 12:51:18 2016 Mark plugins/fullscreen-plugins-dont-reload.html as leaky. BUG= 628662 TBR=foolip@chromium.org Review-Url: https://codereview.chromium.org/2165573002 Cr-Commit-Position: refs/heads/master@{#406256} [modify] https://crrev.com/fc7e3eb971fc7cdb22c69a57feb3ae741eb467ba/third_party/WebKit/LayoutTests/LeakExpectations
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/87365b3f6c6293bac8a2513cef257d8e2cb0898a commit 87365b3f6c6293bac8a2513cef257d8e2cb0898a Author: foolip <foolip@chromium.org> Date: Fri Jul 22 06:55:06 2016 Revert of Reland "Implement FullScreen using top layer." (patchset #13 id:260001 of https://codereview.chromium.org/2107233002/ ) Reason for revert: Multiple regressions around the fullscreen transition becoming visibly worse, as well as a suspected leak. BUG= 628554 , 628605 , 628662 , 630191 Original issue's description: > Reland "Implement FullScreen using top layer." > > This reverts commit 2460a95281959d1b4dd941fed10998adf8dcb63c. > > Notable changes on top of previous attempt: > > full-screen-iframe-ua-style.html is changed to use overflow property > instead, as position is no longer changed on ancestors. > > :root:-webkit-full-screen-ancestor { overflow: hidden !important; } is > retained, as the previous attempt regressed on Vimeo ( crbug.com/543946 ) > and it's not clear yet how to handle this in the spec: > https://github.com/whatwg/fullscreen/issues/19 > > Make ::backdrop work for replaced content (video, iframe, etc.) by > changing StyleResolver::createPseudoElementIfNeeded to allow creating > the ::backdrop pseudo-element even if the parent doesn't support > children. With this change, full-screen-stacking-context.html was > simplified and full-screen-video-has-backdrop.html was > simplified+renamed. > > The will-change override is dropped, as full-screen-will-change.html > passes without it. > > BUG= 240576 , 543946 > > Committed: https://crrev.com/d666f503ae854fac360cc70da1f5971a6724546a > Cr-Commit-Position: refs/heads/master@{#405478} TBR=dsinclair@chromium.org,esprehn@chromium.org,eae@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG= 240576 , 543946 Review-Url: https://codereview.chromium.org/2168373002 Cr-Commit-Position: refs/heads/master@{#407089} [modify] https://crrev.com/87365b3f6c6293bac8a2513cef257d8e2cb0898a/third_party/WebKit/LayoutTests/fast/css/invalidation/fullscreen-expected.txt [modify] https://crrev.com/87365b3f6c6293bac8a2513cef257d8e2cb0898a/third_party/WebKit/LayoutTests/fast/css/invalidation/fullscreen.html [modify] https://crrev.com/87365b3f6c6293bac8a2513cef257d8e2cb0898a/third_party/WebKit/LayoutTests/fullscreen/enter-exit-full-screen-hover.html [modify] https://crrev.com/87365b3f6c6293bac8a2513cef257d8e2cb0898a/third_party/WebKit/LayoutTests/fullscreen/full-screen-iframe-ua-style-expected.txt [modify] https://crrev.com/87365b3f6c6293bac8a2513cef257d8e2cb0898a/third_party/WebKit/LayoutTests/fullscreen/full-screen-iframe-ua-style.html [modify] https://crrev.com/87365b3f6c6293bac8a2513cef257d8e2cb0898a/third_party/WebKit/LayoutTests/fullscreen/full-screen-iframe-zIndex.html [delete] https://crrev.com/6c23d97a65d8568329a386bd1da1df27d8d0a893/third_party/WebKit/LayoutTests/fullscreen/full-screen-is-in-top-layer-expected.html [delete] https://crrev.com/6c23d97a65d8568329a386bd1da1df27d8d0a893/third_party/WebKit/LayoutTests/fullscreen/full-screen-is-in-top-layer.html [modify] https://crrev.com/87365b3f6c6293bac8a2513cef257d8e2cb0898a/third_party/WebKit/LayoutTests/fullscreen/full-screen-render-inline-expected.html [modify] https://crrev.com/87365b3f6c6293bac8a2513cef257d8e2cb0898a/third_party/WebKit/LayoutTests/fullscreen/full-screen-stacking-context-expected.html [modify] https://crrev.com/87365b3f6c6293bac8a2513cef257d8e2cb0898a/third_party/WebKit/LayoutTests/fullscreen/full-screen-stacking-context.html [modify] https://crrev.com/87365b3f6c6293bac8a2513cef257d8e2cb0898a/third_party/WebKit/LayoutTests/fullscreen/full-screen-zIndex-expected.html [modify] https://crrev.com/87365b3f6c6293bac8a2513cef257d8e2cb0898a/third_party/WebKit/LayoutTests/fullscreen/parent-flow-inline-with-block-child-expected.html [delete] https://crrev.com/6c23d97a65d8568329a386bd1da1df27d8d0a893/third_party/WebKit/LayoutTests/fullscreen/rendering/backdrop-expected.html [delete] https://crrev.com/6c23d97a65d8568329a386bd1da1df27d8d0a893/third_party/WebKit/LayoutTests/fullscreen/rendering/backdrop-iframe-expected.html [delete] https://crrev.com/6c23d97a65d8568329a386bd1da1df27d8d0a893/third_party/WebKit/LayoutTests/fullscreen/rendering/backdrop-iframe.html [delete] https://crrev.com/6c23d97a65d8568329a386bd1da1df27d8d0a893/third_party/WebKit/LayoutTests/fullscreen/rendering/backdrop-object-expected.html [delete] https://crrev.com/6c23d97a65d8568329a386bd1da1df27d8d0a893/third_party/WebKit/LayoutTests/fullscreen/rendering/backdrop-object.html [delete] https://crrev.com/6c23d97a65d8568329a386bd1da1df27d8d0a893/third_party/WebKit/LayoutTests/fullscreen/rendering/backdrop-video-expected.html [delete] https://crrev.com/6c23d97a65d8568329a386bd1da1df27d8d0a893/third_party/WebKit/LayoutTests/fullscreen/rendering/backdrop-video.html [delete] https://crrev.com/6c23d97a65d8568329a386bd1da1df27d8d0a893/third_party/WebKit/LayoutTests/fullscreen/rendering/backdrop.html [delete] https://crrev.com/6c23d97a65d8568329a386bd1da1df27d8d0a893/third_party/WebKit/LayoutTests/fullscreen/rendering/overflow-root.html [delete] https://crrev.com/6c23d97a65d8568329a386bd1da1df27d8d0a893/third_party/WebKit/LayoutTests/fullscreen/rendering/overflow.html [modify] https://crrev.com/87365b3f6c6293bac8a2513cef257d8e2cb0898a/third_party/WebKit/LayoutTests/fullscreen/resources/empty.html [modify] https://crrev.com/87365b3f6c6293bac8a2513cef257d8e2cb0898a/third_party/WebKit/LayoutTests/fullscreen/resources/green.html [delete] https://crrev.com/6c23d97a65d8568329a386bd1da1df27d8d0a893/third_party/WebKit/LayoutTests/fullscreen/resources/white.html [modify] https://crrev.com/87365b3f6c6293bac8a2513cef257d8e2cb0898a/third_party/WebKit/LayoutTests/fullscreen/video-webkit-transform-expected.html [delete] https://crrev.com/6c23d97a65d8568329a386bd1da1df27d8d0a893/third_party/WebKit/LayoutTests/virtual/android/fullscreen/rendering/backdrop-video-expected.html [modify] https://crrev.com/87365b3f6c6293bac8a2513cef257d8e2cb0898a/third_party/WebKit/Source/core/core.gypi [modify] https://crrev.com/87365b3f6c6293bac8a2513cef257d8e2cb0898a/third_party/WebKit/Source/core/css/fullscreen.css [modify] https://crrev.com/87365b3f6c6293bac8a2513cef257d8e2cb0898a/third_party/WebKit/Source/core/css/html.css [modify] https://crrev.com/87365b3f6c6293bac8a2513cef257d8e2cb0898a/third_party/WebKit/Source/core/css/resolver/StyleAdjuster.cpp [modify] https://crrev.com/87365b3f6c6293bac8a2513cef257d8e2cb0898a/third_party/WebKit/Source/core/css/resolver/StyleResolver.cpp [modify] https://crrev.com/87365b3f6c6293bac8a2513cef257d8e2cb0898a/third_party/WebKit/Source/core/dom/Document.cpp [modify] https://crrev.com/87365b3f6c6293bac8a2513cef257d8e2cb0898a/third_party/WebKit/Source/core/dom/Document.h [modify] https://crrev.com/87365b3f6c6293bac8a2513cef257d8e2cb0898a/third_party/WebKit/Source/core/dom/Fullscreen.cpp [modify] https://crrev.com/87365b3f6c6293bac8a2513cef257d8e2cb0898a/third_party/WebKit/Source/core/dom/Fullscreen.h [modify] https://crrev.com/87365b3f6c6293bac8a2513cef257d8e2cb0898a/third_party/WebKit/Source/core/dom/LayoutTreeBuilder.cpp [modify] https://crrev.com/87365b3f6c6293bac8a2513cef257d8e2cb0898a/third_party/WebKit/Source/core/dom/PseudoElement.cpp [modify] https://crrev.com/87365b3f6c6293bac8a2513cef257d8e2cb0898a/third_party/WebKit/Source/core/frame/FrameView.cpp [modify] https://crrev.com/87365b3f6c6293bac8a2513cef257d8e2cb0898a/third_party/WebKit/Source/core/layout/LayoutBlock.cpp [modify] https://crrev.com/87365b3f6c6293bac8a2513cef257d8e2cb0898a/third_party/WebKit/Source/core/layout/LayoutBox.h [add] https://crrev.com/87365b3f6c6293bac8a2513cef257d8e2cb0898a/third_party/WebKit/Source/core/layout/LayoutFullScreen.cpp [add] https://crrev.com/87365b3f6c6293bac8a2513cef257d8e2cb0898a/third_party/WebKit/Source/core/layout/LayoutFullScreen.h [modify] https://crrev.com/87365b3f6c6293bac8a2513cef257d8e2cb0898a/third_party/WebKit/Source/core/layout/LayoutInline.cpp [modify] https://crrev.com/87365b3f6c6293bac8a2513cef257d8e2cb0898a/third_party/WebKit/Source/core/layout/LayoutMenuList.cpp [modify] https://crrev.com/87365b3f6c6293bac8a2513cef257d8e2cb0898a/third_party/WebKit/Source/core/layout/LayoutObject.h [modify] https://crrev.com/87365b3f6c6293bac8a2513cef257d8e2cb0898a/third_party/WebKit/Source/core/layout/LayoutVideo.cpp [modify] https://crrev.com/87365b3f6c6293bac8a2513cef257d8e2cb0898a/third_party/WebKit/Source/core/layout/LayoutVideo.h [add] https://crrev.com/87365b3f6c6293bac8a2513cef257d8e2cb0898a/third_party/WebKit/Source/core/layout/api/LayoutFullScreenItem.h [modify] https://crrev.com/87365b3f6c6293bac8a2513cef257d8e2cb0898a/third_party/WebKit/Source/core/layout/api/LayoutItem.h [modify] https://crrev.com/87365b3f6c6293bac8a2513cef257d8e2cb0898a/third_party/WebKit/Source/web/FullscreenController.cpp [modify] https://crrev.com/87365b3f6c6293bac8a2513cef257d8e2cb0898a/third_party/WebKit/Source/web/tests/WebFrameTest.cpp
Any update on this bug? Memory leaks need to be fixed asap.
It was fixed by reverting. Will have to investigate when relanding.
Comment 1 by grt@chromium.org
, Jul 19 2016