New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 628655 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug
Team-Accessibility

Blocking:
issue 594887
issue 557401



Sign in to add a comment

mash: Move ChromeVox panel layout management to ash

Project Member Reported by sadrul@chromium.org, Jul 15 2016

Issue description

ChromeVox shows a panel at the top of the screen. The work-area of the display is reduced so that it doesn't overlap this panel. We need to expose an API in ash to be able to do this from chrome.
 

Comment 1 by sadrul@chromium.org, Jul 15 2016

Summary: ash: Allow clients to change the working area (was: ash: Allow clients to change affect the working area)

Comment 2 by sadrul@chromium.org, Jul 15 2016

Blocking: 557401
Components: Internals>MUS
Labels: Proj-Mustash
Labels: NewComponent-Accessibility NewComponent-Accessibility-ChromeVox
Labels: -NewComponent-Accessibility-ChromeVox NewComponent-Accessibility-Browser
Labels: -newcomponent-accessibility-browser -newcomponent-accessibility
Cc: -jamescook@chromium.org warx@chromium.org
Labels: -mustash -Proj-Mustash Proj-Mustash-Mash
Owner: jamescook@chromium.org
Status: Started (was: Available)
This is causing a bunch of browser_tests failures under mash, including a bunch of login ones that aren't strictly a11y related. I'll take a look.

Project Member

Comment 8 by bugdroid1@chromium.org, Jan 12 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/85c447417212341e8657af9a706ae78a9946c167

commit 85c447417212341e8657af9a706ae78a9946c167
Author: James Cook <jamescook@chromium.org>
Date: Fri Jan 12 22:01:00 2018

cros: Make ChromeVoxPanel an ash::ShellObserver

ChromeVoxPanel needs to observe for fullscreen window transitions so it
can update its bounds. Instead of whole AccessibilityManager being a
ShellObserver, restrict it to ChromeVoxPanel so the observe is only
present when the panel is showing.

Also make some public methods private.

This is cleanup prior to trying to fix ChromeVoxPanel support for
go/mustash.

Bug:  628655 
Test: browser_tests
Change-Id: I145a19028fcc064bca70ece3bbef455e375b606a
Reviewed-on: https://chromium-review.googlesource.com/862995
Commit-Queue: James Cook <jamescook@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#529079}
[modify] https://crrev.com/85c447417212341e8657af9a706ae78a9946c167/chrome/browser/chromeos/accessibility/accessibility_manager.cc
[modify] https://crrev.com/85c447417212341e8657af9a706ae78a9946c167/chrome/browser/chromeos/accessibility/accessibility_manager.h
[modify] https://crrev.com/85c447417212341e8657af9a706ae78a9946c167/chrome/browser/chromeos/accessibility/chromevox_panel.cc
[modify] https://crrev.com/85c447417212341e8657af9a706ae78a9946c167/chrome/browser/chromeos/accessibility/chromevox_panel.h
[modify] https://crrev.com/85c447417212341e8657af9a706ae78a9946c167/chrome/browser/ui/ash/chrome_shell_delegate.cc
[modify] https://crrev.com/85c447417212341e8657af9a706ae78a9946c167/testing/buildbot/filters/mojo.fyi.mash.browser_tests.filter

Project Member

Comment 9 by bugdroid1@chromium.org, Jan 25 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bc1eaa0208d1e1191de8a680810237f231c350b0

commit bc1eaa0208d1e1191de8a680810237f231c350b0
Author: James Cook <jamescook@chromium.org>
Date: Thu Jan 25 00:38:05 2018

Skip ChromeVoxPanel creation under --mash

We already disable ChromeVox while running chrome --mash. Skipping the
panel creation inside AccessibilityManager allows more browser_tests to
run under --mash, including a bunch of tests that don't need or exercise
ChromeVox. This improves our test coverage of login and policy under
mash and doesn't make our runtime behavior any worse.

Bug:  628655 
Test: browser_tests --mash
Change-Id: I634adbe5712be802f02148ff4c631e2110a963f4
Reviewed-on: https://chromium-review.googlesource.com/884837
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Commit-Queue: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#531761}
[modify] https://crrev.com/bc1eaa0208d1e1191de8a680810237f231c350b0/chrome/browser/chromeos/accessibility/accessibility_manager.cc
[modify] https://crrev.com/bc1eaa0208d1e1191de8a680810237f231c350b0/testing/buildbot/filters/mojo.fyi.mash.browser_tests.filter

Components: -Internals>MUS Internals>Services>WindowService
Components: -MUS
I'm going to look at this again. It's awkward because the ChromeVox widget seems to need information about:
* Whether or not any window is fullscreen
* Whether its webui wants to be fullscreen or not
* WebContents navigation state (used to communicate between the extension and this panel)
* Whether the docked magnifier a11y feature is on, and how big its panel is

This interacts with shelf layout to set the work area.

I think the best way forward is to flag this widget as special, with a window property like "I'm chromevox" or "I consume work area". Ash will handle all the bounds/layout/work area computation. Ash owns most of the information to compute the desired bounds, so I think that's the simplest way to go.

Project Member

Comment 13 by bugdroid1@chromium.org, Mar 2 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cc4be1cb9d4b439feacae23757d1b339b302e349

commit cc4be1cb9d4b439feacae23757d1b339b302e349
Author: James Cook <jamescook@chromium.org>
Date: Fri Mar 02 17:53:19 2018

cros: Cleanup ShelfWidget::DelegateView shutdown

Make it use DeleteDelegate() to be more consistent with
StatusAreaWidgetDelegate. Defer closing the widget until all the
top-level windows are closed.

Bug:  628655 
Test: ash_unittests
Change-Id: I066b45dab9c848b8f990f7fb51f0170e5e66a861
Reviewed-on: https://chromium-review.googlesource.com/907390
Commit-Queue: James Cook <jamescook@chromium.org>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540550}
[modify] https://crrev.com/cc4be1cb9d4b439feacae23757d1b339b302e349/ash/root_window_controller.cc
[modify] https://crrev.com/cc4be1cb9d4b439feacae23757d1b339b302e349/ash/shelf/shelf.cc
[modify] https://crrev.com/cc4be1cb9d4b439feacae23757d1b339b302e349/ash/shelf/shelf_widget.cc
[modify] https://crrev.com/cc4be1cb9d4b439feacae23757d1b339b302e349/ash/shelf/shelf_widget.h
[modify] https://crrev.com/cc4be1cb9d4b439feacae23757d1b339b302e349/ash/shell.cc

Project Member

Comment 14 by bugdroid1@chromium.org, Mar 3 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2f446916402fca6b3baddbf7647c19f53eff18c8

commit 2f446916402fca6b3baddbf7647c19f53eff18c8
Author: James Cook <jamescook@chromium.org>
Date: Sat Mar 03 02:26:27 2018

cros: Introduce ChromeVoxContainer to ash

The container holds the ChromeVoxPanel window, which is created by
chrome. Future CLs will make the ash::ChromeVoxLayoutManager manage
the bounds of ChromeVoxPanel and updates to the display work area.

This is needed to support mustash, as the information needed to compute
the window bounds is owned by ash, but ChromeVox is implemented with
an extension owned by chrome.

Bug:  628655 
Test: ash_unittests, open and close ChromeVox via Ctrl-Alt-Z
Change-Id: I02ac4384b949043eafc0578b06676b7e757888c5
Reviewed-on: https://chromium-review.googlesource.com/946517
Commit-Queue: James Cook <jamescook@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540723}
[modify] https://crrev.com/2f446916402fca6b3baddbf7647c19f53eff18c8/ash/BUILD.gn
[add] https://crrev.com/2f446916402fca6b3baddbf7647c19f53eff18c8/ash/accessibility/chromevox_layout_manager.cc
[add] https://crrev.com/2f446916402fca6b3baddbf7647c19f53eff18c8/ash/accessibility/chromevox_layout_manager.h
[add] https://crrev.com/2f446916402fca6b3baddbf7647c19f53eff18c8/ash/accessibility/chromevox_layout_manager_unittest.cc
[modify] https://crrev.com/2f446916402fca6b3baddbf7647c19f53eff18c8/ash/public/cpp/shell_window_ids.cc
[modify] https://crrev.com/2f446916402fca6b3baddbf7647c19f53eff18c8/ash/public/cpp/shell_window_ids.h
[modify] https://crrev.com/2f446916402fca6b3baddbf7647c19f53eff18c8/ash/root_window_controller.cc
[modify] https://crrev.com/2f446916402fca6b3baddbf7647c19f53eff18c8/chrome/browser/chromeos/accessibility/accessibility_manager.cc
[modify] https://crrev.com/2f446916402fca6b3baddbf7647c19f53eff18c8/chrome/browser/chromeos/accessibility/accessibility_manager_browsertest.cc
[modify] https://crrev.com/2f446916402fca6b3baddbf7647c19f53eff18c8/chrome/browser/chromeos/accessibility/chromevox_panel.cc

Project Member

Comment 15 by bugdroid1@chromium.org, Mar 5 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6949ff07672b27f41d30459796305fcd7862a4bd

commit 6949ff07672b27f41d30459796305fcd7862a4bd
Author: Greg Thompson <grt@chromium.org>
Date: Mon Mar 05 14:32:41 2018

Revert "cros: Cleanup ShelfWidget::DelegateView shutdown"

This reverts commit cc4be1cb9d4b439feacae23757d1b339b302e349.

Reason for revert: speculative revert for test crashes deep in ShelfWidget::Shutdown; see  https://crbug.com/818603 .
BUG= 818603 

Original change's description:
> cros: Cleanup ShelfWidget::DelegateView shutdown
> 
> Make it use DeleteDelegate() to be more consistent with
> StatusAreaWidgetDelegate. Defer closing the widget until all the
> top-level windows are closed.
> 
> Bug:  628655 
> Test: ash_unittests
> Change-Id: I066b45dab9c848b8f990f7fb51f0170e5e66a861
> Reviewed-on: https://chromium-review.googlesource.com/907390
> Commit-Queue: James Cook <jamescook@chromium.org>
> Reviewed-by: Michael Wasserman <msw@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#540550}

TBR=jamescook@chromium.org,msw@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug:  628655 
Change-Id: Ia3eb845627c77761bb15e94f9bbc9b3f1643f584
Reviewed-on: https://chromium-review.googlesource.com/948494
Reviewed-by: Greg Thompson <grt@chromium.org>
Commit-Queue: Greg Thompson <grt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540819}
[modify] https://crrev.com/6949ff07672b27f41d30459796305fcd7862a4bd/ash/root_window_controller.cc
[modify] https://crrev.com/6949ff07672b27f41d30459796305fcd7862a4bd/ash/shelf/shelf.cc
[modify] https://crrev.com/6949ff07672b27f41d30459796305fcd7862a4bd/ash/shelf/shelf_widget.cc
[modify] https://crrev.com/6949ff07672b27f41d30459796305fcd7862a4bd/ash/shelf/shelf_widget.h
[modify] https://crrev.com/6949ff07672b27f41d30459796305fcd7862a4bd/ash/shell.cc

Summary: mash: Move ChromeVox panel layout management to ash (was: ash: Allow clients to change the working area)
Retitling to reflect our plan to move ChromeVox "accessibility panel" layout management into ash, rather than exposing a direct "change work area" API.

Project Member

Comment 17 by bugdroid1@chromium.org, Mar 7 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b263b51b16652c73850848cf21d7b1cd9058281a

commit b263b51b16652c73850848cf21d7b1cd9058281a
Author: James Cook <jamescook@chromium.org>
Date: Wed Mar 07 22:30:33 2018

cros: Move ChromeVoxPanel bounds management into ash

ChromeVoxPanel depends on knowledge of fullscreen state and docked
magnifier state in order to compute its bounds. In addition it can
update the window manager's work area. Under go/mustash this knowledge
lives in the ash process, not in the browser. Therefore move the
bounds and work area management into ash.

Next steps include introducing a mojo interface for setting the
ChromeVox panel's fullscreen state and moving AccessibilityObserver
support to ash::AccessibilityController from the system tray code.

Bug:  628655 ,  819351 
Test: added to ash_unittests
Change-Id: Ibb27a0b8ab6b998ecd305b7e7bfbad8b35853613
Reviewed-on: https://chromium-review.googlesource.com/952263
Commit-Queue: James Cook <jamescook@chromium.org>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Reviewed-by: David Tseng <dtseng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541614}
[modify] https://crrev.com/b263b51b16652c73850848cf21d7b1cd9058281a/ash/BUILD.gn
[modify] https://crrev.com/b263b51b16652c73850848cf21d7b1cd9058281a/ash/accessibility/accessibility_controller.cc
[modify] https://crrev.com/b263b51b16652c73850848cf21d7b1cd9058281a/ash/accessibility/accessibility_controller.h
[add] https://crrev.com/b263b51b16652c73850848cf21d7b1cd9058281a/ash/accessibility/accessibility_panel_layout_manager.cc
[add] https://crrev.com/b263b51b16652c73850848cf21d7b1cd9058281a/ash/accessibility/accessibility_panel_layout_manager.h
[add] https://crrev.com/b263b51b16652c73850848cf21d7b1cd9058281a/ash/accessibility/accessibility_panel_layout_manager_unittest.cc
[delete] https://crrev.com/aff665fc085f8acf570abdab73098d833fdb8b7c/ash/accessibility/chromevox_layout_manager.cc
[delete] https://crrev.com/aff665fc085f8acf570abdab73098d833fdb8b7c/ash/accessibility/chromevox_layout_manager.h
[delete] https://crrev.com/aff665fc085f8acf570abdab73098d833fdb8b7c/ash/accessibility/chromevox_layout_manager_unittest.cc
[modify] https://crrev.com/b263b51b16652c73850848cf21d7b1cd9058281a/ash/public/cpp/shell_window_ids.cc
[modify] https://crrev.com/b263b51b16652c73850848cf21d7b1cd9058281a/ash/public/cpp/shell_window_ids.h
[modify] https://crrev.com/b263b51b16652c73850848cf21d7b1cd9058281a/ash/root_window_controller.cc
[modify] https://crrev.com/b263b51b16652c73850848cf21d7b1cd9058281a/ash/shelf/shelf.cc
[modify] https://crrev.com/b263b51b16652c73850848cf21d7b1cd9058281a/ash/shelf/shelf.h
[modify] https://crrev.com/b263b51b16652c73850848cf21d7b1cd9058281a/ash/shelf/shelf_layout_manager.cc
[modify] https://crrev.com/b263b51b16652c73850848cf21d7b1cd9058281a/ash/shelf/shelf_layout_manager.h
[modify] https://crrev.com/b263b51b16652c73850848cf21d7b1cd9058281a/ash/wm/lock_action_handler_layout_manager_unittest.cc
[modify] https://crrev.com/b263b51b16652c73850848cf21d7b1cd9058281a/ash/wm/lock_layout_manager_unittest.cc
[modify] https://crrev.com/b263b51b16652c73850848cf21d7b1cd9058281a/chrome/browser/chromeos/accessibility/accessibility_manager.cc
[modify] https://crrev.com/b263b51b16652c73850848cf21d7b1cd9058281a/chrome/browser/chromeos/accessibility/chromevox_panel.cc
[modify] https://crrev.com/b263b51b16652c73850848cf21d7b1cd9058281a/chrome/browser/chromeos/accessibility/chromevox_panel.h

Project Member

Comment 18 by bugdroid1@chromium.org, Mar 8 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/08e91dc19f17d714b22e2f89779249de0958c0d7

commit 08e91dc19f17d714b22e2f89779249de0958c0d7
Author: James Cook <jamescook@chromium.org>
Date: Thu Mar 08 18:53:19 2018

cros: Move ash::AccessibilityObserver list to AccessibilityController

The observers are used by more than the system tray, so move them out
of SystemTrayNotifier.

This is a prelude to adding a new observer method for accessibility
panel fullscreen state changes.

Bug:  628655 
Test: ash_unittests
Change-Id: Iddaf101c286a2539b5a362b5615db0bcf4f973cb
Reviewed-on: https://chromium-review.googlesource.com/953862
Reviewed-by: David Tseng <dtseng@chromium.org>
Commit-Queue: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541848}
[modify] https://crrev.com/08e91dc19f17d714b22e2f89779249de0958c0d7/ash/BUILD.gn
[modify] https://crrev.com/08e91dc19f17d714b22e2f89779249de0958c0d7/ash/accessibility/accessibility_controller.cc
[modify] https://crrev.com/08e91dc19f17d714b22e2f89779249de0958c0d7/ash/accessibility/accessibility_controller.h
[modify] https://crrev.com/08e91dc19f17d714b22e2f89779249de0958c0d7/ash/accessibility/accessibility_controller_unittest.cc
[rename] https://crrev.com/08e91dc19f17d714b22e2f89779249de0958c0d7/ash/accessibility/accessibility_observer.h
[modify] https://crrev.com/08e91dc19f17d714b22e2f89779249de0958c0d7/ash/ash_touch_exploration_manager_chromeos.cc
[modify] https://crrev.com/08e91dc19f17d714b22e2f89779249de0958c0d7/ash/ash_touch_exploration_manager_chromeos.h
[modify] https://crrev.com/08e91dc19f17d714b22e2f89779249de0958c0d7/ash/keyboard/keyboard_ui.cc
[modify] https://crrev.com/08e91dc19f17d714b22e2f89779249de0958c0d7/ash/magnifier/docked_magnifier_controller.cc
[modify] https://crrev.com/08e91dc19f17d714b22e2f89779249de0958c0d7/ash/system/ime/tray_ime_chromeos.cc
[modify] https://crrev.com/08e91dc19f17d714b22e2f89779249de0958c0d7/ash/system/ime/tray_ime_chromeos.h
[modify] https://crrev.com/08e91dc19f17d714b22e2f89779249de0958c0d7/ash/system/tray/system_tray_notifier.cc
[modify] https://crrev.com/08e91dc19f17d714b22e2f89779249de0958c0d7/ash/system/tray/system_tray_notifier.h
[modify] https://crrev.com/08e91dc19f17d714b22e2f89779249de0958c0d7/ash/system/tray_accessibility.cc
[modify] https://crrev.com/08e91dc19f17d714b22e2f89779249de0958c0d7/ash/system/tray_accessibility.h
[modify] https://crrev.com/08e91dc19f17d714b22e2f89779249de0958c0d7/ash/touch/touch_devices_controller.cc
[modify] https://crrev.com/08e91dc19f17d714b22e2f89779249de0958c0d7/ash/wm/workspace/backdrop_controller.cc
[modify] https://crrev.com/08e91dc19f17d714b22e2f89779249de0958c0d7/ash/wm/workspace/backdrop_controller.h
[modify] https://crrev.com/08e91dc19f17d714b22e2f89779249de0958c0d7/chrome/browser/chromeos/accessibility/accessibility_manager.cc

Project Member

Comment 19 by bugdroid1@chromium.org, Mar 10 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ee2daef503bf195efdb101bcd8c5ad7df9b6ff3e

commit ee2daef503bf195efdb101bcd8c5ad7df9b6ff3e
Author: James Cook <jamescook@chromium.org>
Date: Sat Mar 10 01:48:10 2018

Reland: cros: Cleanup ShelfWidget shutdown

Make it use DeleteDelegate() to be more consistent with
StatusAreaWidgetDelegate. Defer closing the widget until all the
top-level windows are closed. Don't try to close all windows more than
once during shutdown, which simplifies the shelf cleanup code.

Originally landed as cc4be1cb9d4b439feacae23757d1b339b302e349.

That version exposed a use-after-free in ash drag and drop code,
which was fixed separately. See  https://crbug.com/818603 

TBR=sadrul@chromium.org

Bug:  628655 ,  818603 
Test: ash_unittests
Change-Id: I4a8ade351456b476a19225f2c740e031f6b0e122
Reviewed-on: https://chromium-review.googlesource.com/956924
Commit-Queue: James Cook <jamescook@chromium.org>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542308}
[modify] https://crrev.com/ee2daef503bf195efdb101bcd8c5ad7df9b6ff3e/ash/magnifier/magnification_controller.cc
[modify] https://crrev.com/ee2daef503bf195efdb101bcd8c5ad7df9b6ff3e/ash/root_window_controller.cc
[modify] https://crrev.com/ee2daef503bf195efdb101bcd8c5ad7df9b6ff3e/ash/root_window_controller.h
[modify] https://crrev.com/ee2daef503bf195efdb101bcd8c5ad7df9b6ff3e/ash/shelf/shelf.cc
[modify] https://crrev.com/ee2daef503bf195efdb101bcd8c5ad7df9b6ff3e/ash/shelf/shelf_layout_manager_unittest.cc
[modify] https://crrev.com/ee2daef503bf195efdb101bcd8c5ad7df9b6ff3e/ash/shelf/shelf_widget.cc
[modify] https://crrev.com/ee2daef503bf195efdb101bcd8c5ad7df9b6ff3e/ash/shelf/shelf_widget.h
[modify] https://crrev.com/ee2daef503bf195efdb101bcd8c5ad7df9b6ff3e/ash/shell.cc
[modify] https://crrev.com/ee2daef503bf195efdb101bcd8c5ad7df9b6ff3e/testing/buildbot/filters/mash.ash_unittests.filter
[modify] https://crrev.com/ee2daef503bf195efdb101bcd8c5ad7df9b6ff3e/ui/aura/mus/window_tree_host_mus.cc

Project Member

Comment 20 by bugdroid1@chromium.org, Mar 12 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/769799b8a6ebc0ba1a5e72234c3870c48083f8e7

commit 769799b8a6ebc0ba1a5e72234c3870c48083f8e7
Author: James Cook <jamescook@chromium.org>
Date: Mon Mar 12 16:59:04 2018

cros: Make ChromeVox panel work under mash

For mash, the ash window manager runs outside the browser process.
Remove direct access to ash::Shell from ChromeVoxPanel.

* Init the panel widget using mus properties
* Introduce mojo API for setting whether the panel should be fullscreen
* Remove mash checks from AccessibilityManager
* Close ChromeVoxPanel immediately on shutdown and during reloads
by session state changes and multi-profile user switching. This helps
prevent having multiple panels open during shutdown, especially in
tests.

ChromeVox doesn't read things yet under mash, but at least the panel
opens now.

Bug:  628655 
Test: existing ash_unittests, browser_tests
Change-Id: I14cbf946809787791115930ad33c1c1d3357bf88
Reviewed-on: https://chromium-review.googlesource.com/956235
Reviewed-by: David Tseng <dtseng@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Commit-Queue: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542513}
[modify] https://crrev.com/769799b8a6ebc0ba1a5e72234c3870c48083f8e7/ash/accessibility/accessibility_controller.cc
[modify] https://crrev.com/769799b8a6ebc0ba1a5e72234c3870c48083f8e7/ash/accessibility/accessibility_controller.h
[modify] https://crrev.com/769799b8a6ebc0ba1a5e72234c3870c48083f8e7/ash/public/interfaces/accessibility_controller.mojom
[modify] https://crrev.com/769799b8a6ebc0ba1a5e72234c3870c48083f8e7/chrome/browser/chromeos/DEPS
[modify] https://crrev.com/769799b8a6ebc0ba1a5e72234c3870c48083f8e7/chrome/browser/chromeos/accessibility/accessibility_manager.cc
[modify] https://crrev.com/769799b8a6ebc0ba1a5e72234c3870c48083f8e7/chrome/browser/chromeos/accessibility/accessibility_manager_browsertest.cc
[modify] https://crrev.com/769799b8a6ebc0ba1a5e72234c3870c48083f8e7/chrome/browser/chromeos/accessibility/chromevox_panel.cc
[modify] https://crrev.com/769799b8a6ebc0ba1a5e72234c3870c48083f8e7/chrome/browser/chromeos/accessibility/chromevox_panel.h
[modify] https://crrev.com/769799b8a6ebc0ba1a5e72234c3870c48083f8e7/chrome/browser/ui/ash/accessibility/accessibility_controller_client_unittest.cc

Blocking: 594887
Project Member

Comment 22 by bugdroid1@chromium.org, Mar 13 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8c672d09d8137ecb2c340fb987d44e3ae55a8010

commit 8c672d09d8137ecb2c340fb987d44e3ae55a8010
Author: James Cook <jamescook@chromium.org>
Date: Tue Mar 13 21:41:23 2018

cros: Enable AccessibilityManagerTest in mash_browser_tests

Now that ChromeVoxPanel speaks mojo we can enable the following tests:
 AccessibilityManagerTest.AccessibilityMenuVisibility
 AccessibilityManagerTest.ChangingTypePrefInvokesNotification
 AccessibilityManagerTest.ChangingTypeInvokesNotification
 AccessibilityManagerTest.TypePref
 AccessibilityManagerLoginTest.BrailleOnLoginScreen
 AccessibilityManagerLoginTest.Login
 UserTypeInstantiation/AccessibilityManagerUserTypeTest.BrailleWhenLoggedIn/0
 UserTypeInstantiation/AccessibilityManagerUserTypeTest.BrailleWhenLoggedIn/1
 UserTypeInstantiation/AccessibilityManagerUserTypeTest.BrailleWhenLoggedIn/2
 UserTypeInstantiation/AccessibilityManagerUserTypeLoginTest.EnableOnLoginScreenAndLogin/0
 UserTypeInstantiation/AccessibilityManagerUserTypeLoginTest.EnableOnLoginScreenAndLogin/1
 UserTypeInstantiation/AccessibilityManagerUserTypeLoginTest.EnableOnLoginScreenAndLogin/2

Update the filter to put the remaining failures in the right sections.

Bug:  628655 
Change-Id: Ifd7f9dab36b98c6c9f29beb511a8ddd3b33906af
Reviewed-on: https://chromium-review.googlesource.com/959610
Reviewed-by: David Tseng <dtseng@chromium.org>
Commit-Queue: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542921}
[modify] https://crrev.com/8c672d09d8137ecb2c340fb987d44e3ae55a8010/testing/buildbot/filters/mash.browser_tests.filter

Status: Fixed (was: Started)
Calling this done. We could do further work, like move ChromeVoxPanel into ash, when ash can directly embed webui into webviews.

Sign in to add a comment