New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 628650 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Oct 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug

Blocked on:
issue 628627



Sign in to add a comment

Create an instrumentation test to ensure WebView doesn't cause StrictMode violations on startup

Project Member Reported by gsennton@chromium.org, Jul 15 2016

Issue description

We are not catching strictmode violations on WebView startup and this causes us to regress, see for example  crbug.com/628627 .

Landing this test is blocked on fixing any strictmode issues for WebView startup (currently  crbug.com/628627 ), I'll upload a test before that bug is fixed so that we have something to test against.
 
Note to self: we probably want to add some strictmode tests to the webview shell so that any tests using the shell will fail if we regress.

We should still add instrumentation tests for strictmode to catch a large part of regressions on the CQ instead of on a waterfall bot.
Opened a separate bug for adding strictmode checks to the WebView shell:  crbug.com/655167 .


When you close a crbug after not having closed one for a long time


KIRBY DANCE TIME!!!!!

<(^.^)<      <(^.^)>        >(^.^)>
Status: Fixed (was: Assigned)
Project Member

Comment 5 by bugdroid1@chromium.org, Jun 18 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/19dcc411896aea71d39693997821612f85ec702e

commit 19dcc411896aea71d39693997821612f85ec702e
Author: Paul Miller <paulmiller@google.com>
Date: Mon Jun 18 22:35:28 2018

WebView instrumentation test shell: Use try with StrictMode

BUG= 628650 

Change-Id: Ia78bfe6ad2d12362cb85bcc4580d907fe1ed6b47
Reviewed-on: https://chromium-review.googlesource.com/1105181
Reviewed-by: Richard Coles <torne@chromium.org>
Commit-Queue: Paul Miller <paulmiller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568202}
[modify] https://crrev.com/19dcc411896aea71d39693997821612f85ec702e/android_webview/test/shell/src/org/chromium/android_webview/test/AwTestRunnerActivity.java

Sign in to add a comment