New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 628640 link

Starred by 2 users

Issue metadata

Status: WontFix
Owner:
Last visit > 30 days ago
Closed: Aug 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

2.6% regression in system_health.memory_mobile at 405530:405568

Project Member Reported by petrcermak@chromium.org, Jul 15 2016

Issue description

See the link to graphs below.
 
All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=628640

Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?keys=agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICgypL3pgkM


Bot(s) for this bug's original alert(s):

android-nexus5
Trying another bisect.
Project Member

Comment 5 by 42576172...@developer.gserviceaccount.com, Jul 30 2016

Cc: shek...@gmail.com
Owner: shek...@gmail.com

=== Auto-CCing suspected CL author shekyan@gmail.com ===

Hi shekyan@gmail.com, the bisect results pointed to your CL below as possibly
causing a regression. Please have a look at this info and see whether
your CL be related.


===== BISECT JOB RESULTS =====
Status: completed


===== SUSPECTED CL(s) =====
Subject : Implement the `require-sri-for` CSP directive
Author  : shekyan
Commit description:
  
As defined in [1], this CSP directive allows developers to block resource
requests that do not contain integrity metadata. This includes contexts
like external scripts, workers, shared workers, service workers, external
stylesheets, preload requests, and requests originated by CSS @import.

[1]: https://w3c.github.io/webappsec-subresource-integrity/#opt-in-require-sri-for

Intent to implement: https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/jyCdW1dHyYA/YefRSKs1AQAJ

BUG=618924
R=mkwst@chromium.org

Review-Url: https://codereview.chromium.org/2056183002
Cr-Commit-Position: refs/heads/master@{#405530}
Commit  : 615df311feca979548acd4f73ce3d7ac34449e3a
Date    : Thu Jul 14 19:12:36 2016


===== TESTED REVISIONS =====
Revision         Mean    Std Dev  N  Good?
chromium@405400  2876.0  0.0      5  good
chromium@405477  2876.0  0.0      5  good
chromium@405516  2876.0  0.0      5  good
chromium@405526  2876.0  0.0      5  good
chromium@405529  2876.0  0.0      5  good
chromium@405530  2892.0  0.0      5  bad    <--
chromium@405531  2892.0  0.0      5  bad
chromium@405535  2892.0  0.0      5  bad
chromium@405554  2892.0  0.0      5  bad

Bisect job ran on: android_nexus5X_perf_bisect
Bug ID: 628640

Test Command: src/tools/perf/run_benchmark -v --browser=android-chromium --output-format=chartjson --upload-results --also-run-disabled-tests system_health.memory_mobile
Test Metric: load_games-memory:chrome:all_processes:reported_by_chrome:web_cache:effective_size_avg/load_games_lazors
Relative Change: 0.56%
Score: 99.9

Buildbot stdio: http://build.chromium.org/p/tryserver.chromium.perf/builders/android_nexus5X_perf_bisect/builds/393
Job details: https://chromeperf.appspot.com/buildbucket_job_status/9005789133715977568


Not what you expected? We'll investigate and get back to you!
  https://chromeperf.appspot.com/bad_bisect?try_job_id=5795908457857024

| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Tests>AutoBisect.  Thank you!

Comment 6 by shek...@gmail.com, Jul 30 2016

I'd be happy to tackle this, but most of the links in the Chrome Performance Dashboard are not available to me. Any thoughts, jww@?
Cc: jww@chromium.org
I'm running another bisect on a value where the change was more than a few bytes.

===== BISECT JOB RESULTS =====
Status: completed


===== SUSPECTED CL(s) =====
Subject : Implement the `require-sri-for` CSP directive
Author  : shekyan
Commit description:
  
As defined in [1], this CSP directive allows developers to block resource
requests that do not contain integrity metadata. This includes contexts
like external scripts, workers, shared workers, service workers, external
stylesheets, preload requests, and requests originated by CSS @import.

[1]: https://w3c.github.io/webappsec-subresource-integrity/#opt-in-require-sri-for

Intent to implement: https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/jyCdW1dHyYA/YefRSKs1AQAJ

BUG=618924
R=mkwst@chromium.org

Review-Url: https://codereview.chromium.org/2056183002
Cr-Commit-Position: refs/heads/master@{#405530}
Commit  : 615df311feca979548acd4f73ce3d7ac34449e3a
Date    : Thu Jul 14 19:12:36 2016


===== TESTED REVISIONS =====
Revision         Mean    Std Dev  N  Good?
chromium@405525  2876.0  0.0      5  good
chromium@405529  2876.0  0.0      5  good
chromium@405530  2892.0  0.0      5  bad    <--
chromium@405531  2892.0  0.0      5  bad
chromium@405533  2892.0  0.0      5  bad
chromium@405540  2892.0  0.0      5  bad
chromium@405554  2892.0  0.0      5  bad

Bisect job ran on: android_nexus5X_perf_bisect
Bug ID: 628640

Test Command: src/tools/perf/run_benchmark -v --browser=android-chromium --output-format=chartjson --upload-results --also-run-disabled-tests system_health.memory_mobile
Test Metric: load_games-memory:chrome:all_processes:reported_by_chrome:web_cache:effective_size_avg/load_games_lazors
Relative Change: 0.56%
Score: 99.9

Buildbot stdio: http://build.chromium.org/p/tryserver.chromium.perf/builders/android_nexus5X_perf_bisect/builds/452
Job details: https://chromeperf.appspot.com/buildbucket_job_status/9005143083559304848


Not what you expected? We'll investigate and get back to you!
  https://chromeperf.appspot.com/bad_bisect?try_job_id=5271016377417728

| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Tests>AutoBisect.  Thank you!
sheykan: Another bisect confirmed that the regression was due to r405530. However, the regression is again only 16 bytes. Unless this is completely unexpected, please close this bug as WontFix.

Comment 12 by shek...@gmail.com, Aug 9 2016

Status: WontFix (was: Assigned)
Thanks! Closing as WontFix.
Labels: SystemHealth-Sheriff
Labels: -Performance-Sheriff

Sign in to add a comment