New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 628605 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jul 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression

Blocking:
issue 240576



Sign in to add a comment

Regression:Glimpse of vertical scroll bar is seen on toggling to full screen in "raymond.in"

Reported by adha...@etouch.net, Jul 15 2016

Issue description

Version: 54.0.2797.0 (Official Build) eb270c9af201e549f3e2e2b1016b6b99565f1706-refs/heads/master@{#405656} (32/64-bit) 
OS: Windows (7,8,10), Mac (10.10.5, 10.11.5), Linux (14.04 LTS)

Test url:http://www.raymond.in/index.asp

Steps:
(1)Launch chrome and navigate to the above url.
(2)Play the video,click on full screen icon.(Kindly refer the video)
(3)Observe.

Actual:Glimpse of vertical scroll bar is seen on toggling to full screen.

Expected:No such glimpse of vertical scroll bar should be seen on toggling to full screen.

This is a Regression issue broken in M-54.

Good build:54.0.2796.2
Bad build:54.0.2797.0

Change Log URL:(Providing Change log as unable to play the video in full screen  in Chromium build ):
https://chromium.googlesource.com/chromium/src/+log/54.0.2796.0..54.0.2797.0?pretty=fuller&n=10000

Suspecting:r405478?

Kindly help to re-assign if your change is not the cause for this issue.

 
Actual result.mp4
1.2 MB View Download
Expected result.mp4
1.1 MB View Download
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 22 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/87365b3f6c6293bac8a2513cef257d8e2cb0898a

commit 87365b3f6c6293bac8a2513cef257d8e2cb0898a
Author: foolip <foolip@chromium.org>
Date: Fri Jul 22 06:55:06 2016

Revert of Reland "Implement FullScreen using top layer." (patchset #13 id:260001 of https://codereview.chromium.org/2107233002/ )

Reason for revert:
Multiple regressions around the fullscreen transition becoming visibly
worse, as well as a suspected leak.

BUG= 628554 , 628605 , 628662 , 630191 

Original issue's description:
> Reland "Implement FullScreen using top layer."
>
> This reverts commit 2460a95281959d1b4dd941fed10998adf8dcb63c.
>
> Notable changes on top of previous attempt:
>
> full-screen-iframe-ua-style.html is changed to use overflow property
> instead, as position is no longer changed on ancestors.
>
> :root:-webkit-full-screen-ancestor { overflow: hidden !important; } is
> retained, as the previous attempt regressed on Vimeo ( crbug.com/543946 )
> and it's not clear yet how to handle this in the spec:
> https://github.com/whatwg/fullscreen/issues/19
>
> Make ::backdrop work for replaced content (video, iframe, etc.) by
> changing StyleResolver::createPseudoElementIfNeeded to allow creating
> the ::backdrop pseudo-element even if the parent doesn't support
> children. With this change, full-screen-stacking-context.html was
> simplified and full-screen-video-has-backdrop.html was
> simplified+renamed.
>
> The will-change override is dropped, as full-screen-will-change.html
> passes without it.
>
> BUG= 240576 ,  543946 
>
> Committed: https://crrev.com/d666f503ae854fac360cc70da1f5971a6724546a
> Cr-Commit-Position: refs/heads/master@{#405478}

TBR=dsinclair@chromium.org,esprehn@chromium.org,eae@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG= 240576 ,  543946 

Review-Url: https://codereview.chromium.org/2168373002
Cr-Commit-Position: refs/heads/master@{#407089}

[modify] https://crrev.com/87365b3f6c6293bac8a2513cef257d8e2cb0898a/third_party/WebKit/LayoutTests/fast/css/invalidation/fullscreen-expected.txt
[modify] https://crrev.com/87365b3f6c6293bac8a2513cef257d8e2cb0898a/third_party/WebKit/LayoutTests/fast/css/invalidation/fullscreen.html
[modify] https://crrev.com/87365b3f6c6293bac8a2513cef257d8e2cb0898a/third_party/WebKit/LayoutTests/fullscreen/enter-exit-full-screen-hover.html
[modify] https://crrev.com/87365b3f6c6293bac8a2513cef257d8e2cb0898a/third_party/WebKit/LayoutTests/fullscreen/full-screen-iframe-ua-style-expected.txt
[modify] https://crrev.com/87365b3f6c6293bac8a2513cef257d8e2cb0898a/third_party/WebKit/LayoutTests/fullscreen/full-screen-iframe-ua-style.html
[modify] https://crrev.com/87365b3f6c6293bac8a2513cef257d8e2cb0898a/third_party/WebKit/LayoutTests/fullscreen/full-screen-iframe-zIndex.html
[delete] https://crrev.com/6c23d97a65d8568329a386bd1da1df27d8d0a893/third_party/WebKit/LayoutTests/fullscreen/full-screen-is-in-top-layer-expected.html
[delete] https://crrev.com/6c23d97a65d8568329a386bd1da1df27d8d0a893/third_party/WebKit/LayoutTests/fullscreen/full-screen-is-in-top-layer.html
[modify] https://crrev.com/87365b3f6c6293bac8a2513cef257d8e2cb0898a/third_party/WebKit/LayoutTests/fullscreen/full-screen-render-inline-expected.html
[modify] https://crrev.com/87365b3f6c6293bac8a2513cef257d8e2cb0898a/third_party/WebKit/LayoutTests/fullscreen/full-screen-stacking-context-expected.html
[modify] https://crrev.com/87365b3f6c6293bac8a2513cef257d8e2cb0898a/third_party/WebKit/LayoutTests/fullscreen/full-screen-stacking-context.html
[modify] https://crrev.com/87365b3f6c6293bac8a2513cef257d8e2cb0898a/third_party/WebKit/LayoutTests/fullscreen/full-screen-zIndex-expected.html
[modify] https://crrev.com/87365b3f6c6293bac8a2513cef257d8e2cb0898a/third_party/WebKit/LayoutTests/fullscreen/parent-flow-inline-with-block-child-expected.html
[delete] https://crrev.com/6c23d97a65d8568329a386bd1da1df27d8d0a893/third_party/WebKit/LayoutTests/fullscreen/rendering/backdrop-expected.html
[delete] https://crrev.com/6c23d97a65d8568329a386bd1da1df27d8d0a893/third_party/WebKit/LayoutTests/fullscreen/rendering/backdrop-iframe-expected.html
[delete] https://crrev.com/6c23d97a65d8568329a386bd1da1df27d8d0a893/third_party/WebKit/LayoutTests/fullscreen/rendering/backdrop-iframe.html
[delete] https://crrev.com/6c23d97a65d8568329a386bd1da1df27d8d0a893/third_party/WebKit/LayoutTests/fullscreen/rendering/backdrop-object-expected.html
[delete] https://crrev.com/6c23d97a65d8568329a386bd1da1df27d8d0a893/third_party/WebKit/LayoutTests/fullscreen/rendering/backdrop-object.html
[delete] https://crrev.com/6c23d97a65d8568329a386bd1da1df27d8d0a893/third_party/WebKit/LayoutTests/fullscreen/rendering/backdrop-video-expected.html
[delete] https://crrev.com/6c23d97a65d8568329a386bd1da1df27d8d0a893/third_party/WebKit/LayoutTests/fullscreen/rendering/backdrop-video.html
[delete] https://crrev.com/6c23d97a65d8568329a386bd1da1df27d8d0a893/third_party/WebKit/LayoutTests/fullscreen/rendering/backdrop.html
[delete] https://crrev.com/6c23d97a65d8568329a386bd1da1df27d8d0a893/third_party/WebKit/LayoutTests/fullscreen/rendering/overflow-root.html
[delete] https://crrev.com/6c23d97a65d8568329a386bd1da1df27d8d0a893/third_party/WebKit/LayoutTests/fullscreen/rendering/overflow.html
[modify] https://crrev.com/87365b3f6c6293bac8a2513cef257d8e2cb0898a/third_party/WebKit/LayoutTests/fullscreen/resources/empty.html
[modify] https://crrev.com/87365b3f6c6293bac8a2513cef257d8e2cb0898a/third_party/WebKit/LayoutTests/fullscreen/resources/green.html
[delete] https://crrev.com/6c23d97a65d8568329a386bd1da1df27d8d0a893/third_party/WebKit/LayoutTests/fullscreen/resources/white.html
[modify] https://crrev.com/87365b3f6c6293bac8a2513cef257d8e2cb0898a/third_party/WebKit/LayoutTests/fullscreen/video-webkit-transform-expected.html
[delete] https://crrev.com/6c23d97a65d8568329a386bd1da1df27d8d0a893/third_party/WebKit/LayoutTests/virtual/android/fullscreen/rendering/backdrop-video-expected.html
[modify] https://crrev.com/87365b3f6c6293bac8a2513cef257d8e2cb0898a/third_party/WebKit/Source/core/core.gypi
[modify] https://crrev.com/87365b3f6c6293bac8a2513cef257d8e2cb0898a/third_party/WebKit/Source/core/css/fullscreen.css
[modify] https://crrev.com/87365b3f6c6293bac8a2513cef257d8e2cb0898a/third_party/WebKit/Source/core/css/html.css
[modify] https://crrev.com/87365b3f6c6293bac8a2513cef257d8e2cb0898a/third_party/WebKit/Source/core/css/resolver/StyleAdjuster.cpp
[modify] https://crrev.com/87365b3f6c6293bac8a2513cef257d8e2cb0898a/third_party/WebKit/Source/core/css/resolver/StyleResolver.cpp
[modify] https://crrev.com/87365b3f6c6293bac8a2513cef257d8e2cb0898a/third_party/WebKit/Source/core/dom/Document.cpp
[modify] https://crrev.com/87365b3f6c6293bac8a2513cef257d8e2cb0898a/third_party/WebKit/Source/core/dom/Document.h
[modify] https://crrev.com/87365b3f6c6293bac8a2513cef257d8e2cb0898a/third_party/WebKit/Source/core/dom/Fullscreen.cpp
[modify] https://crrev.com/87365b3f6c6293bac8a2513cef257d8e2cb0898a/third_party/WebKit/Source/core/dom/Fullscreen.h
[modify] https://crrev.com/87365b3f6c6293bac8a2513cef257d8e2cb0898a/third_party/WebKit/Source/core/dom/LayoutTreeBuilder.cpp
[modify] https://crrev.com/87365b3f6c6293bac8a2513cef257d8e2cb0898a/third_party/WebKit/Source/core/dom/PseudoElement.cpp
[modify] https://crrev.com/87365b3f6c6293bac8a2513cef257d8e2cb0898a/third_party/WebKit/Source/core/frame/FrameView.cpp
[modify] https://crrev.com/87365b3f6c6293bac8a2513cef257d8e2cb0898a/third_party/WebKit/Source/core/layout/LayoutBlock.cpp
[modify] https://crrev.com/87365b3f6c6293bac8a2513cef257d8e2cb0898a/third_party/WebKit/Source/core/layout/LayoutBox.h
[add] https://crrev.com/87365b3f6c6293bac8a2513cef257d8e2cb0898a/third_party/WebKit/Source/core/layout/LayoutFullScreen.cpp
[add] https://crrev.com/87365b3f6c6293bac8a2513cef257d8e2cb0898a/third_party/WebKit/Source/core/layout/LayoutFullScreen.h
[modify] https://crrev.com/87365b3f6c6293bac8a2513cef257d8e2cb0898a/third_party/WebKit/Source/core/layout/LayoutInline.cpp
[modify] https://crrev.com/87365b3f6c6293bac8a2513cef257d8e2cb0898a/third_party/WebKit/Source/core/layout/LayoutMenuList.cpp
[modify] https://crrev.com/87365b3f6c6293bac8a2513cef257d8e2cb0898a/third_party/WebKit/Source/core/layout/LayoutObject.h
[modify] https://crrev.com/87365b3f6c6293bac8a2513cef257d8e2cb0898a/third_party/WebKit/Source/core/layout/LayoutVideo.cpp
[modify] https://crrev.com/87365b3f6c6293bac8a2513cef257d8e2cb0898a/third_party/WebKit/Source/core/layout/LayoutVideo.h
[add] https://crrev.com/87365b3f6c6293bac8a2513cef257d8e2cb0898a/third_party/WebKit/Source/core/layout/api/LayoutFullScreenItem.h
[modify] https://crrev.com/87365b3f6c6293bac8a2513cef257d8e2cb0898a/third_party/WebKit/Source/core/layout/api/LayoutItem.h
[modify] https://crrev.com/87365b3f6c6293bac8a2513cef257d8e2cb0898a/third_party/WebKit/Source/web/FullscreenController.cpp
[modify] https://crrev.com/87365b3f6c6293bac8a2513cef257d8e2cb0898a/third_party/WebKit/Source/web/tests/WebFrameTest.cpp

Comment 2 by foolip@chromium.org, Jul 23 2016

Blocking: 240576

Comment 3 by foolip@chromium.org, Jul 23 2016

I have tried to reproduce this on Mac but couldn't see the scroll bar flash by in the transition. Going fullscreen also switches to another workspace on Mac, so I'm wondering if it might be obscured somehow. Do you have a recording of how this manifests on Mac?

Comment 4 by foolip@chromium.org, Jul 26 2016

I was able to reproduce this on Windows in a Virtual Machine, seeing lots of bad frames in the transition. As described in https://bugs.chromium.org/p/chromium/issues/detail?id=240576#c67 I think this is due to  issue 402421 , which is about the different timing of modifying the fullscreen element stack (the top element in which is document.fullscreenElement) and the separate internal pointer which affects document.webkitCurrentFullScreenElement and :-webkit-full-screen. Aligning the timing of those changes should mean that the transition is no worse than before.

Comment 5 by foolip@chromium.org, Jul 27 2016

I've done a screen recording on Mac trying to reproduce this issue, but there's a fade in/out animation when going fullscreen that takes a few frames to complete and seems to obscure the problem. adharap@, can you confirm that you did in fact see a glimpse of a scroll bar on Mac, and if so can you attach a recording? Thanks!

Comment 6 by foolip@chromium.org, Jul 27 2016

Hmm, it strikes me that on Mac it might also be because the scroll bars are only visible while scrolling.

Comment 7 by foolip@chromium.org, Jul 28 2016

This and  issue 628554  is caused by adding the fullscreen element to the top layer before entering fullscreen, and then causing the :-webkit-full-screen selector to match only after entering fullscreen. Both should be fixed by  issue 402421  and the relevant CL has already been reverted, so closing this.

Comment 8 by foolip@chromium.org, Jul 28 2016

Status: Fixed (was: Assigned)

Sign in to add a comment