Issue metadata
Sign in to add a comment
|
Regression: Favicon of chrome://apps is not seen properly after applying theme.
Reported by
rk...@etouch.net,
Jul 15 2016
|
||||||||||||||||||||||
Issue descriptionChrome Version: 54.0.2797.0 Revision eb270c9af201e549f3e2e2b1016b6b99565f1706-refs/heads/master@{#405656}(32/64 bit) OS: Windows(7,8,10), Linux (Ubuntu 14.04 LTS) URL: https://chrome.google.com/webstore/detail/mount-everest-1440%2B-x-900/bnlehkcgeooloejojajmeolmhiaeoiej?hl=en What steps will reproduce the problem? (1) Launch chrome, navigate to above url and click on 'ADD TO CHROME' (2) Navigate to chrome://apps and observe the favicon in tabstrip. Favicon of chrome://apps is not seen properly in tabstrip. Favicon of chrome://apps should seen properly in tabstrip. This is Regression issue broken in M-54,below is the Narrow bisect info: Good build: 53.0.2785.0 Bad build: 54.0.2787.0 Narrow Bisect: https://chromium.googlesource.com/chromium/src/+log/d7aeee6ee5d9274b6a1dbbe5bb3f67a77631248a..3b2a4a9355172fda4d5e2564b9d4f70b7fed8b95?pretty=fuller&n=100 Suspecting: r403581 Note: Issue is not seen on Mac OS.
,
Jul 15 2016
the change was merged to m53 so the fix should be as well.
,
Jul 15 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9130993eeff4cc3b23cff8962c78833e8c81456e commit 9130993eeff4cc3b23cff8962c78833e8c81456e Author: estade <estade@chromium.org> Date: Fri Jul 15 19:45:00 2016 Fix apps page icon in tabstrip. Note that the apps button on the bookmark bar works correctly, but if you also bookmark the apps page, the bookmark will be theme-colorized although it probably shouldn't. However, I consider this much more of a corner case than the described bug (which occurs any time you're using the app launcher with a themed browser). So for now, just fix the tabstrip problem. BUG= 628599 Review-Url: https://codereview.chromium.org/2150423002 Cr-Commit-Position: refs/heads/master@{#405827} [modify] https://crrev.com/9130993eeff4cc3b23cff8962c78833e8c81456e/chrome/browser/ui/views/tabs/tab.cc
,
Jul 18 2016
Unable to repro this issue on Windows 7 & Ubuntu Trusty (14.04) for Google Chrome Canary Version - 54.0.2799.0 @rkote: Could you please update your Google Chrome Canary to Latest Version - 54.0.2799.0 and let us know your observations. Thank you.
,
Jul 18 2016
,
Jul 18 2016
Your change meets the bar and is auto-approved for M53 (branch: 2785)
,
Jul 18 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8efc7a6a5cbca3cdabb1fd374d708b7c60e86ed7 commit 8efc7a6a5cbca3cdabb1fd374d708b7c60e86ed7 Author: Evan Stade <estade@chromium.org> Date: Mon Jul 18 18:16:07 2016 Fix apps page icon in tabstrip. Note that the apps button on the bookmark bar works correctly, but if you also bookmark the apps page, the bookmark will be theme-colorized although it probably shouldn't. However, I consider this much more of a corner case than the described bug (which occurs any time you're using the app launcher with a themed browser). So for now, just fix the tabstrip problem. BUG= 628599 Review-Url: https://codereview.chromium.org/2150423002 Cr-Commit-Position: refs/heads/master@{#405827} (cherry picked from commit 9130993eeff4cc3b23cff8962c78833e8c81456e) Review URL: https://codereview.chromium.org/2159913002 . Cr-Commit-Position: refs/branch-heads/2785@{#187} Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382} [modify] https://crrev.com/8efc7a6a5cbca3cdabb1fd374d708b7c60e86ed7/chrome/browser/ui/views/tabs/tab.cc
,
Jul 19 2016
,
Jul 19 2016
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by msrchandra@chromium.org
, Jul 15 2016