New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 628590 link

Starred by 2 users
Status: Fixed
Owner:
dpa...@chromium.org
Closed: Oct 2016
Cc:
tommycli@chromium.org
nyerramilli@chromium.org
█ msrchandra@chromium.org
michae...@chromium.org
steve...@chromium.org
dpa...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , All
Pri: 2
Type: Bug



Sign in to add a comment

Drop down list remains open even after back/forward navigation.

Reported by vku...@etouch.net, Jul 15 2016 
Chrome Version:54.0.2797.0 (Official Build) eb270c9af201e549f3e2e2b1016b6b99565f1706-refs/heads/master@{#405656} (32/64-bit)  
OS:Windows (7,8,10), Mac (10.10.5, 10.11.5), Linux (14.04 LTS)

What steps will reproduce the problem?
(1)Launch chrome and navigate to chrome://md-settings
(2)Click on 'customize fonts' click on 'standard font' drop down button.
(3)Now click on back navigation button and again click on forward navigation,observe the list.

Actual:Drop down list remains open even after back/forward navigation.

Expected:Drop down list should close after back/forward navigation.

This is a regression issue broken in 'M51' and will soon update other info.

Comment 1 by vku...@etouch.net, Jul 15 2016

Labels: hasbisect
Owner: dschuyler@chromium.org
Status: Assigned (was: Unconfirmed)
Manual regression range:
Good Build:  51.0.2695.0 
Bad Build:   51.0.2696.0 

Narrow bisect
https://chromium.googlesource.com/chromium/src/+log/0004417d4afcda9eb26321b778009357ba5ca2b5..4794e48d39b9d037ed247c73135631100189d541?pretty=fuller&n=10

Suspecting: r384424 ?
Actual_Fonts.mov
1.6 MB Download

Comment 2 by dschuyler@chromium.org, Jul 21 2016

Owner: steve...@chromium.org
Hi Steven, is this something you'd like to look into?

Comment 3 by steve...@chromium.org, Aug 29 2016

Labels: -Type-Bug-Regression Type-Bug
Marking MD-Settings bugs non-regressions since this is still in active development.

Comment 4 by steve...@chromium.org, Aug 29 2016

Summary: Drop down list remains open even after back/forward navigation. (was: Regression:Drop down list remains open even after back/forward navigation.)
Marking MD-Settings bugs non-regressions since this is still in active development.

Comment 5 by steve...@chromium.org, Sep 15 2016

Labels: -M-54 M-55

Comment 6 by steve...@chromium.org, Sep 26 2016

Cc: tommycli@chromium.org steve...@chromium.org michae...@chromium.org
Labels: -OS-Windows -OS-Mac OS-All
Owner: dschuyler@chromium.org
That is strange. It seems like it might be related to how we do forward / backward navigation for settings? I'm not sure how concerned we are about this?

It seems to happen pretty much everywhere, so if we fix it it probably needs to be in the routing code.

Comment 7 by tommycli@chromium.org, Sep 26 2016 

Yes, since our navigations are popstates, (not Real Navigations with a Reload), we needed custom code in our dialogs to close them on popstates:

https://codereview.chromium.org/2249933002

Probably need something similar for the dropdown list... or just use <select>.

Comment 8 by dschuyler@chromium.org, Sep 29 2016

Owner: dpa...@chromium.org
Demetrios, does this fit into the popup menu work you're doing?

Comment 9 by dpa...@chromium.org, Sep 29 2016 

This will be addressed by the <select> migration ( crbug.com/651513 ), not by the popup menu work.

Specifically, the behavior of the <select> is that when it is open it acts as a modal overlay, which means that clicking on the "back" button in the browser, does not actually do anything except from closing the <select>. A 2nd click is required to actually click the "back" button.

Comment 10 by dpa...@chromium.org, Oct 5 2016

Labels: Proj-MaterialDesign-WebUI
Fixed by https://codereview.chromium.org/2374253012.

Comment 11 by dpa...@chromium.org, Oct 5 2016

Status: Fixed (was: Assigned)
►

Sign in to add a comment