New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 628554 link

Starred by 2 users
Status: Fixed
Owner:
foolip@chromium.org
Closed: Jul 2016
Cc:
nyerramilli@chromium.org
█ msrchandra@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows
Pri: 1
Type: Bug-Regression

Blocking:
issue 240576



Sign in to add a comment

Regression: Glimpse of video is seen while entering video into fullscreen mode.

Reported by rk...@etouch.net, Jul 15 2016 
Chrome Version: 54.0.2797.0 Revision eb270c9af201e549f3e2e2b1016b6b99565f1706-refs/heads/master@{#405656}(32/64 bit)
OS: Windows(7,8,10), Linux (Ubuntu 14.04 LTS)

What steps will reproduce the problem?
(1) Launch chrome, navigate to https://play.google.com/store/movies?hl=en
(2) Click on Fullscreen icon of video and observe while entering into fullscreen mode

Glimpses of video(Left bottom side of page) is seen while entering video into fullscreen mode.

Glimpses of video should not seen while entering video into fullscreen mode.

This is Regression issue broken in M-54,below is the Narrow bisect info:

Good build: 54.0.2796.0
Bad build: 54.0.2797.0

Narrow Bisect:
https://chromium.googlesource.com/chromium/src/+log/b321c36b95fa43f0378ce82a222b89224d030a6a..bca843ba1471a6ca4eaf9f6869153389de683d6e?pretty=fuller&n=100

Suspecting: r405478

Note: Issue is not seen on Mac OS.
Actual_Fullscreen.mp4
692 KB View Download

Comment 1 by rk...@etouch.net, Jul 15 2016

Summary: Regression: Glimpse of video is seen while entering video into fullscreen mode. (was: Regression: Glimpses of video is seen while entering video into fullscreen mode on 'play.google.com')
Correction in steps:

1. Launch chrome, navigate to https://www.google.com/intl/en/chrome/browser/welcome.html
2. Play video,then Click on fullscreen icon of video and observe while entering into fullscreen mode

Comment 2 by msrchandra@chromium.org, Jul 15 2016

Labels: ReleaseBlock-Stable
Adding RB Label as this is a recent Regression. Please remove if not required.
Thank You.

Comment 3 by ajha@chromium.org, Jul 18 2016 

foolip@: Could you please take a look at this blocker issue.

Comment 4 by ajha@chromium.org, Jul 21 2016

Labels: -ReleaseBlock-Stable
I am not seeing any video on navigating to the URL from C#1.

rkote@: Do you have any alternate URL where this issue is reproduced.

Removing the blocker label for now. Feel free to add it back if there is any other URL where this repros.

Comment 5 by rk...@etouch.net, Jul 21 2016 

With respect to comment 4:

Issue is seen also for video https://play.google.com/store/movies?hl=en which mentioned in steps.
Project Member

Comment 6 by bugdroid1@chromium.org, Jul 22 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/87365b3f6c6293bac8a2513cef257d8e2cb0898a

commit 87365b3f6c6293bac8a2513cef257d8e2cb0898a
Author: foolip <foolip@chromium.org>
Date: Fri Jul 22 06:55:06 2016

Revert of Reland "Implement FullScreen using top layer." (patchset #13 id:260001 of https://codereview.chromium.org/2107233002/ )

Reason for revert:
Multiple regressions around the fullscreen transition becoming visibly
worse, as well as a suspected leak.

BUG= 628554 , 628605 , 628662 , 630191 

Original issue's description:
> Reland "Implement FullScreen using top layer."
>
> This reverts commit 2460a95281959d1b4dd941fed10998adf8dcb63c.
>
> Notable changes on top of previous attempt:
>
> full-screen-iframe-ua-style.html is changed to use overflow property
> instead, as position is no longer changed on ancestors.
>
> :root:-webkit-full-screen-ancestor { overflow: hidden !important; } is
> retained, as the previous attempt regressed on Vimeo ( crbug.com/543946 )
> and it's not clear yet how to handle this in the spec:
> https://github.com/whatwg/fullscreen/issues/19
>
> Make ::backdrop work for replaced content (video, iframe, etc.) by
> changing StyleResolver::createPseudoElementIfNeeded to allow creating
> the ::backdrop pseudo-element even if the parent doesn't support
> children. With this change, full-screen-stacking-context.html was
> simplified and full-screen-video-has-backdrop.html was
> simplified+renamed.
>
> The will-change override is dropped, as full-screen-will-change.html
> passes without it.
>
> BUG= 240576 ,  543946 
>
> Committed: https://crrev.com/d666f503ae854fac360cc70da1f5971a6724546a
> Cr-Commit-Position: refs/heads/master@{#405478}

TBR=dsinclair@chromium.org,esprehn@chromium.org,eae@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG= 240576 ,  543946 

Review-Url: https://codereview.chromium.org/2168373002
Cr-Commit-Position: refs/heads/master@{#407089}

[modify] https://crrev.com/87365b3f6c6293bac8a2513cef257d8e2cb0898a/third_party/WebKit/LayoutTests/fast/css/invalidation/fullscreen-expected.txt
[modify] https://crrev.com/87365b3f6c6293bac8a2513cef257d8e2cb0898a/third_party/WebKit/LayoutTests/fast/css/invalidation/fullscreen.html
[modify] https://crrev.com/87365b3f6c6293bac8a2513cef257d8e2cb0898a/third_party/WebKit/LayoutTests/fullscreen/enter-exit-full-screen-hover.html
[modify] https://crrev.com/87365b3f6c6293bac8a2513cef257d8e2cb0898a/third_party/WebKit/LayoutTests/fullscreen/full-screen-iframe-ua-style-expected.txt
[modify] https://crrev.com/87365b3f6c6293bac8a2513cef257d8e2cb0898a/third_party/WebKit/LayoutTests/fullscreen/full-screen-iframe-ua-style.html
[modify] https://crrev.com/87365b3f6c6293bac8a2513cef257d8e2cb0898a/third_party/WebKit/LayoutTests/fullscreen/full-screen-iframe-zIndex.html
[delete] https://crrev.com/6c23d97a65d8568329a386bd1da1df27d8d0a893/third_party/WebKit/LayoutTests/fullscreen/full-screen-is-in-top-layer-expected.html
[delete] https://crrev.com/6c23d97a65d8568329a386bd1da1df27d8d0a893/third_party/WebKit/LayoutTests/fullscreen/full-screen-is-in-top-layer.html
[modify] https://crrev.com/87365b3f6c6293bac8a2513cef257d8e2cb0898a/third_party/WebKit/LayoutTests/fullscreen/full-screen-render-inline-expected.html
[modify] https://crrev.com/87365b3f6c6293bac8a2513cef257d8e2cb0898a/third_party/WebKit/LayoutTests/fullscreen/full-screen-stacking-context-expected.html
[modify] https://crrev.com/87365b3f6c6293bac8a2513cef257d8e2cb0898a/third_party/WebKit/LayoutTests/fullscreen/full-screen-stacking-context.html
[modify] https://crrev.com/87365b3f6c6293bac8a2513cef257d8e2cb0898a/third_party/WebKit/LayoutTests/fullscreen/full-screen-zIndex-expected.html
[modify] https://crrev.com/87365b3f6c6293bac8a2513cef257d8e2cb0898a/third_party/WebKit/LayoutTests/fullscreen/parent-flow-inline-with-block-child-expected.html
[delete] https://crrev.com/6c23d97a65d8568329a386bd1da1df27d8d0a893/third_party/WebKit/LayoutTests/fullscreen/rendering/backdrop-expected.html
[delete] https://crrev.com/6c23d97a65d8568329a386bd1da1df27d8d0a893/third_party/WebKit/LayoutTests/fullscreen/rendering/backdrop-iframe-expected.html
[delete] https://crrev.com/6c23d97a65d8568329a386bd1da1df27d8d0a893/third_party/WebKit/LayoutTests/fullscreen/rendering/backdrop-iframe.html
[delete] https://crrev.com/6c23d97a65d8568329a386bd1da1df27d8d0a893/third_party/WebKit/LayoutTests/fullscreen/rendering/backdrop-object-expected.html
[delete] https://crrev.com/6c23d97a65d8568329a386bd1da1df27d8d0a893/third_party/WebKit/LayoutTests/fullscreen/rendering/backdrop-object.html
[delete] https://crrev.com/6c23d97a65d8568329a386bd1da1df27d8d0a893/third_party/WebKit/LayoutTests/fullscreen/rendering/backdrop-video-expected.html
[delete] https://crrev.com/6c23d97a65d8568329a386bd1da1df27d8d0a893/third_party/WebKit/LayoutTests/fullscreen/rendering/backdrop-video.html
[delete] https://crrev.com/6c23d97a65d8568329a386bd1da1df27d8d0a893/third_party/WebKit/LayoutTests/fullscreen/rendering/backdrop.html
[delete] https://crrev.com/6c23d97a65d8568329a386bd1da1df27d8d0a893/third_party/WebKit/LayoutTests/fullscreen/rendering/overflow-root.html
[delete] https://crrev.com/6c23d97a65d8568329a386bd1da1df27d8d0a893/third_party/WebKit/LayoutTests/fullscreen/rendering/overflow.html
[modify] https://crrev.com/87365b3f6c6293bac8a2513cef257d8e2cb0898a/third_party/WebKit/LayoutTests/fullscreen/resources/empty.html
[modify] https://crrev.com/87365b3f6c6293bac8a2513cef257d8e2cb0898a/third_party/WebKit/LayoutTests/fullscreen/resources/green.html
[delete] https://crrev.com/6c23d97a65d8568329a386bd1da1df27d8d0a893/third_party/WebKit/LayoutTests/fullscreen/resources/white.html
[modify] https://crrev.com/87365b3f6c6293bac8a2513cef257d8e2cb0898a/third_party/WebKit/LayoutTests/fullscreen/video-webkit-transform-expected.html
[delete] https://crrev.com/6c23d97a65d8568329a386bd1da1df27d8d0a893/third_party/WebKit/LayoutTests/virtual/android/fullscreen/rendering/backdrop-video-expected.html
[modify] https://crrev.com/87365b3f6c6293bac8a2513cef257d8e2cb0898a/third_party/WebKit/Source/core/core.gypi
[modify] https://crrev.com/87365b3f6c6293bac8a2513cef257d8e2cb0898a/third_party/WebKit/Source/core/css/fullscreen.css
[modify] https://crrev.com/87365b3f6c6293bac8a2513cef257d8e2cb0898a/third_party/WebKit/Source/core/css/html.css
[modify] https://crrev.com/87365b3f6c6293bac8a2513cef257d8e2cb0898a/third_party/WebKit/Source/core/css/resolver/StyleAdjuster.cpp
[modify] https://crrev.com/87365b3f6c6293bac8a2513cef257d8e2cb0898a/third_party/WebKit/Source/core/css/resolver/StyleResolver.cpp
[modify] https://crrev.com/87365b3f6c6293bac8a2513cef257d8e2cb0898a/third_party/WebKit/Source/core/dom/Document.cpp
[modify] https://crrev.com/87365b3f6c6293bac8a2513cef257d8e2cb0898a/third_party/WebKit/Source/core/dom/Document.h
[modify] https://crrev.com/87365b3f6c6293bac8a2513cef257d8e2cb0898a/third_party/WebKit/Source/core/dom/Fullscreen.cpp
[modify] https://crrev.com/87365b3f6c6293bac8a2513cef257d8e2cb0898a/third_party/WebKit/Source/core/dom/Fullscreen.h
[modify] https://crrev.com/87365b3f6c6293bac8a2513cef257d8e2cb0898a/third_party/WebKit/Source/core/dom/LayoutTreeBuilder.cpp
[modify] https://crrev.com/87365b3f6c6293bac8a2513cef257d8e2cb0898a/third_party/WebKit/Source/core/dom/PseudoElement.cpp
[modify] https://crrev.com/87365b3f6c6293bac8a2513cef257d8e2cb0898a/third_party/WebKit/Source/core/frame/FrameView.cpp
[modify] https://crrev.com/87365b3f6c6293bac8a2513cef257d8e2cb0898a/third_party/WebKit/Source/core/layout/LayoutBlock.cpp
[modify] https://crrev.com/87365b3f6c6293bac8a2513cef257d8e2cb0898a/third_party/WebKit/Source/core/layout/LayoutBox.h
[add] https://crrev.com/87365b3f6c6293bac8a2513cef257d8e2cb0898a/third_party/WebKit/Source/core/layout/LayoutFullScreen.cpp
[add] https://crrev.com/87365b3f6c6293bac8a2513cef257d8e2cb0898a/third_party/WebKit/Source/core/layout/LayoutFullScreen.h
[modify] https://crrev.com/87365b3f6c6293bac8a2513cef257d8e2cb0898a/third_party/WebKit/Source/core/layout/LayoutInline.cpp
[modify] https://crrev.com/87365b3f6c6293bac8a2513cef257d8e2cb0898a/third_party/WebKit/Source/core/layout/LayoutMenuList.cpp
[modify] https://crrev.com/87365b3f6c6293bac8a2513cef257d8e2cb0898a/third_party/WebKit/Source/core/layout/LayoutObject.h
[modify] https://crrev.com/87365b3f6c6293bac8a2513cef257d8e2cb0898a/third_party/WebKit/Source/core/layout/LayoutVideo.cpp
[modify] https://crrev.com/87365b3f6c6293bac8a2513cef257d8e2cb0898a/third_party/WebKit/Source/core/layout/LayoutVideo.h
[add] https://crrev.com/87365b3f6c6293bac8a2513cef257d8e2cb0898a/third_party/WebKit/Source/core/layout/api/LayoutFullScreenItem.h
[modify] https://crrev.com/87365b3f6c6293bac8a2513cef257d8e2cb0898a/third_party/WebKit/Source/core/layout/api/LayoutItem.h
[modify] https://crrev.com/87365b3f6c6293bac8a2513cef257d8e2cb0898a/third_party/WebKit/Source/web/FullscreenController.cpp
[modify] https://crrev.com/87365b3f6c6293bac8a2513cef257d8e2cb0898a/third_party/WebKit/Source/web/tests/WebFrameTest.cpp

Comment 7 by foolip@chromium.org, Jul 23 2016

Blocking: 240576

Comment 8 by foolip@chromium.org, Jul 28 2016 

This and  issue 628605  is caused by adding the fullscreen element to the top layer before entering fullscreen, and then causing the :-webkit-full-screen selector to match only after entering fullscreen. Both should be fixed by  issue 402421  and the relevant CL has already been reverted, so closing this.

Comment 9 by foolip@chromium.org, Jul 28 2016

Status: Fixed (was: Assigned)
►

Sign in to add a comment