FrameCaret should use a position in FrameSelection instead of holding a postiion itself |
||||||||
Issue descriptionDetailed report: https://cluster-fuzz.appspot.com/testcase?key=6138124816351232 Fuzzer: bj_broddelwerk Job Type: linux_debug_chrome Platform Id: linux Crash Type: CHECK failure Crash Address: Crash State: caretPositionIsValidForDocument(*m_frame->document()) in FrameCaret.cpp blink::FrameCaret::invalidateCaretRect blink::FrameSelection::invalidateCaretRect Regressed: https://cluster-fuzz.appspot.com/revisions?job=linux_debug_chrome&range=396634:396810 Minimized Testcase (1.65 Kb): https://cluster-fuzz.appspot.com/download/AMIfv96JamvPGPGp6bVLzqAJYCWqRby2HG44sDtYgR4k4JC35n9hKS8ADARsucFNGnAKANUPUfQCm18QX7vfMg7z3uyVr8Kl_V32Xlcdn1KxbJX1CA0LNow9nkJXSDaE7rPnFSAOl5mGij10rWuhQJrDACesh8AplA?testcase_id=6138124816351232 Filer: nyerramilli See https://dev.chromium.org/Home/chromium-security/bugs/reproducing-clusterfuzz-bugs for more information.
,
Jul 15 2016
,
Jul 19 2016
DOM tree at assertion: m_caretPosition.m_position.showTreeForThis() = HTML, 1 *HTML 00000493FBAA3090 STYLE 00000493FBAA3278 HEAD 00000493FBAA30F8 #text 00000493FBAA3228 "\n" FrameCaret::m_caretPosition can have different position at FrameSelection::updateIfNeeded()
,
Jul 19 2016
,
Jul 21 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ec7e0ef4bfdb8f0cd0c9a45ed9d45755d9a3c684 commit ec7e0ef4bfdb8f0cd0c9a45ed9d45755d9a3c684 Author: yosin <yosin@chromium.org> Date: Thu Jul 21 07:07:44 2016 Make FrameCaret to retrieve caret position from SelectionEditor This patch makes |FrameCaret| to use caret position from |SelectionEditor| instead of holding caret position in |FrameCaret| to get rid of code of maintaining caret position between |FrameCaret| and |SelectionEditor| synchronize for improving code health. The root cause of crbug.com/628520 is missing synchronization code in |FrameSelection::updateIfNeeded()|. This patch is simpler than adding synchronization code in |FrameSelection::updateIfNeeded()|. BUG= 628520 TEST=run_webkit_unit_tests --gtest_filter=FrameSelectionTest.updateIfNeededAndFrameCaret Review-Url: https://codereview.chromium.org/2161373002 Cr-Commit-Position: refs/heads/master@{#406792} [modify] https://crrev.com/ec7e0ef4bfdb8f0cd0c9a45ed9d45755d9a3c684/third_party/WebKit/Source/core/editing/FrameCaret.cpp [modify] https://crrev.com/ec7e0ef4bfdb8f0cd0c9a45ed9d45755d9a3c684/third_party/WebKit/Source/core/editing/FrameCaret.h [modify] https://crrev.com/ec7e0ef4bfdb8f0cd0c9a45ed9d45755d9a3c684/third_party/WebKit/Source/core/editing/FrameSelection.cpp [modify] https://crrev.com/ec7e0ef4bfdb8f0cd0c9a45ed9d45755d9a3c684/third_party/WebKit/Source/core/editing/FrameSelectionTest.cpp
,
Jul 22 2016
ClusterFuzz has detected this issue as fixed in range 406657:406809. Detailed report: https://cluster-fuzz.appspot.com/testcase?key=6138124816351232 Fuzzer: bj_broddelwerk Job Type: linux_debug_chrome Platform Id: linux Crash Type: CHECK failure Crash Address: Crash State: caretPositionIsValidForDocument(*m_frame->document()) in FrameCaret.cpp blink::FrameCaret::invalidateCaretRect blink::FrameSelection::invalidateCaretRect Regressed: https://cluster-fuzz.appspot.com/revisions?job=linux_debug_chrome&range=396634:396810 Fixed: https://cluster-fuzz.appspot.com/revisions?job=linux_debug_chrome&range=406657:406809 Minimized Testcase (1.65 Kb): https://cluster-fuzz.appspot.com/download/AMIfv96JamvPGPGp6bVLzqAJYCWqRby2HG44sDtYgR4k4JC35n9hKS8ADARsucFNGnAKANUPUfQCm18QX7vfMg7z3uyVr8Kl_V32Xlcdn1KxbJX1CA0LNow9nkJXSDaE7rPnFSAOl5mGij10rWuhQJrDACesh8AplA?testcase_id=6138124816351232 See https://dev.chromium.org/Home/chromium-security/bugs/reproducing-clusterfuzz-bugs for more information. If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
,
Jul 22 2016
ClusterFuzz testcase is verified as fixed, closing issue. If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.
,
Oct 12 2016
,
Oct 18 2016
,
Nov 22 2016
Removing EditIssue view restrictions from ClusterFuzz filed bugs. If you believe that this issue should still be restricted, please reapply the label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot |
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by nyerramilli@chromium.org
, Jul 15 2016Components: Tools>Test>FindIt>NoResult
Labels: findit-wrong Te-Logged
Owner: bokan@chromium.org
Status: Assigned (was: Available)