Clicking DISMISS on toast in Chrome OS crashes Chrome |
||||||||
Issue descriptionClicking DISMISS on toast in Chrome OS crashes Chrome occasionally Repro step (1) Show toast (2) Hit DISMISS. See b/29503765 for detail.
,
Jul 15 2016
Moving this nonessential bug to the next milestone. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jul 19 2016
moving back to M-53 because this is a known crash. Please merge to 53 when submitted
,
Jul 20 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0444c447e813e8fb5931bb0cd141f8f2168ed392 commit 0444c447e813e8fb5931bb0cd141f8f2168ed392 Author: yoshiki <yoshiki@chromium.org> Date: Wed Jul 20 04:23:56 2016 Prevent hiding a toast during animation This patch should fix the crash (b/29503765). BUG= 628511 BUG=b:29503765 TEST=show a toast and click dismiss button 20 times, no crash observed R=oshima@chromium.org TBR=stevenjb@chromium.org Review-Url: https://codereview.chromium.org/2150603003 Cr-Commit-Position: refs/heads/master@{#406482} [modify] https://crrev.com/0444c447e813e8fb5931bb0cd141f8f2168ed392/ash/common/system/toast/toast_overlay.cc [modify] https://crrev.com/0444c447e813e8fb5931bb0cd141f8f2168ed392/ash/system/toast/toast_manager_unittest.cc
,
Jul 20 2016
I'll request a merge after checking the fix on the next canary.
,
Aug 1 2016
I confirmed the fix on 54.0.2800.2 canary. Could you approve the marge-request?
,
Aug 1 2016
Your change meets the bar and is auto-approved for M53 (branch: 2785)
,
Aug 3 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0559e3899c6fad4e8a5e3a4b004c3fd5d01efce9 commit 0559e3899c6fad4e8a5e3a4b004c3fd5d01efce9 Author: yoshiki iguchi <yoshiki@chromium.org> Date: Wed Aug 03 07:26:40 2016 Prevent hiding a toast during animation This patch should fix the crash (b/29503765). BUG= 628511 BUG=b:29503765 TEST=show a toast and click dismiss button 20 times, no crash observed R=oshima@chromium.org TBR=stevenjb@chromium.org Review-Url: https://codereview.chromium.org/2150603003 Cr-Commit-Position: refs/heads/master@{#406482} (cherry picked from commit 0444c447e813e8fb5931bb0cd141f8f2168ed392) Review URL: https://codereview.chromium.org/2204113002 . Cr-Commit-Position: refs/branch-heads/2785@{#479} Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382} [modify] https://crrev.com/0559e3899c6fad4e8a5e3a4b004c3fd5d01efce9/ash/system/toast/toast_manager_unittest.cc [modify] https://crrev.com/0559e3899c6fad4e8a5e3a4b004c3fd5d01efce9/ash/system/toast/toast_overlay.cc
,
Aug 3 2016
,
Aug 19 2016
Chrome OS version 5.0.2785.70/8530.62.0 cyan |
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by yoshiki@chromium.org
, Jul 15 2016