New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 628502 link

Starred by 3 users
Status: Verified
Owner:
tommycli@chromium.org
Closed: Aug 2016
Cc:
ajha@chromium.org
█ kavvaru@chromium.org
█ brajkumar@chromium.org
█ durga.behera@chromium.org
dpa...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 1
Type: Bug-Regression

Blocking:
issue 614588
issue 614589



Sign in to add a comment

Regression: Page doesn't navigate to Advanced section on directly entering chrome://md-settings/advanced url in omni box.

Project Member Reported by bj00129...@techmahindra.com, Jul 15 2016 
Version: 54.0.2797.0 Dev 
OS: Ubuntu 14.04,Windows

What steps will reproduce the problem?
(1)Launch chrome>>Enter chrome://md-settings/advanced url in omni box and observe

Expected:Advanced section should display when chrome://md-settings/advanced url is entered in omni box.
Actual:Instead page doesnot navigate to advanced section.

This is regression issue broken in M-53.
Good build:53.0.2762.0
Bad build:53.0.2763.0

CHANGELOG URL:  https://chromium.googlesource.com/chromium/src/+log/c98d04bc781d7b82808c927554a6e020b0a31573..49f91d87dfbb0c72efff8aa74a7f299980034344

Suspecting https://codereview.chromium.org/2008843003 from changelog.

@dschuyler:Please help in re-assigining if this is not related to your change.

Attaching screen cast for reference.
Actual_Advanced-2.ogv
1.4 MB View Download
Expected_Advanced.ogv
1.1 MB View Download

Comment 1 by kavvaru@chromium.org, Jul 15 2016

Labels: OS-Mac
Able to reproduce the issue on Mac 10.11.5 using chrome version 54.0.2797.0

Comment 2 by michae...@chromium.org, Jul 20 2016

Blocking: 614588
Labels: -M-54 Proj-MaterialDesign-WebU OS-Chrome

Comment 3 by michae...@chromium.org, Jul 21 2016

Blocking: 614589

Comment 4 by dschuyler@chromium.org, Jul 25 2016

Owner: tommycli@chromium.org
Tommy is planning to fix this (or wontFix it) by removing the /advance url path.
Project Member

Comment 5 by bugdroid1@chromium.org, Jul 30 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/aa9c34d72c27a54b09d1790fa425ea2f25cc9716

commit aa9c34d72c27a54b09d1790fa425ea2f25cc9716
Author: tommycli <tommycli@chromium.org>
Date: Sat Jul 30 00:11:23 2016

Settings Router Refactor: Remove route.page legacy property.

This property is not used that much, and can be removed.

BUG= 608115 ,  628502 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2184893002
Cr-Commit-Position: refs/heads/master@{#408815}

[modify] https://crrev.com/aa9c34d72c27a54b09d1790fa425ea2f25cc9716/chrome/browser/resources/settings/about_page/about_page.html
[modify] https://crrev.com/aa9c34d72c27a54b09d1790fa425ea2f25cc9716/chrome/browser/resources/settings/advanced_page/advanced_page.html
[modify] https://crrev.com/aa9c34d72c27a54b09d1790fa425ea2f25cc9716/chrome/browser/resources/settings/basic_page/basic_page.html
[modify] https://crrev.com/aa9c34d72c27a54b09d1790fa425ea2f25cc9716/chrome/browser/resources/settings/route.js
[modify] https://crrev.com/aa9c34d72c27a54b09d1790fa425ea2f25cc9716/chrome/browser/resources/settings/settings_main/settings_main.js
[modify] https://crrev.com/aa9c34d72c27a54b09d1790fa425ea2f25cc9716/chrome/browser/resources/settings/settings_menu/settings_menu.html
[modify] https://crrev.com/aa9c34d72c27a54b09d1790fa425ea2f25cc9716/chrome/browser/resources/settings/settings_menu/settings_menu.js
[modify] https://crrev.com/aa9c34d72c27a54b09d1790fa425ea2f25cc9716/chrome/browser/resources/settings/settings_page/main_page_behavior.js
[modify] https://crrev.com/aa9c34d72c27a54b09d1790fa425ea2f25cc9716/chrome/browser/resources/settings/settings_page/settings_router.js
[modify] https://crrev.com/aa9c34d72c27a54b09d1790fa425ea2f25cc9716/chrome/test/data/webui/settings/route_tests.js
[modify] https://crrev.com/aa9c34d72c27a54b09d1790fa425ea2f25cc9716/chrome/test/data/webui/settings/settings_menu_test.js
Project Member

Comment 6 by bugdroid1@chromium.org, Aug 18 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cd81492dada5b5ad4c2f6914323145cd8a541eb2

commit cd81492dada5b5ad4c2f6914323145cd8a541eb2
Author: tommycli <tommycli@chromium.org>
Date: Thu Aug 18 20:04:28 2016

Settings: Remove /advanced usage as URL.

After this CL, nothing ever explicitly navigates to the Advanced route.

Navigations by URL to /advanced redirect to BASIC.

BUG= 628502 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2255023002
Cr-Commit-Position: refs/heads/master@{#412919}

[modify] https://crrev.com/cd81492dada5b5ad4c2f6914323145cd8a541eb2/chrome/browser/resources/settings/route.js
[modify] https://crrev.com/cd81492dada5b5ad4c2f6914323145cd8a541eb2/chrome/browser/resources/settings/settings_main/settings_main.js
[modify] https://crrev.com/cd81492dada5b5ad4c2f6914323145cd8a541eb2/chrome/test/data/webui/settings/advanced_page_browsertest.js
[modify] https://crrev.com/cd81492dada5b5ad4c2f6914323145cd8a541eb2/chrome/test/data/webui/settings/bluetooth_page_browsertest_chromeos.js
[modify] https://crrev.com/cd81492dada5b5ad4c2f6914323145cd8a541eb2/chrome/test/data/webui/settings/languages_page_browsertest.js
[modify] https://crrev.com/cd81492dada5b5ad4c2f6914323145cd8a541eb2/chrome/test/data/webui/settings/settings_page_browsertest.js
[modify] https://crrev.com/cd81492dada5b5ad4c2f6914323145cd8a541eb2/chrome/test/data/webui/settings/settings_subpage_browsertest.js

Comment 7 by tommycli@chromium.org, Aug 18 2016

Status: Fixed (was: Assigned)

Comment 8 by sdantul...@chromium.org, Oct 20 2016

Status: Verified (was: Fixed)
Verified on ChromeOS 8872.18.0, 55.0.2883.20

The chrome://md-settings/advanced URL redirects to chrome://md-settings
►

Sign in to add a comment