Issue metadata
Sign in to add a comment
|
Regression : PDF page does not restore to its original position after clicking on 'Toggle device toolbar' button in devtools.
Reported by
mni...@etouch.net,
Jul 15 2016
|
||||||||||||||||||||||
Issue descriptionVersion: 54.0.2794.0 02e8e6a146a2a17dcd8950b783130d5937ce87dd-refs/heads/master@{#404734} (32/64-bit) OS: Windows (7,8,8.1,10) URL : http://www.orimi.com/pdf-test.pdf What steps will reproduce the problem? 1) Launch chrome,navigate to above url 2) Now press 'F12' to open devtools and click on 'Toggle device toolbar' button and observe the pdf page Actual : PDF page does not restore to its original position after clicking on 'Toggle device toolbar' button Expected : PDF page should get restore to its original position after clicking on 'Toggle device toolbar' button This is a regression issue broken in 'M-54' and below is the manual regression and Narrow bisect info: Good build : 54.0.2794.0 Bad build : 54.0.2795.0 Narrow bisect info: https://chromium.googlesource.com/chromium/src/+log/af2f49ba57ed217d06e69830f325c9ba7e7ce0bd..57b70dae30c2bc7d60e70efd8ebae83e01fe9119?pretty=fuller&n=100 Suspecting : r404875 from Narrow bisect @bsep : Could you please help to reassign if your change is not the cause for this change. Note : Issue is not seen on Mac and Linux OS.
,
Jul 15 2016
Adding RB Label as this is a recent Regression. Please remove if not required. Thank You.
,
Jul 19 2016
bsep@: Could you please take a look at this Blocker issue and update accordingly. Thank you!
,
Jul 19 2016
,
Jul 19 2016
I confirmed that this is caused by use-zoom-for-dsf and I will take a look when I have time.
,
Jul 22 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d89c7a1578f9f16f6e1fa4375aab232b67fe0f9f commit d89c7a1578f9f16f6e1fa4375aab232b67fe0f9f Author: bsep <bsep@chromium.org> Date: Fri Jul 22 23:17:35 2016 Fix the mobile emulator to use the correct device scale when disabled. The mobile emulator was triggering a layout before it had reapplied the original viewport parameters when it was being disabled, which with use-zoom-for-dsf enabled was causing the wrong viewport size to be given to various components, like plugins and scrollbars. BUG= 628501 , 628185 Review-Url: https://codereview.chromium.org/2168313002 Cr-Commit-Position: refs/heads/master@{#407294} [modify] https://crrev.com/d89c7a1578f9f16f6e1fa4375aab232b67fe0f9f/content/renderer/devtools/render_widget_screen_metrics_emulator.cc
,
Jul 22 2016
,
Jul 23 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0585519c495685502d0b0168808193bd094a0de8 commit 0585519c495685502d0b0168808193bd094a0de8 Author: mpearson <mpearson@chromium.org> Date: Sat Jul 23 00:21:40 2016 Revert of Fix the mobile emulator to use the correct device scale when disabled. (patchset #1 id:1 of https://codereview.chromium.org/2168313002/ ) Reason for revert: Likely cause of webkit_tests unexpected_failures inspector/screen-orientation-override.html https://storage.googleapis.com/chromium-layout-test-archives/WebKit_Linux/67873/layout-test-results/results.html Failure appeared on many bots: https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Linux/builds/67873 https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Linux%20Trusty/builds/15157 https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Mac10.10/builds/21002 https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Mac10.11/builds/7468 https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Win10/builds/12746 and it seems related (change to devtools, failure in "inspector") Original issue's description: > Fix the mobile emulator to use the correct device scale when disabled. > > The mobile emulator was triggering a layout before it had reapplied the > original viewport parameters when it was being disabled, which with > use-zoom-for-dsf enabled was causing the wrong viewport size to be given > to various components, like plugins and scrollbars. > > BUG= 628501 , 628185 > > Committed: https://crrev.com/d89c7a1578f9f16f6e1fa4375aab232b67fe0f9f > Cr-Commit-Position: refs/heads/master@{#407294} TBR=dgozman@chromium.org,alph@chromium.org,bsep@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= 628501 , 628185 Review-Url: https://codereview.chromium.org/2174493004 Cr-Commit-Position: refs/heads/master@{#407314} [modify] https://crrev.com/0585519c495685502d0b0168808193bd094a0de8/content/renderer/devtools/render_widget_screen_metrics_emulator.cc
,
Jul 23 2016
Your change meets the bar and is auto-approved for M53 (branch: 2785)
,
Jul 25 2016
bsep@, could you please merge this to M53 branch 2785 ASAP. Thank you.
,
Jul 25 2016
Please merge your change to M53 branch 2785 before 5:00 PM PDT today (Monday) so we can pick up for last M53 Dev release tomorrow. Thank you.
,
Jul 25 2016
I'm targeting doing the merge today. I need to re-land the patch after the reversion first.
,
Jul 26 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1c78b3850f956c1507e4cdf9429652ee0ef15cb0 commit 1c78b3850f956c1507e4cdf9429652ee0ef15cb0 Author: Bret Sepulveda <bsep@chromium.org> Date: Tue Jul 26 00:00:01 2016 Fix the mobile emulator to use the correct device scale when disabled. The mobile emulator was triggering a layout before it had reapplied the original viewport parameters when it was being disabled, which with use-zoom-for-dsf enabled was causing the wrong viewport size to be given to various components, like plugins and scrollbars. BUG= 628501 , 628185 R=dgozman@chromium.org Review URL: https://codereview.chromium.org/2168313002 . Committed: https://crrev.com/d89c7a1578f9f16f6e1fa4375aab232b67fe0f9f Cr-Original-Commit-Position: refs/heads/master@{#407294} Cr-Commit-Position: refs/heads/master@{#407639} [modify] https://crrev.com/1c78b3850f956c1507e4cdf9429652ee0ef15cb0/content/renderer/devtools/render_widget_screen_metrics_emulator.cc [modify] https://crrev.com/1c78b3850f956c1507e4cdf9429652ee0ef15cb0/third_party/WebKit/LayoutTests/inspector/screen-orientation-override-expected.txt
,
Jul 26 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c00cb1de97175f2f023bd18b6792c9057de70dc1 commit c00cb1de97175f2f023bd18b6792c9057de70dc1 Author: Bret Sepulveda <bsep@chromium.org> Date: Tue Jul 26 00:24:07 2016 Fix the mobile emulator to use the correct device scale when disabled. The mobile emulator was triggering a layout before it had reapplied the original viewport parameters when it was being disabled, which with use-zoom-for-dsf enabled was causing the wrong viewport size to be given to various components, like plugins and scrollbars. BUG= 628501 , 628185 R=dgozman@chromium.org Review URL: https://codereview.chromium.org/2168313002 . Committed: https://crrev.com/d89c7a1578f9f16f6e1fa4375aab232b67fe0f9f Cr-Original-Commit-Position: refs/heads/master@{#407294} Cr-Commit-Position: refs/heads/master@{#407639} (cherry picked from commit 1c78b3850f956c1507e4cdf9429652ee0ef15cb0) Review URL: https://codereview.chromium.org/2183533003 . Cr-Commit-Position: refs/branch-heads/2785@{#351} Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382} [modify] https://crrev.com/c00cb1de97175f2f023bd18b6792c9057de70dc1/content/renderer/devtools/render_widget_screen_metrics_emulator.cc [modify] https://crrev.com/c00cb1de97175f2f023bd18b6792c9057de70dc1/third_party/WebKit/LayoutTests/inspector/screen-orientation-override-expected.txt
,
Jul 26 2016
,
Sep 1 2016
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by mni...@etouch.net
, Jul 15 2016