New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 628499 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jul 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 2
Type: Bug-Regression



Sign in to add a comment

Regression : Unnecessarily horizontal scrollbar is seen in 'Search Engine' drop down list on md-settings page.

Reported by yfulgaon...@etouch.net, Jul 15 2016

Issue description

Chrome version : 54.0.2797.0 eb270c9af201e549f3e2e2b1016b6b99565f1706-refs/heads/master@{#405656} 32/64 bit
OS : Windows (7,8,8.1,10), Linux(14.04 LTS) and Mac(10.10.5, 10.11.4)

What steps will reproduce the problem?
1) Launch chrome, open chrome://md-settings page and scroll down the page.
2) Open 'Search Engine' drop down list and observe.
 
Actual : Unnecessarily horizontal scrollbar is seen in 'Search Engine' drop down. (Even when the search engine name is easily visible to the user without using any scrollbar)

Expected : Horizontal scrollbar should not be seen when the search engine name is easily visible to the user without using any scrollbar.

This is a regression issue broken in 'M-54', below is the Manual regression and Narrow Bisect info:
Good Build : 54.0.2795.0
Bad Build : 54.0.2796.0

Narrow Bisect :
https://chromium.googlesource.com/chromium/src/+log/075682d2247db4715899446dfcebd22ba952882a..d4179235b928634aeadb0c3379d385caf0ad3a07?pretty=fuller&n=10000

Suspecting : r405232 from Narrow Bisect.
 
Act_Exp.png
60.3 KB View Download
Actual_res.mp4
886 KB View Download

Comment 1 by dpa...@chromium.org, Jul 15 2016

Bisection provided at comment#1 is not correct. After performing bisect_builds.py the range is https://chromium.googlesource.com/chromium/src/+log/84452f6f0c65b006ca8646553147f3386e8b57ca..625f7915702eac0c2aa90a7445100be2f67deffc, and the revision causing this is r405374. Investigating...

Comment 2 by dpa...@chromium.org, Jul 15 2016

Labels: Proj-MaterialDesign-WebUI
Status: Started (was: Assigned)
Project Member

Comment 3 by bugdroid1@chromium.org, Jul 15 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ada53fa9511af7324edad932dacd5157a70891b9

commit ada53fa9511af7324edad932dacd5157a70891b9
Author: dpapad <dpapad@chromium.org>
Date: Fri Jul 15 18:01:02 2016

MD Settings: Fix search engines drop-down menu.

The same change fixes two issues.
1) No more showing of unnecessary horizontal scrollbar.
2) Allow using "Enter" key to change dropdown selection.

BUG= 628499 , 626989 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2148793007
Cr-Commit-Position: refs/heads/master@{#405789}

[modify] https://crrev.com/ada53fa9511af7324edad932dacd5157a70891b9/chrome/browser/resources/settings/search_page/search_page.html

Comment 4 by dpa...@chromium.org, Jul 15 2016

Status: Fixed (was: Started)

Sign in to add a comment