New issue
Advanced search Search tips

Issue 628495 link

Starred by 1 user

Issue metadata

Status: Duplicate
Merged: issue 504153
Owner:
Closed: Aug 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug



Sign in to add a comment

!node.needsStyleRecalc() in Document.cpp

Project Member Reported by ClusterFuzz, Jul 15 2016

Issue description

Detailed report: https://cluster-fuzz.appspot.com/testcase?key=4828264078245888

Fuzzer: bj_broddelwerk
Job Type: linux_debug_chrome
Platform Id: linux

Crash Type: CHECK failure
Crash Address: 
Crash State:
  !node.needsStyleRecalc() in Document.cpp
  blink::assertLayoutTreeUpdated
  blink::Document::updateStyleAndLayoutTree
  
Regressed: https://cluster-fuzz.appspot.com/revisions?job=linux_debug_chrome&range=335195:335234

Minimized Testcase (1.27 Kb): https://cluster-fuzz.appspot.com/download/AMIfv94nQ8nCSI4CG8rGT2cXfqgzFPsoJen49CXwKErbFZE49NIaVrSBcn4X4BNXjDYPKNnuZtCZQh9QpWM_YO5m8SnOaN2NgdJP2fiIfz6_dIkzFVM3i1sW-BR-DaM4OrnjFm-SBSH8WncHIl_yJL90BYhfoC96UA?testcase_id=4828264078245888

Filer: nyerramilli

See https://dev.chromium.org/Home/chromium-security/bugs/reproducing-clusterfuzz-bugs for more information.
 
Cc: nyerramilli@chromium.org
Components: Tools>Test>FindIt>NoResult
Labels: findit-wrong Te-Logged M-52
Owner: foolip@chromium.org
Status: Assigned (was: Available)
providing findit results for internal purpose:

Suspected CLs	Findit could not determine the memory tool from the stacktrace. Is it in a new format?

using code search, seeing some changes to 'Document.cpp' in https://chromium.googlesource.com/chromium/src/+/d666f503ae854fac360cc70da1f5971a6724546a

foolip@, Could you please check the above issue & help us in finding an owner it its not yours.

Comment 2 by foolip@chromium.org, Aug 11 2016

Labels: -ClusterFuzz Clusterfuzz
The assert can be reproduced on r402077 from June 25, 2016, so I'm not going to try bisecting this.

Comment 3 by foolip@chromium.org, Aug 11 2016

Cc: foolip@chromium.org
Components: -Tools>Test>FindIt>NoResult Blink>DOM
Owner: tkent@chromium.org
Turns out that mutation events are fun as usual. In the further minified fun-mutation-event.html, we end up with two children of the Document, which I suspect is violating assumptions somewhere that document.documentElement is the only child. It's certainly an invariant we try to uphold elsewhere and in spec land.

Both Gecko and Edge end up with just the <a> element as the document element, as they throw for the appendChild call inside the DOMSubtreeModified event handler. It looks like the state of the document is a bit different in the different engines in that event handler.

tkent@, can you take a look and assign to someone? To me, making sure that we only end up with one child of document seems like the most important, and if we can align with some other engine on the details of mutation events in the process that would be nice.
fun-mutation-event.html
270 bytes View Download

Comment 4 by tkent@chromium.org, Aug 12 2016

Mergedinto: 504153
Status: Duplicate (was: Assigned)
Project Member

Comment 5 by sheriffbot@chromium.org, Nov 22 2016

Labels: -Restrict-View-EditIssue
Removing EditIssue view restrictions from ClusterFuzz filed bugs. If you believe that this issue should still be restricted, please reapply the label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Sign in to add a comment