fast/events/popup-allowed-from-gesture-initiated-form-submit.html crashes flakily |
||
Issue descriptionhttps://storage.googleapis.com/chromium-layout-test-archives/mac_chromium_rel_ng/260599/layout-test-results/results.html https://storage.googleapis.com/chromium-layout-test-archives/mac_chromium_rel_ng/260599/layout-test-results/fast/events/popup-allowed-from-gesture-initiated-form-submit-stderr.txt [11625:1287:0714/201207:1872661282814:FATAL:navigation_controller_impl.cc(673)] Check failed: false. Http post load must use http(s) scheme. 0 Content Shell Framework 0x000000010b99c1a3 _ZN4base5debug10StackTraceC1Ev + 19 1 Content Shell Framework 0x000000010b9bc917 _ZN7logging10LogMessageD2Ev + 71 2 Content Shell Framework 0x000000010b2906f1 _ZN7content24NavigationControllerImpl17LoadURLWithParamsERKNS_20NavigationController13LoadURLParamsE + 417 3 Content Shell Framework 0x000000010b7898ba _ZN7content5Shell14OpenURLFromTabEPNS_11WebContentsERKNS_13OpenURLParamsE + 378 4 Content Shell Framework 0x000000010b5ade8c _ZN7content15WebContentsImpl14RequestOpenURLEPNS_19RenderFrameHostImplERKNS_13OpenURLParamsE + 76 5 Content Shell Framework 0x000000010b2a0fcf _ZN7content13NavigatorImpl14RequestOpenURLEPNS_19RenderFrameHostImplERK4GURLbRK13scoped_refptrINS_23ResourceRequestBodyImplEEPNS_12SiteInstanceERKNS_8ReferrerE21WindowOpenDispositionbb + 591 6 Content Shell Framework 0x000000010b2aefe8 _ZN7content19RenderFrameHostImpl7OpenURLERK27FrameHostMsg_OpenURL_ParamsPNS_12SiteInstanceE + 216 7 Content Shell Framework 0x000000010b2a831c _ZN7content19RenderFrameHostImpl9OnOpenURLERK27FrameHostMsg_OpenURL_Params + 156 8 Content Shell Framework 0x000000010b2a818e _ZN3IPC8MessageTI25FrameHostMsg_OpenURL_MetaNSt3__15tupleIJ27FrameHostMsg_OpenURL_ParamsEEEvE8DispatchIN7content19RenderFrameHostImplES9_vMS9_FvRKS4_EEEbPKNS_7MessageEPT_PT0_PT1_T2_ + 126 9 Content Shell Framework 0x000000010b2a5bf4 _ZN7content19RenderFrameHostImpl17OnMessageReceivedERKN3IPC7MessageE + 2564 10 Content Shell Framework 0x000000010b4777de _ZN7content21RenderProcessHostImpl17OnMessageReceivedERKN3IPC7MessageE + 526 11 Content Shell Framework 0x000000010ba81888 _ZN3IPC12ChannelProxy7Context17OnDispatchMessageERKNS_7MessageE + 40 12 Content Shell Framework 0x000000010b99c81b _ZN4base5debug13TaskAnnotator7RunTaskEPKcRKNS_11PendingTaskE + 187 13 Content Shell Framework 0x000000010b9cf95c _ZN4base11MessageLoop7RunTaskERKNS_11PendingTaskE + 572 14 Content Shell Framework 0x000000010b9cfc7c _ZN4base11MessageLoop21DeferOrRunPendingTaskENS_11PendingTaskE + 44 15 Content Shell Framework 0x000000010b9d0083 _ZN4base11MessageLoop6DoWorkEv + 371 16 Content Shell Framework 0x000000010b9d3797 _ZN4base24MessagePumpCFRunLoopBase7RunWorkEv + 55 17 Content Shell Framework 0x000000010b9bd90a _ZN4base3mac15CallWithEHFrameEU13block_pointerFvvE + 10 18 Content Shell Framework 0x000000010b9d30e4 _ZN4base24MessagePumpCFRunLoopBase13RunWorkSourceEPv + 68 19 CoreFoundation 0x00007fff8b32f5b1 __CFRUNLOOP_IS_CALLING_OUT_TO_A_SOURCE0_PERFORM_FUNCTION__ + 17 20 CoreFoundation 0x00007fff8b320c62 __CFRunLoopDoSources0 + 242 21 CoreFoundation 0x00007fff8b3203ef __CFRunLoopRun + 831 22 CoreFoundation 0x00007fff8b31fe75 CFRunLoopRunSpecific + 309 23 HIToolbox 0x00007fff90463a0d RunCurrentEventLoopInMode + 226 24 HIToolbox 0x00007fff904637b7 ReceiveNextEventCommon + 479 25 HIToolbox 0x00007fff904635bc _BlockUntilNextEventMatchingListInModeWithFilter + 65 26 AppKit 0x00007fff917d024e _DPSNextEvent + 1434 27 AppKit 0x00007fff917cf89b -[NSApplication nextEventMatchingMask:untilDate:inMode:dequeue:] + 122 28 AppKit 0x00007fff917c399c -[NSApplication run] + 553 29 Content Shell Framework 0x000000010b9d41d7 _ZN4base24MessagePumpNSApplication5DoRunEPNS_11MessagePump8DelegateE + 359 30 Content Shell Framework 0x000000010b9d356f _ZN4base24MessagePumpCFRunLoopBase3RunEPNS_11MessagePump8DelegateE + 127 31 Content Shell Framework 0x000000010b9cf4b7 _ZN4base11MessageLoop10RunHandlerEv + 215 32 Content Shell Framework 0x000000010b9faf53 _ZN4base7RunLoop3RunEv + 51 33 Content Shell Framework 0x000000010b1a32aa _ZN7content15BrowserMainLoop18MainMessageLoopRunEv + 250 34 Content Shell Framework 0x000000010b1a30a0 _ZN7content15BrowserMainLoop23RunMainMessageLoopPartsEv + 64 35 Content Shell Framework 0x000000010b1a5b9e _ZN7content21BrowserMainRunnerImpl3RunEv + 174 36 Content Shell Framework 0x000000010b77dfc4 _Z21LayoutTestBrowserMainRKN7content18MainFunctionParamsERKNSt3__110unique_ptrINS_17BrowserMainRunnerENS3_14default_deleteIS5_EEEE + 996 37 Content Shell Framework 0x000000010b758689 _ZN7content17ShellMainDelegate10RunProcessERKNSt3__112basic_stringIcNS1_11char_traitsIcEENS1_9allocatorIcEEEERKNS_18MainFunctionParamsE + 201 38 Content Shell Framework 0x000000010b0e3183 _ZN7content23RunNamedProcessTypeMainERKNSt3__112basic_stringIcNS0_11char_traitsIcEENS0_9allocatorIcEEEERKNS_18MainFunctionParamsEPNS_19ContentMainDelegateE + 595 39 Content Shell Framework 0x000000010b0e3d82 _ZN7content21ContentMainRunnerImpl3RunEv + 802 40 Content Shell Framework 0x000000010b0e2d66 _ZN7content11ContentMainERKNS_17ContentMainParamsE + 54 41 Content Shell Framework 0x0000000108b8ac7a ContentMain + 58 42 Content Shell 0x0000000108b83f24 start + 52
,
Jul 15 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/11f3ed430923329885682d50057217041ce661e1 commit 11f3ed430923329885682d50057217041ce661e1 Author: tkent <tkent@chromium.org> Date: Fri Jul 15 04:16:37 2016 Revert of Simplify RenderFrameImpl::decidePolicyForNavigation and avoid DCHECK (patchset #2 id:20001 of https://codereview.chromium.org/2153573002/ ) Reason for revert: Broke a layout test fast/events/popup-allowed-from-gesture-initiated-form-submit.html . http://test-results.appspot.com/dashboards/flakiness_dashboard.html#showExpectations=true&showLargeExpectations=true&tests=popup-allowed-from-gesture-initiated-form-submit.html Original issue's description: > Simplify RenderFrameImpl::decidePolicyForNavigation and avoid DCHECK. > > DCHECK can be tripped when there is a chain of openers or when the > opener has been cleared. The subsequent comparison against file: > fails, and we may make a browser navigation where one could have > been avoided, but it is still correct. > > Since it is still correct, we can simplify the check, perhaps > forking in more cases that we used to, but that doesn't matter. > > BUG= 622509 > R=creis@chromium.org > > Committed: https://crrev.com/6573f1eaf729320beeaf776674b124bfe5c330bb > Cr-Commit-Position: refs/heads/master@{#405609} TBR=creis@chromium.org,tsepez@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= 622509 , 628478 Review-Url: https://codereview.chromium.org/2150243002 Cr-Commit-Position: refs/heads/master@{#405694} [modify] https://crrev.com/11f3ed430923329885682d50057217041ce661e1/content/renderer/render_frame_impl.cc
,
Jul 15 2016
|
||
►
Sign in to add a comment |
||
Comment 1 by tkent@chromium.org
, Jul 15 2016Status: Started (was: Untriaged)