New issue
Advanced search Search tips

Issue 628475 link

Starred by 2 users
Status: WontFix
Owner:
fukino@chromium.org
Closed: Jun 2017
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 3
Type: Bug



Sign in to add a comment

SiteDataSizeCollectorTest.FetchFlashLSO fails on DrMemory

Project Member Reported by thestig@chromium.org, Jul 15 2016 
The test was added recently in r403236

https://build.chromium.org/p/chromium.memory.fyi/builders/Windows%20Unit%20%28DrMemory%20full%29%20%284%29/builds/10762


[----------] 2 tests from SiteDataSizeCollectorTest
[ RUN      ] SiteDataSizeCollectorTest.FetchIndexedDB
[       OK ] SiteDataSizeCollectorTest.FetchIndexedDB (156 ms)
[ RUN      ] SiteDataSizeCollectorTest.FetchFlashLSO
c:\b\build\slave\drm-cr\build\src\chrome\browser\browsing_data\site_data_size_collector_unittest.cc(298): error: Value of: fetched_size_
  Actual: -1
Expected: static_cast<int64_t>((sizeof(ArraySizeHelper(kFlashData0))) + (sizeof(ArraySizeHelper(kFlashData1))))
Which is: 31
[  FAILED  ] SiteDataSizeCollectorTest.FetchFlashLSO (188 ms)
[----------] 2 tests from SiteDataSizeCollectorTest (390 ms total)

Comment 1 by fukino@chromium.org, Jul 15 2016

Status: Assigned (was: Untriaged)
Project Member

Comment 2 by bugdroid1@chromium.org, Jul 15 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9a4dc47b2dac2f539dc0cd49bf3511145de7423a

commit 9a4dc47b2dac2f539dc0cd49bf3511145de7423a
Author: thestig <thestig@chromium.org>
Date: Fri Jul 15 04:36:23 2016

TSAN: Suppress a IPCSyncChannelTest race.

Also disable a failing SiteDataSizeCollectorTest for DrMemory.

BUG= 628475 , 628481 
TBR=glider@chromium.org

Review-Url: https://codereview.chromium.org/2149363002
Cr-Commit-Position: refs/heads/master@{#405700}

[modify] https://crrev.com/9a4dc47b2dac2f539dc0cd49bf3511145de7423a/build/sanitizers/tsan_suppressions.cc
[modify] https://crrev.com/9a4dc47b2dac2f539dc0cd49bf3511145de7423a/tools/valgrind/gtest_exclude/unit_tests.gtest-drmemory_win32.txt

Comment 3 by fukino@chromium.org, Jul 15 2016 

Thank you for disabling the test!
Will look into the cause...

Comment 4 by thestig@chromium.org, Jul 15 2016 

Please note DrMemory can trigger timing issues. DrMemory also runs tests serially with --test-launcher-bot-mode --single-process-tests. The order unit tests run in may also be different, and if one test fails do some clean up, that can affect the result of the following tests.

Comment 5 by thestig@chromium.org, Jun 8 2017

Status: WontFix (was: Assigned)
DrMemory retired.
►

Sign in to add a comment