Issue 628470 link

Starred by 1 user

Issue metadata

Status:	Verified
Owner:	d...@chromium.org
Closed:	Jul 2016
Cc:	akes...@chromium.org █ nxia@chromium.org no...@chromium.org
Components:	Infra>Client>ChromeOS Infra>Platform>Buildbucket
EstimatedDays:	----
NextAction:	----
OS:	Chrome
Pri:	1
Type:	Bug

BuildBucket "extra_args" property not being properly handled.

Project Member Reported by d...@chromium.org, Jul 15 2016

Issue description

The "extra_args" BuildBucket property is being passed to the recipe engine as "extra_args", not "cbb_extra_args", and it is being passed as a JSON list. Make it forward as a compressed JSON string.

Project Member

Comment 1 by bugdroid1@chromium.org, Jul 15 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build.git/+/21315d7a0edca8b26f53392264f4bb7f107c7011

commit 21315d7a0edca8b26f53392264f4bb7f107c7011
Author: dnj <dnj@chromium.org>
Date: Fri Jul 15 15:28:34 2016

Fix "extra_args" property forwarding.

BUG= chromium:628470 
TEST=None

Review-Url: https://codereview.chromium.org/2153033002

[modify] https://crrev.com/21315d7a0edca8b26f53392264f4bb7f107c7011/scripts/master/cros_try_job_git.py

Project Member

Comment 2 by bugdroid1@chromium.org, Jul 15 2016

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/infradata/master-manager.git/+/f8bac346907ff30f2777ee0d747e575e5fd606f3

commit f8bac346907ff30f2777ee0d747e575e5fd606f3
Author: dnj <dnj@google.com>
Date: Fri Jul 15 15:43:35 2016

Comment 3 by d...@chromium.org, Jul 15 2016

Status: Fixed (was: Started)

This should be fixed, now.

Comment 4 by d...@chromium.org, Jul 15 2016

Well, pending server restart, which will happen soon.

Comment 5 by nxia@chromium.org, Jul 15 2016

https://uberchromegw.corp.google.com/i/chromiumos.tryserver/builders/pre-cq/builds/37629

cbb_extra_args worked!

Comment 6 by d...@chromium.org, Jul 15 2016

Status: Verified (was: Fixed)

Great!

►

Issue 628470 link

Issue metadata

BuildBucket "extra_args" property not being properly handled.

Issue description

Comment 1 by bugdroid1@chromium.org, Jul 15 2016

Comment 1 Deleted

Comment 2 by bugdroid1@chromium.org, Jul 15 2016

Comment 2 Deleted

Comment 3 by d...@chromium.org, Jul 15 2016

Comment 3 Deleted

Comment 4 by d...@chromium.org, Jul 15 2016

Comment 4 Deleted

Comment 5 by nxia@chromium.org, Jul 15 2016

Comment 5 Deleted

Comment 6 by d...@chromium.org, Jul 15 2016

Comment 6 Deleted

Sign in to add a comment