New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 628462 link

Starred by 2 users

Issue metadata

Status: WontFix
Owner:
Last visit > 30 days ago
Closed: Apr 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 3
Type: Bug

Blocking:
issue 631771



Sign in to add a comment

BlacklistTest failing on DrMemory

Project Member Reported by thestig@chromium.org, Jul 15 2016

Issue description

Started at https://build.chromium.org/p/chromium.memory.fyi/builders/Windows%20Unit%20%28DrMemory%29/builds/5313 due to r405307

Probably some part of the test is not cleaning up correctly between test cases. Unlike other bots, DrMemory runs the tests serially:

[----------] 8 tests from BlacklistTest
[ RUN      ] BlacklistTest.Beacon
[       OK ] BlacklistTest.Beacon (141 ms)
[ RUN      ] BlacklistTest.AddAndRemoveModules
[       OK ] BlacklistTest.AddAndRemoveModules (0 ms)
[ RUN      ] BlacklistTest.SuccessfullyBlocked
[       OK ] BlacklistTest.SuccessfullyBlocked (0 ms)
[ RUN      ] BlacklistTest.LoadBlacklistedLibrary
c:\b\build\slave\drm-cr\build\src\chrome_elf\blacklist\test\blacklist_test.cc(301): error: Value of: TestDll_IsBlacklistInitialized()
  Actual: false
Expected: true
[  FAILED  ] BlacklistTest.LoadBlacklistedLibrary (47 ms)
[ RUN      ] BlacklistTest.AddDllsFromRegistryToBlacklist
c:\b\build\slave\drm-cr\build\src\chrome_elf\blacklist\test\blacklist_test.cc(321): error: Value of: TestDll_IsBlacklistInitialized()
  Actual: false
Expected: true
[  FAILED  ] BlacklistTest.AddDllsFromRegistryToBlacklist (0 ms)
[ RUN      ] BlacklistTest.ResetBeacon
[       OK ] BlacklistTest.ResetBeacon (16 ms)
[ RUN      ] BlacklistTest.SetupFailed
[       OK ] BlacklistTest.SetupFailed (0 ms)
[ RUN      ] BlacklistTest.SetupSucceeded
[       OK ] BlacklistTest.SetupSucceeded (0 ms)
[----------] 8 tests from BlacklistTest (219 ms total)

vs https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%281%29/builds/54906/ :

Using 8 parallel jobs.
[1/50] ChromeElfUtilTest.BrowserProcessTest (0 ms)
[2/50] ChromeElfUtilTest.NTRegistry (0 ms)
...
[41/50] BlacklistTest.Beacon (47 ms)
[42/50] BlacklistTest.AddAndRemoveModules (0 ms)
[43/50] BlacklistTest.SuccessfullyBlocked (0 ms)
[44/50] BlacklistTest.LoadBlacklistedLibrary (63 ms)
[45/50] BlacklistTest.AddDllsFromRegistryToBlacklist (0 ms)
[46/50] BlacklistTest.ResetBeacon (0 ms)
[47/50] BlacklistTest.SetupFailed (0 ms)
[48/50] BlacklistTest.SetupSucceeded (0 ms)
[49/50] ChromeElfUtilTest.CanaryTest (0 ms)
[50/50] ChromeElfUtilTest.SystemInstallTest (0 ms)
SUCCESS: all tests passed.

 
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 15 2016

Blocking: 631771
Status: Fixed (was: Assigned)
Closing down this ticket for now.  Most of the blacklist tests are gone now.  I've landed a CL to remove the drmemory blacklist: https://codereview.chromium.org/2355933002/

Lei, feel free to re-open if we see failures again on this bot.
Status: Assigned (was: Fixed)
Failing again: https://build.chromium.org/p/chromium.memory.full/builders/Windows%20Unit%20%28DrMemory%20full%29%20%285%29/builds/249

BlacklistTest.LoadBlacklistedLibrary:
c:\b\build\slave\drm-cr\build\src\chrome_elf\blacklist\test\blacklist_test.cc(294): error: Value of: TestDll_IsBlacklistInitialized()
Actual: false
Expected: true
Project Member

Comment 5 by bugdroid1@chromium.org, Sep 28 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3bf8b593996e1d96824465ee110365fc24278e16

commit 3bf8b593996e1d96824465ee110365fc24278e16
Author: thestig <thestig@chromium.org>
Date: Wed Sep 28 18:29:27 2016

DrMemory: Disable BlacklistTest.LoadBlacklistedLibrary again.

BUG= 628462 
TBR=pennymac@chromium.org
NOTRY=true

Review-Url: https://codereview.chromium.org/2382483002
Cr-Commit-Position: refs/heads/master@{#421582}

[add] https://crrev.com/3bf8b593996e1d96824465ee110365fc24278e16/tools/valgrind/gtest_exclude/chrome_elf_unittests.gtest-drmemory_win32.txt

Status: WontFix (was: Assigned)
Well, we stopped using DrMemory, so I guess this is obsolete.
Components: Internals>EarlyLoadingFramework

Sign in to add a comment