New issue
Advanced search Search tips

Issue 628460 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jul 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Feature

Blocked on:
issue 627705

Blocking:
issue 628685



Sign in to add a comment

Throw NotSupportedError when merchant requests only unknown payment methods

Project Member Reported by rouslan@chromium.org, Jul 15 2016

Issue description

^^^
 
Blocking: 628685
Project Member

Comment 3 by bugdroid1@chromium.org, Jul 20 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3748272dc88b06912bf432655587dc7dd4a4a561

commit 3748272dc88b06912bf432655587dc7dd4a4a561
Author: rouslan <rouslan@chromium.org>
Date: Wed Jul 20 02:10:01 2016

Error out when merchant requests only unknown payment methods.

If the merchant requests only payment methods that Chrome does not
support, then reject the show() promise with NotSupportedError.

BUG= 628460 

Review-Url: https://codereview.chromium.org/2149023005
Cr-Commit-Position: refs/heads/master@{#406460}

[modify] https://crrev.com/3748272dc88b06912bf432655587dc7dd4a4a561/chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentAppFactory.java
[modify] https://crrev.com/3748272dc88b06912bf432655587dc7dd4a4a561/chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java
[modify] https://crrev.com/3748272dc88b06912bf432655587dc7dd4a4a561/chrome/android/java_sources.gni
[add] https://crrev.com/3748272dc88b06912bf432655587dc7dd4a4a561/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestPaymentAppTest.java
[modify] https://crrev.com/3748272dc88b06912bf432655587dc7dd4a4a561/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestTestBase.java
[add] https://crrev.com/3748272dc88b06912bf432655587dc7dd4a4a561/chrome/test/data/android/payments/bobpay.js
[add] https://crrev.com/3748272dc88b06912bf432655587dc7dd4a4a561/chrome/test/data/android/payments/payment_request_bobpay_test.html

Labels: Merge-Request-53 M-53
Would like to merge 3748272dc88b06912bf432655587dc7dd4a4a561 into M-53.

Comment 5 by dimu@google.com, Jul 21 2016

Labels: -Merge-Request-53 Merge-Approved-53 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M53 (branch: 2785)
Status: Fixed (was: Started)
Project Member

Comment 7 by bugdroid1@chromium.org, Jul 21 2016

Labels: -merge-approved-53 merge-merged-2785
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/500a18cd9552ec468efb13d706a8350ba6ad5e29

commit 500a18cd9552ec468efb13d706a8350ba6ad5e29
Author: Rouslan Solomakhin <rouslan@chromium.org>
Date: Thu Jul 21 17:52:45 2016

[Merge M-53] Error out when merchant requests only unknown payment methods.

If the merchant requests only payment methods that Chrome does not
support, then reject the show() promise with NotSupportedError.

BUG= 628460 

Review-Url: https://codereview.chromium.org/2149023005
Cr-Commit-Position: refs/heads/master@{#406460}
(cherry picked from commit 3748272dc88b06912bf432655587dc7dd4a4a561)

Review URL: https://codereview.chromium.org/2165343002 .

Cr-Commit-Position: refs/branch-heads/2785@{#268}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}

[modify] https://crrev.com/500a18cd9552ec468efb13d706a8350ba6ad5e29/chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentAppFactory.java
[modify] https://crrev.com/500a18cd9552ec468efb13d706a8350ba6ad5e29/chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java
[modify] https://crrev.com/500a18cd9552ec468efb13d706a8350ba6ad5e29/chrome/android/java_sources.gni
[add] https://crrev.com/500a18cd9552ec468efb13d706a8350ba6ad5e29/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestPaymentAppTest.java
[modify] https://crrev.com/500a18cd9552ec468efb13d706a8350ba6ad5e29/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestTestBase.java
[add] https://crrev.com/500a18cd9552ec468efb13d706a8350ba6ad5e29/chrome/test/data/android/payments/bobpay.js
[add] https://crrev.com/500a18cd9552ec468efb13d706a8350ba6ad5e29/chrome/test/data/android/payments/payment_request_bobpay_test.html

Components: -UI>Browser>Autofill>Payments UI>Browser>Payments

Sign in to add a comment