New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 628459 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Aug 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug

Blocking:
issue 295792



Sign in to add a comment

attrib type set set by WebGL API should conform to the corresponding attrib type in shader

Project Member Reported by yunchao...@intel.com, Jul 15 2016

Issue description

attrib-type-match.html can cover this feature. But it fails. 

 
The problem is that some existing test cases doesn't obey to this rule. For instance, some test cases like gl-vertex-attrib-i-render.html under conformance2/attribs. 

Comment 2 by zmo@chromium.org, Jul 15 2016

Please feel free to update existing tests if they go against this rule.
Project Member

Comment 3 by bugdroid1@chromium.org, Jul 22 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c487531682715938285a34298659c53c84cd8ca6

commit c487531682715938285a34298659c53c84cd8ca6
Author: yunchao.he <yunchao.he@intel.com>
Date: Fri Jul 22 16:11:07 2016

WebGL 2: make sure VertexAttrib type match the corresponding attrib type in shader.
Fix bugs in attrib-type-match.html

BUG= 628459 
TEST=conformance2/rendering/attrib-type-match.html
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2148723004
Cr-Commit-Position: refs/heads/master@{#407168}

[modify] https://crrev.com/c487531682715938285a34298659c53c84cd8ca6/gpu/command_buffer/service/context_group.cc
[modify] https://crrev.com/c487531682715938285a34298659c53c84cd8ca6/gpu/command_buffer/service/context_state.cc
[modify] https://crrev.com/c487531682715938285a34298659c53c84cd8ca6/gpu/command_buffer/service/context_state.h
[modify] https://crrev.com/c487531682715938285a34298659c53c84cd8ca6/gpu/command_buffer/service/feature_info.cc
[modify] https://crrev.com/c487531682715938285a34298659c53c84cd8ca6/gpu/command_buffer/service/feature_info.h
[modify] https://crrev.com/c487531682715938285a34298659c53c84cd8ca6/gpu/command_buffer/service/gles2_cmd_decoder.cc
[modify] https://crrev.com/c487531682715938285a34298659c53c84cd8ca6/gpu/command_buffer/service/program_manager.cc
[modify] https://crrev.com/c487531682715938285a34298659c53c84cd8ca6/gpu/command_buffer/service/program_manager.h
[modify] https://crrev.com/c487531682715938285a34298659c53c84cd8ca6/gpu/command_buffer/service/program_manager_unittest.cc
[modify] https://crrev.com/c487531682715938285a34298659c53c84cd8ca6/gpu/command_buffer/service/vertex_attrib_manager.cc
[modify] https://crrev.com/c487531682715938285a34298659c53c84cd8ca6/gpu/command_buffer/service/vertex_attrib_manager.h

Comment 5 by zmo@chromium.org, Aug 4 2016

Cc: piman@chromium.org yunchao...@intel.com cwallez@chromium.org
 Issue 627193  has been merged into this issue.

Comment 6 by zmo@chromium.org, Aug 4 2016

Status: Fixed (was: Started)

Sign in to add a comment