New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 628450 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Last visit > 30 days ago
Closed: Jul 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug



Sign in to add a comment

(entry) != nullptr in asm-wasm-builder.cc

Project Member Reported by ClusterFuzz, Jul 15 2016

Issue description

Detailed report: https://cluster-fuzz.appspot.com/testcase?key=4771719055409152

Fuzzer: mbarbella_js_mutation
Job Type: linux_asan_d8_v8_arm_dbg
Platform Id: linux

Crash Type: CHECK failure
Crash Address: 
Crash State:
  (entry) != nullptr in asm-wasm-builder.cc
  
Regressed: V8: r37728:37729

Minimized Testcase (0.34 Kb):
Download: https://cluster-fuzz.appspot.com/download/AMIfv95ehB_ZL5rHygQGpDJEVhzOL633LamltzUmcTBIxjHlhhQ11t4QY9alCKphGfn1Ot1aLet9MGwpIqbV0vv5vcx38dYKqDjb4i1UCEn8kDdZWTbJhiUEST7RPVLdltQkgZVftxBWsOFt6eetFs0wIuKgLfKtFw?testcase_id=4771719055409152
function __f_61(expected, __f_78, __f_9) {
 Wasm.instantiateModuleFromAsm( __f_78.toString());
}
(function () {
})();
function __f_59() {
  "use asm";
  function __f_110() {
    return 71;
  }
  function __f_21() {
    var __v_38 = 0;
    return __v_23[__v_38&0]() | 0;
  }
  return {__f_21:__f_21};
  var __v_23 = [__f_110]
}
__f_61(71, __f_59);


Filer: mmohammad

See https://dev.chromium.org/Home/chromium-security/bugs/reproducing-clusterfuzz-bugs for more information.
 
Owner: titzer@chromium.org
Status: Assigned (was: Available)
suspected cl https://chromium.googlesource.com/v8/v8/+/4bce03b69c953498cf17bd70aaac7ab25525ed60%5E%21/src/wasm/asm-wasm-builder.cc

titzer@ could you please look into this. Thanks

Comment 2 by titzer@chromium.org, Jul 15 2016

Owner: aseemgarg@chromium.org
Looks I got blamed for cleaning up the CHECK macros :-)
Components: -Blink>JavaScript Blink>JavaScript>WebAssembly

Comment 4 by titzer@chromium.org, Jul 18 2016

Cc: titzer@chromium.org
 Issue 629001  has been merged into this issue.
Owner: jpp@chromium.org
This is caused as the function table declaration occurs after the return statement. Hence, it seems it is ignored. asm-wasm-builder gets stuck trying to lookup the function table when building __f_21 (it will throw in debug mode with a null check). The typer should catch this and throw an error.
Cc: bradnelson@chromium.org
Project Member

Comment 7 by bugdroid1@chromium.org, Jul 21 2016

Project Member

Comment 8 by bugdroid1@chromium.org, Jul 21 2016

Project Member

Comment 9 by ClusterFuzz, Jul 22 2016

ClusterFuzz has detected this issue as fixed in range 37949:37950.

Detailed report: https://cluster-fuzz.appspot.com/testcase?key=4771719055409152

Fuzzer: mbarbella_js_mutation
Job Type: linux_asan_d8_v8_arm_dbg
Platform Id: linux

Crash Type: CHECK failure
Crash Address: 
Crash State:
  (entry) != nullptr in asm-wasm-builder.cc
  
Regressed: V8: r37728:37729
Fixed: V8: r37949:37950

Minimized Testcase (0.34 Kb):
Download: https://cluster-fuzz.appspot.com/download/AMIfv95ehB_ZL5rHygQGpDJEVhzOL633LamltzUmcTBIxjHlhhQ11t4QY9alCKphGfn1Ot1aLet9MGwpIqbV0vv5vcx38dYKqDjb4i1UCEn8kDdZWTbJhiUEST7RPVLdltQkgZVftxBWsOFt6eetFs0wIuKgLfKtFw?testcase_id=4771719055409152
function __f_61(expected, __f_78, __f_9) {
 Wasm.instantiateModuleFromAsm( __f_78.toString());
}
(function () {
})();
function __f_59() {
  "use asm";
  function __f_110() {
    return 71;
  }
  function __f_21() {
    var __v_38 = 0;
    return __v_23[__v_38&0]() | 0;
  }
  return {__f_21:__f_21};
  var __v_23 = [__f_110]
}
__f_61(71, __f_59);


See https://dev.chromium.org/Home/chromium-security/bugs/reproducing-clusterfuzz-bugs for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 10 by ClusterFuzz, Jul 22 2016

Labels: ClusterFuzz-Verified
Status: Verified (was: Assigned)
ClusterFuzz testcase is verified as fixed, closing issue.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.
Project Member

Comment 11 by sheriffbot@chromium.org, Nov 22 2016

Labels: -Restrict-View-EditIssue
Removing EditIssue view restrictions from ClusterFuzz filed bugs. If you believe that this issue should still be restricted, please reapply the label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Sign in to add a comment