New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 628442 link

Starred by 1 user
Status: Fixed
Owner:
mcasas@chromium.org
Closed: Jul 2016
Cc:
█ kjellander@chromium.org
emir...@chromium.org
█ phoglund@chromium.org
niklase@chromium.org
mcasas@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug



Sign in to add a comment

Enable MediaRecorder content_unittests

Project Member Reported by mcasas@chromium.org, Jul 15 2016 
They are not compiled:
MediaRecorderHandlerTest
VideoTrackRecorderTest
AudioTrackRecorderTest

as seen in BUILD.gn [1]

[1] https://cs.chromium.org/chromium/src/content/test/BUILD.gn?q=video_track_recorder_unittest.cc&sq=package:chromium&dr=C&l=764
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 15 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b15b8e1c9340de06b0792b4c163e95bf4fc2bede

commit b15b8e1c9340de06b0792b4c163e95bf4fc2bede
Author: mcasas <mcasas@chromium.org>
Date: Fri Jul 15 18:08:02 2016

MediaRecorder content_unittests: enable {{Video,Audio}TrackRecorder,MediaRecorderHandler}Test

This CL enables compilation of MediaRecorder-related unittests:
MediaRecorderHandlerTest
VideoTrackRecorderTest
AudioTrackRecorderTest

BUG= 628442 

Review-Url: https://codereview.chromium.org/2147203003
Cr-Commit-Position: refs/heads/master@{#405791}

[modify] https://crrev.com/b15b8e1c9340de06b0792b4c163e95bf4fc2bede/content/test/BUILD.gn

Comment 2 by mcasas@chromium.org, Jul 15 2016

Status: Fixed (was: Started)
https://build.chromium.org/p/chromium.linux/builders/Android%20Tests 
seems happy, marking as Fixed.

Comment 4 by mcasas@chromium.org, Jan 18 2017

Components: Blink>MediaRecording

Comment 5 by mcasas@chromium.org, Jan 18 2017

Components: -Blink>MediaStream>Recording
►

Sign in to add a comment