New issue
Advanced search Search tips

Issue 628438 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Closed: Jul 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

GN: chromeos: use_cairo and use_pango are 0 with GN

Project Member Reported by steve...@chromium.org, Jul 15 2016

Issue description

In GYP, we have the following in common.gypi:

        # Flags to use pango and cairo.
        ['OS=="win" or OS=="mac" or OS=="ios" or OS=="android" or embedded==1', {
          'use_pango%': 0,
          'use_cairo%': 0,
        }, {
          'use_pango%': 1,
          'use_cairo%': 1,
        }],

In GN, we have the following in ui.gni:

if (is_linux && !use_ozone) {
  use_cairo = true
  use_pango = true
} else {
  use_cairo = false
  use_pango = false
}


As a result, use_cairo/use_pango is false on chromeos with GN, whereas before it was 1 in gyp.

This looks like it might be a deliberate change, but there is not a comment so we should double check this.

 
Status: WontFix (was: Assigned)
Yes, that was a deliberate change:

https://codereview.chromium.org/1170873003

As far as I know, this is correct.

Sign in to add a comment