New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 628429 link

Starred by 3 users

Issue metadata

Status: WontFix
Owner:
Closed: Aug 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug



Sign in to add a comment

chrome on android tablet tab switcher uses copy request

Project Member Reported by boliu@chromium.org, Jul 14 2016

Issue description

specifically GLRenderer::CopyCurrentRenderPassToBitmap, inserted from effect_tree.TakeCopyRequestsAndTransformToSurfac. that takes 1s on some super old tablet on some crappy vivante gpu, so maybe should avoid that

just open two tabs of about:blank and tab switch between them

filing this since I don't have time to get to the bottom of this today..
 

Comment 1 by danakj@chromium.org, Jul 14 2016

def a copy request. Get a backtrace on cc::Layer::RequestCopyOfOutput in that compositor instance.

Comment 2 by boliu@chromium.org, Jul 15 2016

Ahh, so this is RenderWidgetHostViewAndroid::CopyFromCompositingSurface. Not sure why I dismissed that one last night. Full stack below. I wonder why the tablet tab switcher needs screenshots though. Maybe it's to support dynamically switching between phone and tablet in multiwindow mode on N? Should ask UI people.

  006cbda3  CopyFromCompositingSurface                                                                    /android/chromium/src/content/browser/renderer_host/render_widget_host_view_android.cc:873
  006446db  CopyFromBackingStore                                                                          /android/chromium/src/content/browser/renderer_host/render_widget_host_impl.cc:740
  002fa673  Run                                                                                           /android/chromium/src/chrome/browser/android/compositor/tab_content_manager.cc:90
  002f9e61  CacheTab                                                                                      /android/chromium/src/chrome/browser/android/compositor/tab_content_manager.cc:269
  002f9d07  Java_org_chromium_chrome_browser_compositor_layouts_content_TabContentManager_nativeCacheTab  /android/chromium/src/out/Default/gen/chrome/browser/jni_headers/chrome/jni/TabContentManager_jni.h:81 
07-15 07:46:25.051  6082  6082 W System.err: 	at org.chromium.chrome.browser.compositor.layouts.content.TabContentManager.cacheTabThumbnail(TabContentManager.java:229)
07-15 07:46:25.051  6082  6082 W System.err: 	at org.chromium.chrome.browser.tabmodel.TabModelSelectorImpl.cacheTabBitmap(TabModelSelectorImpl.java:387)
07-15 07:46:25.051  6082  6082 W System.err: 	at org.chromium.chrome.browser.tabmodel.TabModelSelectorImpl.requestToShowTab(TabModelSelectorImpl.java:350)
07-15 07:46:25.051  6082  6082 W System.err: 	at org.chromium.chrome.browser.tabmodel.TabModelImpl.setIndex(TabModelImpl.java:492)
07-15 07:46:25.051  6082  6082 W System.err: 	at org.chromium.chrome.browser.tabmodel.TabModelUtils.setIndex(TabModelUtils.java:151)
07-15 07:46:25.051  6082  6082 W System.err: 	at org.chromium.chrome.browser.compositor.overlays.strip.StripLayoutHelper.click(StripLayoutHelper.java:831)
07-15 07:46:25.051  6082  6082 W System.err: 	at org.chromium.chrome.browser.compositor.overlays.strip.StripLayoutHelperManager.click(StripLayoutHelperManager.java:423)
07-15 07:46:25.051  6082  6082 W System.err: 	at org.chromium.chrome.browser.compositor.layouts.LayoutManagerChromeTablet$TabStripEventHandler.click(LayoutManagerChromeTablet.java:243)
07-15 07:46:25.051  6082  6082 W System.err: 	at org.chromium.chrome.browser.compositor.layouts.eventfilter.GestureEventFilter$1.onSingleTapUp(GestureEventFilter.java:134)
07-15 07:46:25.051  6082  6082 W System.err: 	at android.view.GestureDetector.onTouchEvent(GestureDetector.java:635)
07-15 07:46:25.052  6082  6082 W System.err: 	at org.chromium.chrome.browser.compositor.layouts.eventfilter.GestureEventFilter.onTouchEventInternal(GestureEventFilter.java:240)
07-15 07:46:25.052  6082  6082 W System.err: 	at org.chromium.chrome.browser.compositor.layouts.eventfilter.EventFilter.onTouchEvent(EventFilter.java:95)
07-15 07:46:25.052  6082  6082 W System.err: 	at org.chromium.chrome.browser.compositor.layouts.LayoutManager.onTouchEvent(LayoutManager.java:160)
07-15 07:46:25.052  6082  6082 W System.err: 	at org.chromium.chrome.browser.compositor.CompositorViewHolder.onTouchEvent(CompositorViewHolder.java:367)

Comment 3 by boliu@chromium.org, Jul 15 2016

Cc: dtrainor@chromium.org dfalcant...@chromium.org
dtrainor, dfalcantara: know what the tab screen shots are used for on the tablet interface?

Comment 4 by boliu@chromium.org, Jul 20 2016

Cc: tedc...@chromium.org
so iirc, ted told me it's used for 1) restoring the whole app, and 2) preview for side swiping

Comment 5 by boliu@chromium.org, Aug 29 2016

Status: WontFix (was: Untriaged)

Sign in to add a comment