New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 628422 link

Starred by 2 users
Status: Verified
Owner:
derat@chromium.org
Closed: Jan 2017
Cc:
█ ejcaruso@chromium.org
dbasehore@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Add tests for powerd's daemon.cc

Project Member Reported by derat@chromium.org, Jul 14 2016 
powerd's daemon.cc file is more than a thousand lines long now but doesn't have any unit tests. Most of what it does is straightforward but it's still scary to touch it.

I should pull the "real" things that it does (including the creation of many member objects) into a DaemonDelegate interface, with a real implementation passed by main.cc and a no-op implementation that returns stubs (most of which already exist) passed by tests.

This might touch on  issue 558902 .
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 21 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/36e522ee0161b381acc1856ce3d94765c447e144

commit 36e522ee0161b381acc1856ce3d94765c447e144
Author: Daniel Erat <derat@chromium.org>
Date: Wed Jul 20 00:01:07 2016

power: Rename DBusSender to system::DBusWrapper.

Rename and move the DBusSender class in anticipation of
making it wrap more D-Bus operations that are performed by
daemon.cc (so that daemon.cc can have unit tests).

BUG= chromium:628422 
TEST=tests still pass

Change-Id: I0b2af1cb423c2610b0a7dce3b68108dedffc27cf
Reviewed-on: https://chromium-review.googlesource.com/361618
Commit-Ready: Dan Erat <derat@chromium.org>
Tested-by: Dan Erat <derat@chromium.org>
Reviewed-by: Dan Erat <derat@chromium.org>

[rename] https://crrev.com/36e522ee0161b381acc1856ce3d94765c447e144/power_manager/powerd/system/dbus_wrapper_stub.h
[modify] https://crrev.com/36e522ee0161b381acc1856ce3d94765c447e144/power_manager/powerd/policy/input_controller.cc
[modify] https://crrev.com/36e522ee0161b381acc1856ce3d94765c447e144/power_manager/powerd/system/peripheral_battery_watcher.cc
[modify] https://crrev.com/36e522ee0161b381acc1856ce3d94765c447e144/power_manager/powerd/system/peripheral_battery_watcher_unittest.cc
[rename] https://crrev.com/36e522ee0161b381acc1856ce3d94765c447e144/power_manager/powerd/system/dbus_wrapper_stub.cc
[rename] https://crrev.com/36e522ee0161b381acc1856ce3d94765c447e144/power_manager/powerd/system/dbus_wrapper.cc
[rename] https://crrev.com/36e522ee0161b381acc1856ce3d94765c447e144/power_manager/powerd/system/dbus_wrapper.h
[modify] https://crrev.com/36e522ee0161b381acc1856ce3d94765c447e144/power_manager/power_manager.gyp
[modify] https://crrev.com/36e522ee0161b381acc1856ce3d94765c447e144/power_manager/powerd/policy/suspender.h
[modify] https://crrev.com/36e522ee0161b381acc1856ce3d94765c447e144/power_manager/powerd/daemon.cc
[modify] https://crrev.com/36e522ee0161b381acc1856ce3d94765c447e144/power_manager/powerd/policy/suspend_delay_controller.h
[modify] https://crrev.com/36e522ee0161b381acc1856ce3d94765c447e144/power_manager/powerd/system/peripheral_battery_watcher.h
[modify] https://crrev.com/36e522ee0161b381acc1856ce3d94765c447e144/power_manager/powerd/policy/input_controller.h
[modify] https://crrev.com/36e522ee0161b381acc1856ce3d94765c447e144/power_manager/powerd/daemon.h
[modify] https://crrev.com/36e522ee0161b381acc1856ce3d94765c447e144/power_manager/powerd/policy/input_controller_unittest.cc
[modify] https://crrev.com/36e522ee0161b381acc1856ce3d94765c447e144/power_manager/powerd/policy/suspender.cc
[modify] https://crrev.com/36e522ee0161b381acc1856ce3d94765c447e144/power_manager/powerd/policy/suspender_unittest.cc
Project Member

Comment 2 by bugdroid1@chromium.org, Jul 21 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/8390e5aa250012e022a09f4fc32c2e1fb7781993

commit 8390e5aa250012e022a09f4fc32c2e1fb7781993
Author: Daniel Erat <derat@chromium.org>
Date: Tue Jul 19 21:30:34 2016

power: Move exiting-dark-resume code out of Daemon.

Move CanSafelyExitDarkResume() and ExitDarkResume() out of
the big, untested daemon.cc file and into
DarkResumeInterface. No functional changes intended.

BUG= chromium:628422 
TEST=existing unit tests pass

Change-Id: I45fa6236aff6cd56e0aad3fea774a1e1958eca85
Reviewed-on: https://chromium-review.googlesource.com/361577
Commit-Ready: Dan Erat <derat@chromium.org>
Tested-by: Dan Erat <derat@chromium.org>
Reviewed-by: Dan Erat <derat@chromium.org>

[modify] https://crrev.com/8390e5aa250012e022a09f4fc32c2e1fb7781993/power_manager/powerd/system/dark_resume.cc
[modify] https://crrev.com/8390e5aa250012e022a09f4fc32c2e1fb7781993/power_manager/powerd/system/dark_resume_stub.cc
[modify] https://crrev.com/8390e5aa250012e022a09f4fc32c2e1fb7781993/power_manager/powerd/daemon.cc
[modify] https://crrev.com/8390e5aa250012e022a09f4fc32c2e1fb7781993/power_manager/powerd/system/dark_resume.h
[modify] https://crrev.com/8390e5aa250012e022a09f4fc32c2e1fb7781993/power_manager/powerd/system/dark_resume_stub.h
[modify] https://crrev.com/8390e5aa250012e022a09f4fc32c2e1fb7781993/power_manager/powerd/policy/suspender.cc
[modify] https://crrev.com/8390e5aa250012e022a09f4fc32c2e1fb7781993/power_manager/powerd/daemon.h
[modify] https://crrev.com/8390e5aa250012e022a09f4fc32c2e1fb7781993/power_manager/powerd/system/dark_resume_unittest.cc
[modify] https://crrev.com/8390e5aa250012e022a09f4fc32c2e1fb7781993/power_manager/powerd/policy/suspender.h
[modify] https://crrev.com/8390e5aa250012e022a09f4fc32c2e1fb7781993/power_manager/powerd/policy/suspender_unittest.cc
Project Member

Comment 3 by bugdroid1@chromium.org, Jul 23 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/ce3a3082a0f26b5bc37e7ca7a08d624414dcddc7

commit ce3a3082a0f26b5bc37e7ca7a08d624414dcddc7
Author: Daniel Erat <derat@chromium.org>
Date: Thu Jul 21 14:27:42 2016

power: Make D-Bus calls through DBusWrapper.

To permit tests to be added in the future, prevent powerd's
Daemon class from interacting directly with Chromium's D-Bus
library. Instead, use new methods added to
system::DBusWrapperInterface.

BUG= chromium:628422 
TEST=existing tests pass; also manually verified that D-Bus
     communication is still working on a live system

Change-Id: If11c2b4a0ba16e427a95a182d8236017fb9e0e24
Reviewed-on: https://chromium-review.googlesource.com/362480
Commit-Ready: Dan Erat <derat@chromium.org>
Tested-by: Dan Erat <derat@chromium.org>
Reviewed-by: Dan Erat <derat@chromium.org>

[modify] https://crrev.com/ce3a3082a0f26b5bc37e7ca7a08d624414dcddc7/power_manager/powerd/system/dbus_wrapper_stub.h
[modify] https://crrev.com/ce3a3082a0f26b5bc37e7ca7a08d624414dcddc7/power_manager/powerd/system/dbus_wrapper.cc
[modify] https://crrev.com/ce3a3082a0f26b5bc37e7ca7a08d624414dcddc7/power_manager/powerd/system/dbus_wrapper.h
[modify] https://crrev.com/ce3a3082a0f26b5bc37e7ca7a08d624414dcddc7/power_manager/powerd/system/dbus_wrapper_stub.cc
[modify] https://crrev.com/ce3a3082a0f26b5bc37e7ca7a08d624414dcddc7/power_manager/powerd/daemon.cc
[modify] https://crrev.com/ce3a3082a0f26b5bc37e7ca7a08d624414dcddc7/power_manager/powerd/daemon.h
Project Member

Comment 4 by bugdroid1@chromium.org, Jul 24 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/cf2f03c674b39bfd0fd5c061165921149f3ee2e1

commit cf2f03c674b39bfd0fd5c061165921149f3ee2e1
Author: Daniel Erat <derat@chromium.org>
Date: Thu Jul 14 23:22:42 2016

power: Move much of Daemon initialization to DaemonDelegate.

Introduce a new DaemonDelegate interface, implemented within
main.cc, that Daemon uses to create many of its members
(particularly ones from the system namespace). This creates
the possibility of adding unit tests for Daemon that inject
stub member objects.

Also add an AudioClientInterface class.

BUG= chromium:628422 
TEST=existing tests pass; manually confirmed that powerd
     starts correctly and appears to work the same as before

Change-Id: I771e00a9305d8b1745b35e7a8597726b19011be9
Reviewed-on: https://chromium-review.googlesource.com/362701
Commit-Ready: Dan Erat <derat@chromium.org>
Tested-by: Dan Erat <derat@chromium.org>
Reviewed-by: Dan Erat <derat@chromium.org>

[modify] https://crrev.com/cf2f03c674b39bfd0fd5c061165921149f3ee2e1/power_manager/powerd/system/audio_client.cc
[modify] https://crrev.com/cf2f03c674b39bfd0fd5c061165921149f3ee2e1/power_manager/powerd/main.cc
[modify] https://crrev.com/cf2f03c674b39bfd0fd5c061165921149f3ee2e1/power_manager/powerd/system/display/display_power_setter.h
[add] https://crrev.com/cf2f03c674b39bfd0fd5c061165921149f3ee2e1/power_manager/powerd/daemon_delegate.h
[add] https://crrev.com/cf2f03c674b39bfd0fd5c061165921149f3ee2e1/power_manager/powerd/system/audio_client_interface.h
[modify] https://crrev.com/cf2f03c674b39bfd0fd5c061165921149f3ee2e1/power_manager/powerd/daemon.cc
[modify] https://crrev.com/cf2f03c674b39bfd0fd5c061165921149f3ee2e1/power_manager/powerd/system/audio_client.h
[modify] https://crrev.com/cf2f03c674b39bfd0fd5c061165921149f3ee2e1/power_manager/powerd/daemon.h
[modify] https://crrev.com/cf2f03c674b39bfd0fd5c061165921149f3ee2e1/power_manager/powerd/system/display/display_power_setter.cc
Project Member

Comment 5 by bugdroid1@chromium.org, Jul 26 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/8d546b9dfafe819e7595f317e32fc34433c076c0

commit 8d546b9dfafe819e7595f317e32fc34433c076c0
Author: Daniel Erat <derat@chromium.org>
Date: Sat Jul 23 00:01:26 2016

power: Promote KeyboardBacklightController methods.

Move KeyboardBacklightController's HandleVideoActivity,
HandleHoverStateChange[d], and HandleTabletModeChange
methods to the BacklightController interface. This allows a
BacklightControllerStub object to be injected into Daemon
for testing.

In the same vein, make Daemon be more consistent about
notifying both the display and keyboard backlight controller
about all events.

Also do a few renames throughout the code for consistency:

  BrightnessChanged -> BrightnessChange
  HoverStateChanged -> HoverStateChange
  TabletModeChanged -> TabletModeChange

(There are many other methods that can still be updated.)

BUG= chromium:628422 
TEST=tests pass

Change-Id: I877b461862af5f5022a953ef608295cf6294b131
Reviewed-on: https://chromium-review.googlesource.com/362980
Commit-Ready: Dan Erat <derat@chromium.org>
Tested-by: Dan Erat <derat@chromium.org>
Reviewed-by: Eric Caruso <ejcaruso@chromium.org>

[modify] https://crrev.com/8d546b9dfafe819e7595f317e32fc34433c076c0/power_manager/powerd/policy/internal_backlight_controller.h
[modify] https://crrev.com/8d546b9dfafe819e7595f317e32fc34433c076c0/power_manager/powerd/daemon_delegate.h
[modify] https://crrev.com/8d546b9dfafe819e7595f317e32fc34433c076c0/power_manager/powerd/daemon.cc
[modify] https://crrev.com/8d546b9dfafe819e7595f317e32fc34433c076c0/power_manager/powerd/policy/keyboard_backlight_controller.cc
[modify] https://crrev.com/8d546b9dfafe819e7595f317e32fc34433c076c0/power_manager/powerd/policy/external_backlight_controller.cc
[modify] https://crrev.com/8d546b9dfafe819e7595f317e32fc34433c076c0/power_manager/powerd/policy/input_controller.h
[modify] https://crrev.com/8d546b9dfafe819e7595f317e32fc34433c076c0/power_manager/powerd/daemon.h
[modify] https://crrev.com/8d546b9dfafe819e7595f317e32fc34433c076c0/power_manager/powerd/system/input_watcher_stub.cc
[modify] https://crrev.com/8d546b9dfafe819e7595f317e32fc34433c076c0/power_manager/powerd/main.cc
[modify] https://crrev.com/8d546b9dfafe819e7595f317e32fc34433c076c0/power_manager/powerd/policy/backlight_controller.h
[modify] https://crrev.com/8d546b9dfafe819e7595f317e32fc34433c076c0/power_manager/powerd/policy/wakeup_controller.cc
[modify] https://crrev.com/8d546b9dfafe819e7595f317e32fc34433c076c0/power_manager/powerd/policy/input_controller.cc
[modify] https://crrev.com/8d546b9dfafe819e7595f317e32fc34433c076c0/power_manager/powerd/system/input_watcher_unittest.cc
[modify] https://crrev.com/8d546b9dfafe819e7595f317e32fc34433c076c0/power_manager/powerd/policy/keyboard_backlight_controller_unittest.cc
[modify] https://crrev.com/8d546b9dfafe819e7595f317e32fc34433c076c0/power_manager/powerd/policy/wakeup_controller.h
[modify] https://crrev.com/8d546b9dfafe819e7595f317e32fc34433c076c0/power_manager/powerd/policy/backlight_controller_observer_stub.h
[modify] https://crrev.com/8d546b9dfafe819e7595f317e32fc34433c076c0/power_manager/powerd/policy/input_controller_unittest.cc
[modify] https://crrev.com/8d546b9dfafe819e7595f317e32fc34433c076c0/power_manager/powerd/policy/backlight_controller_stub.cc
[modify] https://crrev.com/8d546b9dfafe819e7595f317e32fc34433c076c0/power_manager/tools/get_powerd_initial_backlight_level.cc
[modify] https://crrev.com/8d546b9dfafe819e7595f317e32fc34433c076c0/power_manager/powerd/policy/backlight_controller_stub.h
[modify] https://crrev.com/8d546b9dfafe819e7595f317e32fc34433c076c0/power_manager/powerd/policy/backlight_controller_observer_stub.cc
[modify] https://crrev.com/8d546b9dfafe819e7595f317e32fc34433c076c0/power_manager/powerd/system/input_watcher.cc
[modify] https://crrev.com/8d546b9dfafe819e7595f317e32fc34433c076c0/power_manager/powerd/policy/external_backlight_controller.h
[modify] https://crrev.com/8d546b9dfafe819e7595f317e32fc34433c076c0/power_manager/powerd/system/input_observer.h
[modify] https://crrev.com/8d546b9dfafe819e7595f317e32fc34433c076c0/power_manager/powerd/policy/keyboard_backlight_controller.h
[modify] https://crrev.com/8d546b9dfafe819e7595f317e32fc34433c076c0/power_manager/powerd/policy/internal_backlight_controller.cc
[modify] https://crrev.com/8d546b9dfafe819e7595f317e32fc34433c076c0/power_manager/powerd/policy/backlight_controller_observer.h
Project Member

Comment 6 by bugdroid1@chromium.org, Jul 26 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/ab4883b0d0d7b2ba390baee78668c6b2984d31ea

commit ab4883b0d0d7b2ba390baee78668c6b2984d31ea
Author: Daniel Erat <derat@chromium.org>
Date: Mon Jul 25 21:05:21 2016

power: Fix forward declarations in daemon_delegate.h.

BUG= chromium:628422 
TEST=still compiles

Change-Id: I3d72146ed420d45e29e0700a9aefc8faba1fc842
Reviewed-on: https://chromium-review.googlesource.com/362986
Commit-Ready: Dan Erat <derat@chromium.org>
Tested-by: Dan Erat <derat@chromium.org>
Reviewed-by: Eric Caruso <ejcaruso@chromium.org>

[modify] https://crrev.com/ab4883b0d0d7b2ba390baee78668c6b2984d31ea/power_manager/powerd/daemon_delegate.h
Project Member

Comment 7 by bugdroid1@chromium.org, Jul 26 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/2c2ed5cb8a9e30a5d15d2c1c66d407ae2da86494

commit 2c2ed5cb8a9e30a5d15d2c1c66d407ae2da86494
Author: Daniel Erat <derat@chromium.org>
Date: Mon Jul 25 21:06:23 2016

power: Make Daemon observe KeyboardBacklightController.

powerd's Daemon class wasn't observing
KeyboardBacklightController, despite having code that tries
to emit D-Bus signals when the brightness changes (which I
don't think anyone does anything with). Fix this.

BUG= chromium:628422 
TEST=it still builds

Change-Id: I6028ed95742c5b82e63c2535fa13be5ed0e6fa66
Reviewed-on: https://chromium-review.googlesource.com/362987
Commit-Ready: Dan Erat <derat@chromium.org>
Tested-by: Dan Erat <derat@chromium.org>
Reviewed-by: Eric Caruso <ejcaruso@chromium.org>

[modify] https://crrev.com/2c2ed5cb8a9e30a5d15d2c1c66d407ae2da86494/power_manager/powerd/daemon.cc
Project Member

Comment 8 by bugdroid1@chromium.org, Aug 3 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/480f1100ad68bab08d724e42be3cb15856bb8cb3

commit 480f1100ad68bab08d724e42be3cb15856bb8cb3
Author: Daniel Erat <derat@chromium.org>
Date: Wed Jul 27 02:56:15 2016

power: Make Daemon get Prefs from its delegate.

Make the Daemon class get a PrefsInterface object from
DelegateDaemon instead of instantiating a concrete Prefs
object itself. This will allow tests to inject a FakePrefs
object instead.

BUG= chromium:628422 
TEST=powerd builds and runs; prefs are read correctly

Change-Id: Iab9cef3a464502987fa668e2e4d0312f4798abbf
Reviewed-on: https://chromium-review.googlesource.com/363529
Commit-Ready: Dan Erat <derat@chromium.org>
Tested-by: Dan Erat <derat@chromium.org>
Reviewed-by: Eric Caruso <ejcaruso@chromium.org>

[modify] https://crrev.com/480f1100ad68bab08d724e42be3cb15856bb8cb3/power_manager/powerd/daemon.cc
[modify] https://crrev.com/480f1100ad68bab08d724e42be3cb15856bb8cb3/power_manager/powerd/daemon.h
[modify] https://crrev.com/480f1100ad68bab08d724e42be3cb15856bb8cb3/power_manager/powerd/daemon_delegate.h
[modify] https://crrev.com/480f1100ad68bab08d724e42be3cb15856bb8cb3/power_manager/powerd/main.cc
Project Member

Comment 9 by bugdroid1@chromium.org, Sep 2 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/ceae2ce1b3744cfeef6b23919bfc8a0ce0b6d141

commit ceae2ce1b3744cfeef6b23919bfc8a0ce0b6d141
Author: Daniel Erat <derat@chromium.org>
Date: Wed Aug 31 20:34:43 2016

power: Add AudioClientStub and improve other stubs.

Add a new system::AudioClientStub class and improve
policy::BacklightControllerStub and system::PowerSupplyStub
in preparation for upcoming Daemon unit tests.

BUG= chromium:628422 
TEST=still builds

Change-Id: I5b5b822db518e0a7240e21bfcfc8787a3f62d52f
Reviewed-on: https://chromium-review.googlesource.com/379256
Commit-Ready: Dan Erat <derat@chromium.org>
Tested-by: Dan Erat <derat@chromium.org>
Reviewed-by: Eric Caruso <ejcaruso@chromium.org>

[modify] https://crrev.com/ceae2ce1b3744cfeef6b23919bfc8a0ce0b6d141/power_manager/powerd/policy/backlight_controller_stub.cc
[modify] https://crrev.com/ceae2ce1b3744cfeef6b23919bfc8a0ce0b6d141/power_manager/powerd/policy/backlight_controller_stub.h
[modify] https://crrev.com/ceae2ce1b3744cfeef6b23919bfc8a0ce0b6d141/power_manager/power_manager.gyp
[modify] https://crrev.com/ceae2ce1b3744cfeef6b23919bfc8a0ce0b6d141/power_manager/powerd/system/power_supply_stub.h
[modify] https://crrev.com/ceae2ce1b3744cfeef6b23919bfc8a0ce0b6d141/power_manager/powerd/system/power_supply_stub.cc
[add] https://crrev.com/ceae2ce1b3744cfeef6b23919bfc8a0ce0b6d141/power_manager/powerd/system/audio_client_stub.cc
[add] https://crrev.com/ceae2ce1b3744cfeef6b23919bfc8a0ce0b6d141/power_manager/powerd/system/audio_client_stub.h
Project Member

Comment 10 by bugdroid1@chromium.org, Sep 7 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/33ec9dc1767ddcf839d11ef783d16021e4007a4f

commit 33ec9dc1767ddcf839d11ef783d16021e4007a4f
Author: Daniel Erat <derat@chromium.org>
Date: Wed Aug 31 21:45:46 2016

power: Make DBusWrapperStub track signals and methods.

Make system::DBusWrapperStub return real ObjectProxy
objects, keep track of exported methods (and support calling
them later from test code), and save raw signals that are
emitted.

BUG= chromium:628422 
TEST=existing (and new) tests pass

Change-Id: I1a9896177aaaa290a77f65fde4c627fb2a935ebe
Reviewed-on: https://chromium-review.googlesource.com/379355
Commit-Ready: Dan Erat <derat@chromium.org>
Tested-by: Dan Erat <derat@chromium.org>
Reviewed-by: Eric Caruso <ejcaruso@chromium.org>

[modify] https://crrev.com/33ec9dc1767ddcf839d11ef783d16021e4007a4f/power_manager/powerd/system/peripheral_battery_watcher_unittest.cc
[modify] https://crrev.com/33ec9dc1767ddcf839d11ef783d16021e4007a4f/power_manager/power_manager.gyp
[modify] https://crrev.com/33ec9dc1767ddcf839d11ef783d16021e4007a4f/power_manager/powerd/system/dbus_wrapper_stub.cc
[modify] https://crrev.com/33ec9dc1767ddcf839d11ef783d16021e4007a4f/power_manager/powerd/system/dbus_wrapper_stub.h
[modify] https://crrev.com/33ec9dc1767ddcf839d11ef783d16021e4007a4f/power_manager/powerd/policy/input_controller_unittest.cc
[modify] https://crrev.com/33ec9dc1767ddcf839d11ef783d16021e4007a4f/power_manager/powerd/policy/suspender_unittest.cc
Project Member

Comment 11 by bugdroid1@chromium.org, Sep 17 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/4e7964d51371df17e1075a692e7c930d5acfe869

commit 4e7964d51371df17e1075a692e7c930d5acfe869
Author: Daniel Erat <derat@chromium.org>
Date: Sat Jul 23 17:33:14 2016

power: Add Daemon unit tests.

Take a first pass at adding some unit tests for powerd's
Daemon class. These focus on D-Bus communication and
shutdown/restart behavior.

Also add a bit more functionality to system::AudioClientStub
and system::DBusWrapperStub.

BUG= chromium:628422 
TEST=they pass

Change-Id: Ia7979c73a186301a7e315b55d0b999d54baa2886
Reviewed-on: https://chromium-review.googlesource.com/382682
Commit-Ready: Dan Erat <derat@chromium.org>
Tested-by: Dan Erat <derat@chromium.org>
Reviewed-by: Eric Caruso <ejcaruso@chromium.org>

[modify] https://crrev.com/4e7964d51371df17e1075a692e7c930d5acfe869/power_manager/powerd/system/dbus_wrapper_stub.h
[modify] https://crrev.com/4e7964d51371df17e1075a692e7c930d5acfe869/power_manager/common/power_constants.cc
[modify] https://crrev.com/4e7964d51371df17e1075a692e7c930d5acfe869/power_manager/power_manager.gyp
[modify] https://crrev.com/4e7964d51371df17e1075a692e7c930d5acfe869/power_manager/common/power_constants.h
[modify] https://crrev.com/4e7964d51371df17e1075a692e7c930d5acfe869/power_manager/powerd/system/dbus_wrapper_stub.cc
[modify] https://crrev.com/4e7964d51371df17e1075a692e7c930d5acfe869/power_manager/powerd/daemon.cc
[modify] https://crrev.com/4e7964d51371df17e1075a692e7c930d5acfe869/power_manager/powerd/daemon.h
[add] https://crrev.com/4e7964d51371df17e1075a692e7c930d5acfe869/power_manager/powerd/daemon_unittest.cc
[modify] https://crrev.com/4e7964d51371df17e1075a692e7c930d5acfe869/power_manager/powerd/system/audio_client_stub.cc
[modify] https://crrev.com/4e7964d51371df17e1075a692e7c930d5acfe869/power_manager/powerd/system/audio_client_stub.h

Comment 12 by derat@chromium.org, Jan 12 2017

Status: Verified (was: Started)
There are still TODOs for more tests, but I'm closing this since it's now straightforward to add tests when making changes.
►

Sign in to add a comment