Incorrect cull rect for svg text with text-shadow. |
||
Issue descriptionBreakout from http://crbug.com/529938 -- svg/custom/repaint-shadow.svg fails as seen here: https://storage.googleapis.com/chromium-layout-test-archives/linux_blink_rel/88307/layout-test-results/results.html Commenting out quickReject based on cull rect in drawing_display_item.cc fixes the test, also note cull rect vs visual rect/paint-invalidation-rect (the latter looks right): {index: 3, client: "0x3961c9c58010 InlineTextBox 'X'", type: "DrawingPaintPhaseForeground", rect: [20.000000,19.000000 50.000000x51.000000], cacheIsValid: true, visualRect: [20,19 255x256]}, {index: 4, client: "0x3961c9c580a0 InlineTextBox 'X'", type: "DrawingPaintPhaseForeground", rect: [171.000000,19.000000 50.000000x51.000000], cacheIsValid: true, visualRect: [171,19 255x256]}, It looks like the position/size of the shadow is just not incorporated into the cull rect.
,
Jul 20 2016
https://codereview.chromium.org/2162033003 is in flight.
,
Jul 20 2016
,
Jul 20 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/378e044af89a3c3a75f83c60508c0c42a297bae1 commit 378e044af89a3c3a75f83c60508c0c42a297bae1 Author: wkorman <wkorman@chromium.org> Date: Wed Jul 20 17:59:41 2016 Include any text shadow bounds in SVG text cull rect. BUG= 628414 Review-Url: https://codereview.chromium.org/2162033003 Cr-Commit-Position: refs/heads/master@{#406612} [modify] https://crrev.com/378e044af89a3c3a75f83c60508c0c42a297bae1/third_party/WebKit/Source/core/paint/SVGInlineTextBoxPainter.cpp [modify] https://crrev.com/378e044af89a3c3a75f83c60508c0c42a297bae1/third_party/WebKit/Source/core/paint/SVGInlineTextBoxPainter.h [modify] https://crrev.com/378e044af89a3c3a75f83c60508c0c42a297bae1/third_party/WebKit/Source/core/paint/SVGInlineTextBoxPainterTest.cpp |
||
►
Sign in to add a comment |
||
Comment 1 by wkorman@chromium.org
, Jul 14 2016