DevTools: styles sidebar rendering is slow |
||||
Issue descriptionWhat steps will reproduce the problem? 1. Goto starbucks.com 2. Select any deep-nested dom element to inspect 3. Try to add a new property in SSP. What is the expected result? Styles sidebar pane is responsive and smooth What happens instead of that? Styles sidebar pane is sluggish
,
Jul 16 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/59dfe5a201bde760a7ff95e7cc66e00967cd7f02 commit 59dfe5a201bde760a7ff95e7cc66e00967cd7f02 Author: lushnikov <lushnikov@chromium.org> Date: Sat Jul 16 04:34:29 2016 DevTools: [SSP] render selectors effectively Currently, the selectors in styles sidebar pane are rendered each in a separate span, which makes them ctrl-clickable. This is needed to help in SourceMap debugging, as different selectors might be coming from different places in sources. (see crbug.com/266416 ) However, as it generates a lot of DOM nodes, this patch stitches unmatched selectors together in a single element. The selectors, however, are rendered separately as the user hits Ctrl and hovers over the section. BUG= 628409 R=pfeldman, dgozman Review-Url: https://codereview.chromium.org/2146233003 Cr-Commit-Position: refs/heads/master@{#405934} [modify] https://crrev.com/59dfe5a201bde760a7ff95e7cc66e00967cd7f02/third_party/WebKit/LayoutTests/inspector/elements/styles-1/commit-selector-mark-matching-expected.txt [modify] https://crrev.com/59dfe5a201bde760a7ff95e7cc66e00967cd7f02/third_party/WebKit/LayoutTests/inspector/elements/styles-2/pseudo-elements-expected.txt [modify] https://crrev.com/59dfe5a201bde760a7ff95e7cc66e00967cd7f02/third_party/WebKit/LayoutTests/inspector/elements/styles-3/styles-add-new-rule-colon-expected.txt [modify] https://crrev.com/59dfe5a201bde760a7ff95e7cc66e00967cd7f02/third_party/WebKit/LayoutTests/inspector/elements/styles-3/styles-add-new-rule-expected.txt [modify] https://crrev.com/59dfe5a201bde760a7ff95e7cc66e00967cd7f02/third_party/WebKit/LayoutTests/inspector/elements/styles-3/styles-add-new-rule-tab-expected.txt [modify] https://crrev.com/59dfe5a201bde760a7ff95e7cc66e00967cd7f02/third_party/WebKit/Source/devtools/front_end/elements/StylesSidebarPane.js
,
Jul 19 2016
,
Sep 29 2016
,
Sep 29 2016
|
||||
►
Sign in to add a comment |
||||
Comment 1 by lushnikov@chromium.org
, Jul 14 2016173 KB
173 KB View Download