New issue
Advanced search Search tips

Issue 628389 link

Starred by 5 users

Issue metadata

Status: Fixed
Owner:
Closed: Jul 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 3
Type: Bug

Blocking:
issue 580337



Sign in to add a comment

DevTools: explicitly differentiate ints vs doubles in the protocol bindings.

Project Member Reported by pfeldman@chromium.org, Jul 14 2016

Issue description

It helps with strictness, also fixes serialization of integers.
 

Comment 1 Deleted

Summary: DevTools: explicitly differentiate ints vs doubles in the protocol bindings. (was: DevTools: explicitly differentiate ints vs doubles in the protocol.)

Comment 3 by noj...@gmail.com, Jul 14 2016

Referencing node issue https://github.com/nodejs/node/issues/7736
Project Member

Comment 4 by bugdroid1@chromium.org, Jul 14 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/33055dd442b76878063eff2385a27eb7604fbae6

commit 33055dd442b76878063eff2385a27eb7604fbae6
Author: pfeldman <pfeldman@chromium.org>
Date: Thu Jul 14 23:55:21 2016

DevTools: explicitly differentiate ints vs doubles in the protocol bindings.

BUG= 628389 

Review-Url: https://codereview.chromium.org/2151083002
Cr-Commit-Position: refs/heads/master@{#405639}

[modify] https://crrev.com/33055dd442b76878063eff2385a27eb7604fbae6/third_party/WebKit/Source/core/inspector/InspectorAnimationAgent.cpp
[modify] https://crrev.com/33055dd442b76878063eff2385a27eb7604fbae6/third_party/WebKit/Source/core/inspector/InspectorDOMDebuggerAgent.cpp
[modify] https://crrev.com/33055dd442b76878063eff2385a27eb7604fbae6/third_party/WebKit/Source/core/inspector/InspectorNetworkAgent.cpp
[modify] https://crrev.com/33055dd442b76878063eff2385a27eb7604fbae6/third_party/WebKit/Source/core/inspector/InspectorPageAgent.cpp
[modify] https://crrev.com/33055dd442b76878063eff2385a27eb7604fbae6/third_party/WebKit/Source/core/inspector/LayoutEditor.cpp
[modify] https://crrev.com/33055dd442b76878063eff2385a27eb7604fbae6/third_party/WebKit/Source/modules/device_orientation/DeviceOrientationInspectorAgent.cpp
[modify] https://crrev.com/33055dd442b76878063eff2385a27eb7604fbae6/third_party/WebKit/Source/platform/inspector_protocol/Array.h
[modify] https://crrev.com/33055dd442b76878063eff2385a27eb7604fbae6/third_party/WebKit/Source/platform/inspector_protocol/CodeGenerator.py
[modify] https://crrev.com/33055dd442b76878063eff2385a27eb7604fbae6/third_party/WebKit/Source/platform/inspector_protocol/DispatcherBase.cpp
[modify] https://crrev.com/33055dd442b76878063eff2385a27eb7604fbae6/third_party/WebKit/Source/platform/inspector_protocol/Parser.cpp
[modify] https://crrev.com/33055dd442b76878063eff2385a27eb7604fbae6/third_party/WebKit/Source/platform/inspector_protocol/ParserTest.cpp
[modify] https://crrev.com/33055dd442b76878063eff2385a27eb7604fbae6/third_party/WebKit/Source/platform/inspector_protocol/String16STL.h
[modify] https://crrev.com/33055dd442b76878063eff2385a27eb7604fbae6/third_party/WebKit/Source/platform/inspector_protocol/String16WTF.h
[modify] https://crrev.com/33055dd442b76878063eff2385a27eb7604fbae6/third_party/WebKit/Source/platform/inspector_protocol/ValueConversions.h
[modify] https://crrev.com/33055dd442b76878063eff2385a27eb7604fbae6/third_party/WebKit/Source/platform/inspector_protocol/Values.cpp
[modify] https://crrev.com/33055dd442b76878063eff2385a27eb7604fbae6/third_party/WebKit/Source/platform/inspector_protocol/Values.h
[modify] https://crrev.com/33055dd442b76878063eff2385a27eb7604fbae6/third_party/WebKit/Source/platform/v8_inspector/InjectedScript.cpp
[modify] https://crrev.com/33055dd442b76878063eff2385a27eb7604fbae6/third_party/WebKit/Source/platform/v8_inspector/RemoteObjectId.cpp
[modify] https://crrev.com/33055dd442b76878063eff2385a27eb7604fbae6/third_party/WebKit/Source/platform/v8_inspector/V8Console.cpp
[modify] https://crrev.com/33055dd442b76878063eff2385a27eb7604fbae6/third_party/WebKit/Source/platform/v8_inspector/V8ConsoleAgentImpl.cpp
[modify] https://crrev.com/33055dd442b76878063eff2385a27eb7604fbae6/third_party/WebKit/Source/platform/v8_inspector/V8ConsoleMessage.cpp
[modify] https://crrev.com/33055dd442b76878063eff2385a27eb7604fbae6/third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.cpp
[modify] https://crrev.com/33055dd442b76878063eff2385a27eb7604fbae6/third_party/WebKit/Source/platform/v8_inspector/V8DebuggerImpl.cpp
[modify] https://crrev.com/33055dd442b76878063eff2385a27eb7604fbae6/third_party/WebKit/Source/platform/v8_inspector/V8DebuggerScript.cpp
[modify] https://crrev.com/33055dd442b76878063eff2385a27eb7604fbae6/third_party/WebKit/Source/platform/v8_inspector/V8HeapProfilerAgentImpl.cpp
[modify] https://crrev.com/33055dd442b76878063eff2385a27eb7604fbae6/third_party/WebKit/Source/platform/v8_inspector/V8ProfilerAgentImpl.cpp
[modify] https://crrev.com/33055dd442b76878063eff2385a27eb7604fbae6/third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.cpp
[modify] https://crrev.com/33055dd442b76878063eff2385a27eb7604fbae6/third_party/WebKit/Source/platform/v8_inspector/V8StackTraceImpl.cpp
[modify] https://crrev.com/33055dd442b76878063eff2385a27eb7604fbae6/third_party/WebKit/Source/platform/v8_inspector/V8StringUtil.cpp
[modify] https://crrev.com/33055dd442b76878063eff2385a27eb7604fbae6/third_party/WebKit/Source/web/InspectorOverlay.cpp

Comment 5 by noj...@gmail.com, Jul 15 2016

Wow that was so fast. Thanks Pavel.

I'll test this out tomorrow in the chromium nightly.

How often is node v8 inspector updated ?
Status: Fixed (was: Assigned)
Blocking: 580337

Sign in to add a comment