New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 628385 link

Starred by 3 users

Issue metadata

Status: Verified
Owner:
Last visit > 30 days ago
Closed: Sep 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

vt2 screen refresh is slow with an external monitor connected

Project Member Reported by steve...@chromium.org, Jul 14 2016

Issue description

On a samus device with an external monitor connected via a usb C -> displayport connector, the screen refresh of the vt2 terminal is once ever 2-3 seconds.

e.g. characters typed will not show up for several seconds.
'ping google.com' will show several lines of output ever few seconds instead of one line per second.

I have not tested this with other external display connectors yet.

 

Comment 1 by dbehr@chromium.org, Sep 2 2016

Owner: dbehr@chromium.org
Status: Assigned (was: Untriaged)

Comment 2 by dbehr@chromium.org, Sep 15 2016

Status: Started (was: Assigned)
Well, I do know what is the root cause of this issue.
PSR does not get reset when frecon sets video mode and external monitor is connected.
With single monitor PSR is disabled when fecpn does video mdoe st,

Comment 3 by dbehr@chromium.org, Sep 15 2016

Cc: ejcaruso@chromium.org
Well, it looks like this is the CL that broke it https://chromium-review.googlesource.com/241434

Setting psr.setup_done to false, prevents any future call to intel_edp_psr_update from doing anything useful. So when we switch video mode in frecon it psr status is not updated even though it should be.

This only happens with two monitors, because haswell_crtc_enable for 2nd monitor breaks psr.setup_done

I think if we need to force full psr setup on every enable, we shoult set psr.setup_done inside EDP section of intel_disable_ddi. This would guarantee it is called only once, when ddi is being disabled, not per crtc.
Project Member

Comment 4 by bugdroid1@chromium.org, Sep 21 2016

Labels: merge-merged-chromeos-3.14
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/kernel/+/017ef43878b593b64296fbe091cf949d106473e5

commit 017ef43878b593b64296fbe091cf949d106473e5
Author: Dominik Behr <dbehr@chromium.org>
Date: Thu Sep 15 22:47:22 2016

CHROMIUM: drm/i915: reset psr.setup_done in disable_ddi instead of crtc_enable

haswell_crtc_enable() is not a good place to reset psr.setup_done because
connecting 2nd monitor will trigger haswell_crtc_enable() for another crtc and
prevent intel_edp_psr_update() from working at all. PSR state is really associated
with EDP link, not with CRTC.

BUG= chromium:628385 
TEST=switch to VT2 with external monitor connected

Change-Id: Iabddd2d936d48e969a2ab7ec500187ac3e1a6072
Signed-off-by: Dominik Behr <dbehr@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/386158
Reviewed-by: Eric Caruso <ejcaruso@chromium.org>

[modify] https://crrev.com/017ef43878b593b64296fbe091cf949d106473e5/drivers/gpu/drm/i915/intel_display.c
[modify] https://crrev.com/017ef43878b593b64296fbe091cf949d106473e5/drivers/gpu/drm/i915/intel_ddi.c

Comment 5 by dbehr@chromium.org, Sep 27 2016

Status: Fixed (was: Started)

Comment 6 by dchan@chromium.org, Oct 7 2016

Labels: VerifyIn-55
Status: Verified (was: Fixed)

Sign in to add a comment