Crash when trying to show cert manager during kiosk launch |
||||
Issue descriptionNot 100% crash but happens pretty frequently while looking at issue 626147. Happens when when cert manager is requested after app profile is loaded and before we mark the session as a kiosk session. In such case, GetAppProfile [1] would return a NULL and cause the crash. [1]: https://cs.chromium.org/chromium/src/chrome/browser/chromeos/login/screens/error_screen.cc?rcl=1468509561&l=50 Stack: #0 0x00007f0342ba36e6 in content::SSLPolicyBackend::SSLPolicyBackend (this=0x2c60fd207e8, controller=0x2c60fd20790) at ../../content/browser/ssl/ssl_policy_backend.cc:15 15 controller->GetBrowserContext()->GetSSLHostStateDelegate()), (gdb) bt #0 0x00007f0342ba36e6 in content::SSLPolicyBackend::SSLPolicyBackend (this=0x2c60fd207e8, controller=0x2c60fd20790) at ../../content/browser/ssl/ssl_policy_backend.cc:15 #1 0x00007f0342ba232d in content::SSLManager::SSLManager (this=0x2c60fd207e0, controller=0x2c60fd20790) at ../../content/browser/ssl/ssl_manager.cc:103 #2 0x00007f0342a6595c in content::NavigationControllerImpl::NavigationControllerImpl (this=0x2c60fd20790, delegate=<optimized out>, browser_context=<optimized out>) at ../../content/browser/frame_host/navigation_controller_impl.cc:243 #3 0x00007f0342bc0585 in content::WebContentsImpl::WebContentsImpl (this=this@entry=0x2c60fd20700, browser_context=0x0) at ../../content/browser/web_contents/web_contents_impl.cc:428 #4 0x00007f0342bc0cf3 in content::WebContentsImpl::CreateWithOpener (params=..., opener=0x0) at ../../content/browser/web_contents/web_contents_impl.cc:543 #5 0x00007f0343dfcbac in views::WebView::CreateWebContents (this=<optimized out>, browser_context=0x0) at ../../ui/views/controls/webview/webview.cc:386 #6 0x00007f0343dfcc10 in views::WebView::GetWebContents (this=<optimized out>) at ../../ui/views/controls/webview/webview.cc:49 #7 0x00007f0343dfbb4a in views::WebDialogView::InitDialog (this=0x2c60fd1e780) at ../../ui/views/controls/webview/web_dialog_view.cc:354 #8 0x00007f034335356d in views::View::ViewHierarchyChangedImpl (this=0x2c60fd1e780, register_accelerators=<optimized out>, details=...) at ../../ui/views/view.cc:1886 #9 0x00007f0343354b14 in views::View::AddChildViewAt (this=0x2c61001a600, view=0x2c60fd1e780, index=<optimized out>) at ../../ui/views/view.cc:210 #10 0x00007f0343361f65 in views::NonClientView::ViewHierarchyChanged (this=0x2c60fd20790, details=...) at ../../ui/views/window/non_client_view.cc:197 #11 0x00007f034335356d in views::View::ViewHierarchyChangedImpl (this=0x2c61001a600, register_accelerators=<optimized out>, details=...) at ../../ui/views/view.cc:1886 #12 0x00007f0343354b14 in views::View::AddChildViewAt (this=this@entry=0x2c60fd1ea00, view=view@entry=0x2c61001a600, index=<optimized out>) at ../../ui/views/view.cc:210 #13 0x00007f0343354c50 in views::View::AddChildView (this=this@entry=0x2c60fd1ea00, view=view@entry=0x2c61001a600) at ../../ui/views/view.cc:157 #14 0x00007f0343357b4b in views::internal::RootView::SetContentsView (this=0x2c60fd1ea00, contents_view=0x2c61001a600) at ../../ui/views/widget/root_view.cc:195 #15 0x00007f034335a02d in views::Widget::SetContentsView (this=this@entry=0x2c60e17ec80, view=0x2c61001a600) at ../../ui/views/widget/widget.cc:462 #16 0x00007f034335c55e in views::Widget::Init (this=this@entry=0x2c60e17ec80, in_params=...) at ../../ui/views/widget/widget.cc:347 #17 0x00007f034335c8b6 in CreateWindowWithParentAndBounds (bounds=..., parent=0x2c60df85000, delegate=0x2c60fd1e998) at ../../ui/views/widget/widget.cc:197 #18 views::Widget::CreateWindowWithParent (delegate=delegate@entry=0x2c60fd1e998, parent=parent@entry=0x2c60df85000) at ../../ui/views/widget/widget.cc:185 #19 0x00007f03427cf07d in chrome::ShowWebDialog (parent=0x2c60df85000, context=0x0, delegate=delegate@entry=0x2c60fa011e0) at ../../chrome/browser/ui/views/chrome_web_dialog_view.cc:21 #20 0x00007f034372b9bc in chromeos::LoginWebDialog::Show (this=0x2c60fa011e0) at ../../chrome/browser/chromeos/login/ui/login_web_dialog.cc:65 #21 0x00007f0342585f7a in Run (args#0="configure-certs", this=0x2c60edccbb8) at ../../base/callback.h:389 #
,
Jul 18 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d4a1809baa06ab2824b5d732b7d1c1f45fe06660 commit d4a1809baa06ab2824b5d732b7d1c1f45fe06660 Author: xiyuan <xiyuan@chromium.org> Date: Mon Jul 18 17:09:23 2016 kiosk: Show network config UI after profile load BUG= 628379 Review-Url: https://codereview.chromium.org/2151113002 Cr-Commit-Position: refs/heads/master@{#406019} [modify] https://crrev.com/d4a1809baa06ab2824b5d732b7d1c1f45fe06660/chrome/app/chromeos_strings.grdp [modify] https://crrev.com/d4a1809baa06ab2824b5d732b7d1c1f45fe06660/chrome/browser/chromeos/login/app_launch_controller.cc [modify] https://crrev.com/d4a1809baa06ab2824b5d732b7d1c1f45fe06660/chrome/browser/chromeos/login/app_launch_controller.h [modify] https://crrev.com/d4a1809baa06ab2824b5d732b7d1c1f45fe06660/chrome/browser/chromeos/login/screens/app_launch_splash_screen_actor.h [modify] https://crrev.com/d4a1809baa06ab2824b5d732b7d1c1f45fe06660/chrome/browser/ui/webui/chromeos/login/app_launch_splash_screen_handler.cc
,
Jul 18 2016
,
Aug 2 2016
,
Sep 14 2016
Verified in build 8743.4.0, chromeos 54.0.2840.6 |
||||
►
Sign in to add a comment |
||||
Comment 1 by xiy...@chromium.org
, Jul 14 2016Status: Started (was: Assigned)