New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 628373 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: Aug 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Feature



Sign in to add a comment

Add option to libcontainer for pre-mounted runfs path

Project Member Reported by ashishgaurav@chromium.org, Jul 14 2016

Issue description

Add option to libcontainer for pre-mounted runfs path
 
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 4 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/0e4c3285f203402271c6a8df0fae8d2aec015049

commit 0e4c3285f203402271c6a8df0fae8d2aec015049
Author: Keshav Santhanam <ksanthanam@google.com>
Date: Thu Jul 14 17:25:16 2016

libcontainer: Add option for pre-mounted runfs path

This allows the user to specify a path for the directory
in which they want the container to run. It also allows
the user to specify the path to the pid file.

BUG= chromium:628373 
TEST=Create a directory, bind mount the container rootfs
to the new directory, use container_config_premounted_runfs
and container_config_pid_file_path.

Change-Id: I540700e529bbba8184dc17c0516ecc7ae7a6f793
Reviewed-on: https://chromium-review.googlesource.com/360580
Commit-Ready: Keshav Santhanam <ksanthanam@google.com>
Tested-by: Keshav Santhanam <ksanthanam@google.com>
Reviewed-by: Dylan Reid <dgreid@chromium.org>

[modify] https://crrev.com/0e4c3285f203402271c6a8df0fae8d2aec015049/libcontainer/libcontainer.c
[modify] https://crrev.com/0e4c3285f203402271c6a8df0fae8d2aec015049/libcontainer/libcontainer.h
[modify] https://crrev.com/0e4c3285f203402271c6a8df0fae8d2aec015049/libcontainer/libcontainer_unittest.c

Project Member

Comment 2 by bugdroid1@chromium.org, Aug 4 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/0e4c3285f203402271c6a8df0fae8d2aec015049

commit 0e4c3285f203402271c6a8df0fae8d2aec015049
Author: Keshav Santhanam <ksanthanam@google.com>
Date: Thu Jul 14 17:25:16 2016

libcontainer: Add option for pre-mounted runfs path

This allows the user to specify a path for the directory
in which they want the container to run. It also allows
the user to specify the path to the pid file.

BUG= chromium:628373 
TEST=Create a directory, bind mount the container rootfs
to the new directory, use container_config_premounted_runfs
and container_config_pid_file_path.

Change-Id: I540700e529bbba8184dc17c0516ecc7ae7a6f793
Reviewed-on: https://chromium-review.googlesource.com/360580
Commit-Ready: Keshav Santhanam <ksanthanam@google.com>
Tested-by: Keshav Santhanam <ksanthanam@google.com>
Reviewed-by: Dylan Reid <dgreid@chromium.org>

[modify] https://crrev.com/0e4c3285f203402271c6a8df0fae8d2aec015049/libcontainer/libcontainer.c
[modify] https://crrev.com/0e4c3285f203402271c6a8df0fae8d2aec015049/libcontainer/libcontainer.h
[modify] https://crrev.com/0e4c3285f203402271c6a8df0fae8d2aec015049/libcontainer/libcontainer_unittest.c

Comment 3 by dgreid@chromium.org, Aug 15 2016

Status: Verified (was: Started)

Sign in to add a comment