ElementVisiblityObserver creates a reference cycle with wrapWeakPersistent |
||
Issue descriptionAs pointed out here: https://codereview.chromium.org/2146383002/#msg12 ElementVisibilityObserver creates a non-garbage-collectable reference cycle by using wrapWeakPersistent. This leads to memory leaks in the tests (see crbug.com/627539 ).
,
Jul 18 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/df5e915f2075aa324e59087cfca9848b6ff3f58a commit df5e915f2075aa324e59087cfca9848b6ff3f58a Author: zqzhang <zqzhang@chromium.org> Date: Mon Jul 18 15:20:31 2016 Using wrapWeakPersistent for VisibilityCallback in HTMLMediaElement This is a test patch that fixes a memory leak caused by the reference between HTMLMediaElement and ElementVisibilityObserver. The previous patch breaks the reference cycle but seems doesn't fix the leak. Using WeakPersistent is a workaround, but seems does not fix the leak entirely. Keeping https://crbug.com/627539 open to keep track of the remaining leaks. BUG= 628367 , 627539 Review-Url: https://codereview.chromium.org/2151243002 Cr-Commit-Position: refs/heads/master@{#405996} [modify] https://crrev.com/df5e915f2075aa324e59087cfca9848b6ff3f58a/third_party/WebKit/Source/core/html/HTMLMediaElement.cpp
,
Jul 18 2016
There are some flaky leak remaining still. Since this crbug is more specific to WeakPersistent, let us move further discussions to the https://crbug.com/627539 |
||
►
Sign in to add a comment |
||
Comment 1 by mlamouri@chromium.org
, Jul 18 2016