New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 628342 link

Starred by 1 user
Status: Verified
Owner:
█ warx@chromium.org
Last visit > 30 days ago
Closed: Jul 2016
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

audio_manager_unittest fails in use_cras build condition because not updating tests with AudioDevice display_name

Project Member Reported by warx@chromium.org, Jul 14 2016 
I should update unittest with AudioDevice display_name in this https://codereview.chromium.org/2079843003/. Since trybot is not running USE_CRAS tests, it is not detected.
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 14 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/aff7677aba5777c766d7d5a57a77ad71cbb6ff24

commit aff7677aba5777c766d7d5a57a77ad71cbb6ff24
Author: warx <warx@chromium.org>
Date: Thu Jul 14 21:34:37 2016

Fix audio_manager_unittest should update with AudioDevice display_name

In later patch of https://codereview.chromium.org/2079843003/, I update the code to display AudioDevice display_name. But I forget to update the unittest. Since try server is not running in USE_CRAS, it is not detected.

BUG= 628342 
TEST=run in USE_CRAS building condition, it returns to work fine.

Review-Url: https://codereview.chromium.org/2150983003
Cr-Commit-Position: refs/heads/master@{#405579}

[modify] https://crrev.com/aff7677aba5777c766d7d5a57a77ad71cbb6ff24/media/audio/audio_manager_unittest.cc

Comment 2 by warx@chromium.org, Jul 14 2016

Status: Fixed (was: Assigned)

Comment 3 by patricia@chromium.org, Aug 29 2016

Labels: VerifyIn-54

Comment 4 by patricia@chromium.org, Aug 29 2016

Status: Verified (was: Fixed)
bulk verified
►

Sign in to add a comment