Create 1.5X icons for CoreUI and omnibox |
|||||||
Issue descriptionThis is a common DSF for Windows now, let's support it fully. See also https://docs.google.com/presentation/d/1UhaA_YtZ6lOqkSXyJyqnLm3sUlMGfBvwsMf0OsB_Cao/edit#slide=id.g15410670a2_0_68
,
Jul 14 2016
Depends what icons you are talking about Evan. Most of the icons were deliver in 1x and 2x because we wanted them to be different from 1x an 2x.
,
Jul 14 2016
+bettes@
,
Jul 18 2016
I agree with Evan. The specific example of needing a 1.5x version given so far was the omnibox lock, but that turns out to be because it was designed assuming a particular font baseline, which the icon designer can't assume. Such an icon should be redesigned to simply scale correctly and then we should be asked to position it appropriately programmatically. I'm already unhappy with how many icons are different between 1x and 2x, and the idea of adding yet more for 1.5x is distasteful. Note that 1.5x is far from the only non-integral scale factor used. 1.25x, 1.4x, 1.75x, and 1.8x are also possible. Probably in the future yet more will be possible, especially higher values like 3x and 4x. It's simply not scalable to try and have different icons for every different factor, and icons optimized specifically for 1x or 2x aren't necessarily going to look good scaled. We need to be designing icons that either work at all scale factors, or at least can cover whole ranges of scales with one icon.
,
Jul 18 2016
It's not possible to design an icon that scales well at 1.25, 1.5, 1.75, 1.8, 2 and 3. We will get blurriness and we need to be ok with that. If not, we need to be ok with getting icons per multiplier. Beyond this, the reason why we have different 1x and 2x is because we want different rendering per multiplier. If we used a scalable version from 1x to 2x, the icons wouldn't be looking as elegant as we want them to get. For the omnibox, my assumption is that a scaled icon wouldn't look as nice as what max did and that programmatic alignment to baseline might not work with another icon because it might look misaligned depending on the size of the icon. I'm happy with the current state personally. We have great rendering at 1x and 2x we have blurriness on icons in 1.5 but for me the ommibox and tab rendering issues are more prominent on this multiplier.
,
Jul 18 2016
I don't think anyone's asking for perfection at 1.25, 1.75 or 1.8, at least not until a lot of users are on those scale factors. I agree that designing an icon to look good at arbitrary scale factors is very hard. But I wouldn't think it's impossible to design a single icon to cover 2x and 1.5x (depending on the icon). And if you just design for 2x and 1.5x then you get 3x for "free" (in the sense that you're guaranteed there won't be blurriness).
,
Jul 18 2016
It is not. if you have a 2pt line weight on 1x, which is what we use, you get 3px on 1.5x. Problem is measurement of the chrome UI are aligned on even number, therefore, if you have a central line, like on the back button, it will be aligned halfway. Plus 2pt line weight look chubby on 2x so what I did is creating 2x specific icons that have a 3px line weight. Same principle for the overall UI. See the image attached for context. if we were lazy, we absolutely could have 1 scalable resource for everything but it would: - Still be blurry on non-integral scale factors - Would look worse on 2x scale factor. unless you thing "2x - scaled - 2pt line weight" is looking better than " 2x - custom icons (today)"
,
Jul 21 2016
,
Jul 21 2016
So it seems like pkasting, sgabriel and myself are all against creating additional assets (for various reasons). Depending on the priority of this issue, maybe we should have a meeting to discuss options?
,
Mar 7 2017
This bug appeared in my "random available omnibox bugs" list today. Is there something we should do with it? Close?
,
Mar 7 2017
I'm assigning to Max to evaluate the state of the world today w.r.t. 1.5x and decide if we're happy with what we have or need to take action here.
,
Mar 7 2017
if we decide we need this we probably should address bug 647286
,
Jun 16 2017
Actually assigning to Max per comment #11 ("to evaluate the state of the world today w.r.t. 1.5x and decide if we're happy with what we have or need to take action here.")
,
Jul 12 2017
maxwalker: can you respond to the question in #11?
,
Dec 12 2017
,
Dec 15 2017
Scaling the 1x toolbar icons (back, forward, reload) to 1.5x results in icons with 3px line weight which is generally what we want. However, these 1.5x icons look blurry since they aren't aligned with the pixel grid anymore. Would it be possible to programmatically shift the icons by 0.5px? That would give us sharp toolbar icons at 1.5x without creating additional icons assets.
,
Dec 15 2017
Would that give us correct results though? Wouldn't the padding be uneven? (e.g. 2px on the left and 1px on the right)
,
Dec 18 2017
Yes, however this is what we already do for 2x icons (since it's impossible to center a 3px line in a 48px square) and seems acceptable to me.
,
Dec 18 2017
In that case yes, it's possible to do this on our end, but someone will need to do the work to make it happen.
,
Mar 7 2018
maxwalker@ provided the needed feedback. Marking as available. |
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by est...@chromium.org
, Jul 14 2016