New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 628330 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Aug 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug



Sign in to add a comment

Figure out what a WebAPK should do when host browser is uninstalled

Project Member Reported by pkotw...@chromium.org, Jul 14 2016

Issue description

Currently, if loading the runtime library fails we launch the host browser in tabbed mode. We need to handle the case of launching a WebAPK when Chrome has been uninstalled
 
We have a couple of options
1) try loading the webpage using default browser
2) have a prompt and redirect to play.
3) webview

I'd opt for (2) as we've determined that it makes sense for the webapk to be bound to the installing browser.
Owner: pkotw...@chromium.org
Status: Assigned (was: Untriaged)
Status: Started (was: Assigned)
Cc: sbirch@chromium.org
Sam, what do you think we should do when the a user launches a WebAPK but the user has uninstalled Chrome. Yaron suggested showing an alert. What should the alert say?

One annoying thing about displaying an alert is that it means that the WebAPK will now have string resources which need to be translated. Adding strings for all of the languages that Chrome supports increases the WebAPK size as well
Cc: rolfe@chromium.org owe...@chromium.org
The issue with some kind of alert is that we also don't currently have a noun to describe the thing you've installed.

I'm tempted to just send a generic VIEW intent to be resolved by the user's default browser / browser of choice.

+rolfe, owencm -- sound reasonable?
Talked to rolfe@ off-thread. She pointed out that the user might not have *any* browser installed.

And the specified behavior in that case is actually to crash. (https://developer.android.com/training/basics/intents/sending.html#Verify)

So that puts us in sort of a tight spot:
(1) We don't want to include a string for the sake of binary size and because we don't have a noun to describe the thing you've installed.
(2) We can't dependably send the user to a browser, because we'll crash if there aren't any.
(3) I think sending you directly to the Play Store to install Chrome without some explanation (requiring (1)) is pretty confusing.

Of the 3, I think (2) is probably the most sensible though because it preserves most of the functionality. The case where the user has no browser at all is a crazy edge case, but maybe if we check and can't find a browser we can fall back to (3).

So I'll amend the proposal. When Chrome isn't installed:

- Send a generic VIEW intent if there's at least one app which can handle it
- Otherwise, open Play to install Chrome

Thoughts?
I think that the proposal in #6 is reasonable. I think that it doesn't matter what we do when Chrome is uninstalled as long as we do *something*

I am not a UX designer though

Comment 8 by rolfe@chromium.org, Aug 5 2016

I *am* a UX designer and am probably no better equipped to know what to do here! The proposal in comment 6 sounds reasonable to me as well. I suspect it's an very slim edge case in general, but if there's a way to track if it becomes an increasing problem that would be helpful to know whether to revisit. But for now doesn't seem like a ton of options.
Meta-point: From the users's pov, I think in this context it would be safe to call it an "app". They're clicking on a shortcut on launcher, all apps, etc. There aren't really other options. 

Tracking is non-trivial so I don't think we should bother.

Project Member

Comment 10 by bugdroid1@chromium.org, Aug 22 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6dd8ec1011f388ec2fe710f4b4458fcf8d39903a

commit 6dd8ec1011f388ec2fe710f4b4458fcf8d39903a
Author: pkotwicz <pkotwicz@chromium.org>
Date: Mon Aug 22 21:00:38 2016

[WebAPK] Launch Play Store if the user does not have any web browsers installed

This CL:
- Tries to launch any web browser if launching the WebAPK fails
- Launches the Play Store to install the host browser if the user does not have any
  web browsers installed

BUG= 628330 

Review-Url: https://codereview.chromium.org/2183993002
Cr-Commit-Position: refs/heads/master@{#413530}

[modify] https://crrev.com/6dd8ec1011f388ec2fe710f4b4458fcf8d39903a/chrome/android/webapk/shell_apk/BUILD.gn
[add] https://crrev.com/6dd8ec1011f388ec2fe710f4b4458fcf8d39903a/chrome/android/webapk/shell_apk/junit/src/org/chromium/webapk/shell_apk/MainActivityTest.java
[modify] https://crrev.com/6dd8ec1011f388ec2fe710f4b4458fcf8d39903a/chrome/android/webapk/shell_apk/src/org/chromium/webapk/shell_apk/MainActivity.java

Status: Fixed (was: Started)

Sign in to add a comment