Incorrect visual rects for flipped-block ruby text with html element 'writing-mode: vertical-rl' |
||
Issue description
Attached test case reduced from:
fast/writing-mode/japanese-ruby-vertical-rl.html
Note cull rect vs visual rect difference for 'c':
{index: 2, client: "0x6d62e844010 InlineTextBox 'c'", type: "DrawingPaintPhaseForeground", rect: [776.000000,12.000000 16.000000x8.000000], cacheIsValid: true, visualRect: [742,12 16x8]},
Failure mode appears specific to having writing-mode on the html element. Issue does not occur if writing mode is on a containing div.
,
Jul 18 2016
Brief update -- https://codereview.chromium.org/2150143002 was in flight but paused while chrishtr@ works on other revisions to how we handle flipping for LayoutInline, as fallout from investigating other tests. See for example: https://codereview.chromium.org/2154913002/
,
Jul 20 2016
Copying from crbug.com/616600 as they're specific to this: These ruby tests are still failing at ToT with rtree patch: fast/ruby/overhang-vertical.html fast/ruby/overhang-vertical-no-overlap1.html fast/ruby/overhang-vertical-no-overlap2.html fast/writing-mode/japanese-ruby-vertical-rl.html https://storage.googleapis.com/chromium-layout-test-archives/linux_blink_rel/88537/layout-test-results/results.html fast/writing-mode/Kusa-Makura-background-canvas.html is also failing on Mac only for some reason, looks like similar Ruby issue: https://storage.googleapis.com/chromium-layout-test-archives/mac_blink_rel/68061/layout-test-results/results.html
,
Jul 21 2016
Update -- https://codereview.chromium.org/2166923004 patch set 1 fixes all issues (have not confirmed Mac test but expect it would work as well). However, we are debating via patch set 2 and investigation whether there is an alternate cleaner approach that is still fully correct. Investigation continues.
,
Jul 27 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d32d77e91cb77d625275c21b29ec41064f8ccab2 commit d32d77e91cb77d625275c21b29ec41064f8ccab2 Author: wkorman <wkorman@chromium.org> Date: Wed Jul 27 03:04:46 2016 Fix Ruby visual rects in flipped blocks writing mode. BUG= 628323 Review-Url: https://codereview.chromium.org/2166923004 Cr-Commit-Position: refs/heads/master@{#408030} [modify] https://crrev.com/d32d77e91cb77d625275c21b29ec41064f8ccab2/third_party/WebKit/LayoutTests/TestExpectations [add] https://crrev.com/d32d77e91cb77d625275c21b29ec41064f8ccab2/third_party/WebKit/LayoutTests/paint/invalidation/ruby-flipped-blocks-expected.png [add] https://crrev.com/d32d77e91cb77d625275c21b29ec41064f8ccab2/third_party/WebKit/LayoutTests/paint/invalidation/ruby-flipped-blocks-expected.txt [add] https://crrev.com/d32d77e91cb77d625275c21b29ec41064f8ccab2/third_party/WebKit/LayoutTests/paint/invalidation/ruby-flipped-blocks.html [modify] https://crrev.com/d32d77e91cb77d625275c21b29ec41064f8ccab2/third_party/WebKit/Source/core/layout/LayoutBox.cpp [modify] https://crrev.com/d32d77e91cb77d625275c21b29ec41064f8ccab2/third_party/WebKit/Source/core/layout/LayoutInline.cpp
,
Jul 27 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3018755efe9e8c1393205bd94a51603c6ab6a945 commit 3018755efe9e8c1393205bd94a51603c6ab6a945 Author: Rebaseline Bot <blink-rebaseline-bot@chromium.org> Date: Wed Jul 27 04:31:46 2016 Auto-rebaseline for r408030 https://chromium.googlesource.com/chromium/src/+/d32d77e91 BUG= 628323 TBR=wkorman@chromium.org Review URL: https://codereview.chromium.org/2183123003 . Cr-Commit-Position: refs/heads/master@{#408041} [modify] https://crrev.com/3018755efe9e8c1393205bd94a51603c6ab6a945/third_party/WebKit/LayoutTests/TestExpectations
,
Jul 27 2016
|
||
►
Sign in to add a comment |
||
Comment 1 by wkorman@chromium.org
, Jul 14 2016100 bytes
100 bytes View Download