New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 628312 link

Starred by 42 users

Issue metadata

Status: Fixed
Owner:
Closed: Jul 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 2
Type: Bug



Sign in to add a comment

White line between url bar and content when using dark theme

Reported by dam...@dam.io, Jul 14 2016

Issue description

UserAgent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/53.0.2783.2 Safari/537.36

Steps to reproduce the problem:
1. use a dark theme like https://chrome.google.com/webstore/detail/developer-edition-dark/lglfmldlfmbbehalkgiglehhjblbfcjo
2. open page with dark background like imgur.com
3. see white bar between content and top bar: https://i.imgur.com/HDilG8L.png

What is the expected behavior?
No white bar or something less obstrusive

What went wrong?
White bar is extremely visible, especially in incognito mode there's two white bars: https://i.imgur.com/nBUVaqq.png

Did this work before? N/A 

Chrome version: 53.0.2783.2  Channel: n/a
OS Version: 
Flash Version: Shockwave Flash 22.0 r0
 
Components: -UI UI>Browser>Themes
Labels: OS-Mac
Status: Available (was: Unconfirmed)
Confirmed that this also happens on mac
Screen Shot 2016-07-19 at 11.58.17 AM.png
32.9 KB View Download
I also have this problem and i've tried several different chrome themes and several different windows 10 themes.
60d3934938[1].png
6.8 KB View Download
Same, and it's pretty annoying. 
How do you add Windows to the OS: line on this Issue?
Labels: OS-Windows
#4 Added
Version 57.0.2933.0 (64-bit)

the latest chromium update seems to have added more lines to the address bar
c1357d45a5[1].png
4.8 KB View Download

Comment 7 Deleted

Version 55.0.2883.87 m (64-bit)

Just reporting that it still remains an issue as of 1/12/2017, tested and consistent across just about every dark theme.

Comment 9 by est...@chromium.org, Jan 13 2017

Owner: est...@chromium.org
Status: Started (was: Available)
Cc: thomasanderson@chromium.org est...@chromium.org e...@chromium.org
 Issue 685446  has been merged into this issue.
I personally would like the separator color to be changeable in the specific them. For me i would like it to be completely black #000 since i have no use for the separator at all 
Is there ANY possibility to code this ugly line away? (manifest.json or how ever)

snip_20170321231905.png
11.5 KB View Download
Also, on Linux when using Adwaita+Gtk3, the dark separator is lightened so that it's about the same color as the toolbar, making it appear invisible.
Screenshot from 2017-03-22 15:33:16.png
16.3 KB View Download
I really hope this gets fixed
Project Member

Comment 15 by bugdroid1@chromium.org, Jun 17 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/eba855f22deff3a00b76384582808925841f4be5

commit eba855f22deff3a00b76384582808925841f4be5
Author: Evan Stade <estade@chromium.org>
Date: Sat Jun 17 02:49:43 2017

Try to improve toolbar separator coloration for themed browser windows.
Particularly noticeable for dark themes.

Bug:  628312 
Change-Id: I16dd1634a063202c6ea1d640a1d80e5c35e8fe56
Reviewed-on: https://chromium-review.googlesource.com/534833
Commit-Queue: Evan Stade <estade@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#480275}
[modify] https://crrev.com/eba855f22deff3a00b76384582808925841f4be5/chrome/browser/themes/theme_properties.cc
[modify] https://crrev.com/eba855f22deff3a00b76384582808925841f4be5/chrome/browser/themes/theme_service.cc
[modify] https://crrev.com/eba855f22deff3a00b76384582808925841f4be5/chrome/browser/ui/libgtkui/gtk_ui.cc
[modify] https://crrev.com/eba855f22deff3a00b76384582808925841f4be5/chrome/browser/ui/views/frame/browser_view.cc

Comment 16 Deleted

Is there really no way to get rid of the white line in an "easy" way? For example making the line black or dark grey, according to the theme color.

Comment 18 Deleted

Cc: rbasuvula@chromium.org
Labels: Needs-Feedback
Tested the issue on Windows-10, Ubuntu 14.04 and Mac OS 10.12.5 using chrome latest Dev M61-61.0.3135.4 by following steps mentioned in the original comment. Observed that able to see the white bar in incognito mode in all OS.

@estade: Could you please let me know if i have missed anything.Please find the screen shot for reference.

Thank you!

628312.png
234 KB View Download
re #19: you'd want to test on imgur.com, not the new tab page, and my fix only applies to Views platforms (win/chromeos/linux).
any news on that issue?
snip_20170705221814.png
7.5 KB View Download
this issue is now fixed for me in Chromium Version 61.0.3145.0 on windows 10
9138af2c24[1].png
6.7 KB View Download
finally 

Comment 24 Deleted

Why is this not implemented in chrome? is there hope? =)
Status: Fixed (was: Started)
this is fixed, except maybe not on mac. Filed bug 749732 for that.
I mean google chrome, not chromium :)

There is not a distinction between the two in this context. It's fixed in Chrome, but it takes some time for changes to trickle out to users via the release process, so you would see it fixed in a recent canary build but not yet stable.
The same issue still exists on the download bar.
Chromium.png
19.0 KB View Download
wisteriacoffee@: Thanks for your comment. This issue is already closed. Please open a new bugreport, if you see any issues. Thanks.

Sign in to add a comment