New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 628308 link

Starred by 1 user
Status: Fixed
Owner:
haraken@chromium.org
Closed: Jul 2016
Cc:
█ junov@chromium.org
█ xlai@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug



Sign in to add a comment

Layout Test virtual/gpu/fast/canvas/canvas-toBlob-toDataURL-race-imageEncoder-jpeg.html is flaky

Project Member Reported by wjmaclean@chromium.org, Jul 14 2016 
The following layout test is flaky on WebKit Linux Leak

virtual/gpu/fast/canvas/canvas-toBlob-toDataURL-race-imageEncoder-jpeg.html

Probable cause:

It looks like https://codereview.chromium.org/2143353002 could be related, but please re-assign (and help find a new owner) if this is not the case.

Thanks!

Comment 1 by wjmaclean@chromium.org, Jul 14 2016 

Also seems like the following tests are affected:

virtual/gpu/fast/canvas/canvas-toBlob-jpeg-maximum-quality.html
virtual/gpu/fast/canvas/canvas-toBlob-jpeg-medium-quality.html
virtual/threaded/fast/canvas-toBlob/canvas-toBlob-file-vs-blob.html

Comment 2 by wjmaclean@chromium.org, Jul 14 2016 

Also seems to be on WebKit Linux Leak

Comment 3 by senorblanco@chromium.org, Jul 14 2016

Cc: xlai@chromium.org junov@chromium.org

Comment 4 by xlai@chromium.org, Jul 14 2016

Status: Assigned (was: Untriaged)
If this only happens on the WebKit Leak bot, then I think one possible reason is that the new m_document introduced in CL 2143353002 is not eagerly let go of references in dispose(), thereby causing retention of resources when toBlob is done but the timeout events are still queued on main thread. The reason why it is flaky is that sometimes the timeout events get triggered before toBlob is done.

I'm trying to see if this small change (https://codereview.chromium.org/2149233004) can fix the flakiness.
Project Member

Comment 5 by bugdroid1@chromium.org, Jul 14 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/20989491201825820c93697de6d92d3b148b10b5

commit 20989491201825820c93697de6d92d3b148b10b5
Author: xlai <xlai@chromium.org>
Date: Thu Jul 14 23:23:05 2016

Fix flaky toBlob tests

Some layout tests are flaky on WebKit Leak bot due to m_document introduced to
CanvasAsyncBlobCreator in https://codereview.chromium.org/2143353002.

TBR=haraken@chromium.org
BUG= 628308 

Review-Url: https://codereview.chromium.org/2149233004
Cr-Commit-Position: refs/heads/master@{#405622}

[modify] https://crrev.com/20989491201825820c93697de6d92d3b148b10b5/third_party/WebKit/Source/core/html/canvas/CanvasAsyncBlobCreator.cpp

Comment 6 by xlai@chromium.org, Jul 15 2016

Status: Fixed (was: Assigned)
The toBlob tests on WebKit Linux Leak pass now.
►

Sign in to add a comment