New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 628280 link

Starred by 1 user

Issue metadata

Status: Duplicate
Merged: issue 628268
Owner:
Last visit > 30 days ago
Closed: Jul 2016
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

4.2%-174% regression in system_health.memory_desktop at 405221:405282

Project Member Reported by petrcermak@chromium.org, Jul 14 2016

Issue description

See the link to graphs below.
 
Project Member

Comment 3 by 42576172...@developer.gserviceaccount.com, Jul 14 2016


===== BISECT JOB RESULTS =====
Status: completed


=== Bisection aborted ===
The bisect was aborted because The metric values for the initial "good" and "bad" revisions do not represent a clear regression.
Please contact the the team (see below) if you believe this is in error.

=== Warnings ===
The following warnings were raised by the bisect job:

 * Bisect failed to reproduce the regression with enough confidence.

===== TESTED REVISIONS =====
Revision         Mean     Std Dev  N   Good?
chromium@405220  3281237  1300712  12  good
chromium@405267  4017664  1136593  8   bad

Bisect job ran on: android_s5_perf_bisect
Bug ID: 628280

Test Command: src/tools/perf/run_benchmark -v --browser=android-chromium --output-format=chartjson --upload-results --also-run-disabled-tests system_health.memory_mobile
Test Metric: load_news-memory:chrome:all_processes:reported_by_os:system_memory:ashmem:private_dirty_size_avg/load_news_wikipedia
Relative Change: 16.87%
Score: 0

Buildbot stdio: http://build.chromium.org/p/tryserver.chromium.perf/builders/android_s5_perf_bisect/builds/793
Job details: https://chromeperf.appspot.com/buildbucket_job_status/9007143576701609936


Not what you expected? We'll investigate and get back to you!
  https://chromeperf.appspot.com/bad_bisect?try_job_id=5800278998122496

| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Tests>AutoBisect.  Thank you!
Project Member

Comment 6 by 42576172...@developer.gserviceaccount.com, Jul 15 2016


===== BISECT JOB RESULTS =====
Status: completed


=== Bisection aborted ===
The bisect was aborted because The metric values for the initial "good" and "bad" revisions do not represent a clear regression.
Please contact the the team (see below) if you believe this is in error.

=== Warnings ===
The following warnings were raised by the bisect job:

 * Bisect failed to reproduce the regression with enough confidence.

===== TESTED REVISIONS =====
Revision         Mean    Std Dev  N   Good?
chromium@405220  7207.0  689.255  12  good
chromium@405268  7207.0  705.475  8   bad

Bisect job ran on: android_s5_perf_bisect
Bug ID: 628280

Test Command: src/tools/perf/run_benchmark -v --browser=android-chromium --output-format=chartjson --upload-results --also-run-disabled-tests system_health.memory_mobile
Test Metric: load_media-memory:chrome:all_processes:reported_by_chrome:dom_storage:effective_size_avg/load_media_flickr
Relative Change: 0.00%
Score: 0

Buildbot stdio: http://build.chromium.org/p/tryserver.chromium.perf/builders/android_s5_perf_bisect/builds/798
Job details: https://chromeperf.appspot.com/buildbucket_job_status/9007064641840147456


Not what you expected? We'll investigate and get back to you!
  https://chromeperf.appspot.com/bad_bisect?try_job_id=5029451016962048

| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Tests>AutoBisect.  Thank you!
Project Member

Comment 9 by 42576172...@developer.gserviceaccount.com, Jul 19 2016

Mergedinto: 628268
Status: Duplicate (was: Assigned)

===== BISECT JOB RESULTS =====
Status: completed


===== SUSPECTED CL(s) =====
Subject : Add benchmark that imitates news reading.
Author  : ulan
Commit description:
  
Each story in the benchmark does the following:
1. Load the main page.
2. Open and scroll the first news item.
3. Go back to the main page and scroll it.
4. Open and scroll the second news item.
5. Go back to the main page and scroll it.
6. etc.

This workflow is interesting because it is close to real world
and generates a lot of garbage by creating and discarding pages.

A couple of websites crash with OOM on svelte device, so by
tracking and optimizing for this benchmark we can improve
user experience on low-memory devices.

*** NOTE TO SHERRIF ***
Regressions are expected in system_health.memory_mobile and
system_health.memory_desktop for the following stories:
- load:news:cnn
- load:social:facebook
- load:news:qq
- load:news:reddit
- load:social:twitter

If there are failing tests in form of benchmarks.system_health_smoke_test.SystemHealthBenchmarkSmokeTest.*
please do not revert this CL but instead disabling failing
test by adding them into the _DISABLE_TESTS list in
tools/perf/benchmarks/system_health_smoke_test.py

BUG=589726
CQ_INCLUDE_TRYBOTS=tryserver.chromium.perf:android_s5_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq

Review-Url: https://codereview.chromium.org/2118293002
Cr-Commit-Position: refs/heads/master@{#405212}
Commit  : 5b1847df818e5be4592e9a6ac4832350bb663023
Date    : Wed Jul 13 17:39:28 2016


===== TESTED REVISIONS =====
Revision         Mean     Std Dev  N  Good?
chromium@405136  1263269  16794.2  5  good
chromium@405211  1275222  841.302  5  good
chromium@405212  1312805  21090.1  5  bad    <--
chromium@405213  1327688  0.0      5  bad
chromium@405214  1328322  1336.44  5  bad
chromium@405217  1327688  0.0      5  bad
chromium@405222  1320400  17168.0  5  bad
chromium@405232  1313376  21602.4  5  bad
chromium@405248  1304902  20800.3  5  bad
chromium@405282  1328302  841.302  5  bad

Bisect job ran on: winx64intel_perf_bisect
Bug ID: 628280

Test Command: src/tools/perf/run_benchmark -v --browser=release_x64 --output-format=chartjson --upload-results --also-run-disabled-tests system_health.memory_desktop
Test Metric: load_social-memory:chrome:all_processes:reported_by_chrome:sqlite:effective_size_avg/load_social_pinterest
Relative Change: 5.15%
Score: 99.9

Buildbot stdio: http://build.chromium.org/p/tryserver.chromium.perf/builders/winx64intel_perf_bisect/builds/1025
Job details: https://chromeperf.appspot.com/buildbucket_job_status/9006787761553402896


Not what you expected? We'll investigate and get back to you!
  https://chromeperf.appspot.com/bad_bisect?try_job_id=5781434896220160

| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Tests>AutoBisect.  Thank you!
Labels: SystemHealth-Sheriff
Labels: -Performance-Sheriff

Sign in to add a comment