New issue
Advanced search Search tips

Issue 628273 link

Starred by 3 users

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Gerrit git cl desc: update shadow commit

Project Member Reported by tandrii@chromium.org, Jul 14 2016

Issue description

repro:
git nb A1
git commit -m "a1"
git cl upload

git tb A2
git commit -m "a2"
git cl upload

# Everything correct with dependencies

git co A1
git cl desc   # change a1 to whatever.

# Gerrit says A2 should be rebased. OK, so let's try:
git co A2
git pull
git cl upload
# but uploads with parent commit being local commit of A1 with wrong description
# so Gerrit still says it should be rebased. 



So, Gerrit is right. git cl desc is not!
 
Labels: Pri-2
Labels: Type-Bug
Status: Available (was: Untriaged)
Cc: tandrii@chromium.org
Labels: -Pri-2 Pri-1
Sadly this is non trivial, but nevertheless important.
Cc: rmis...@chromium.org
Labels: Milestone-Dogfood
Labels: Pri-2
If this is really a Pri-1, find an owner and update the priority.

This is the result of a bulk edit that moved high priority available bugs to a lower priority in an attempt to be more honest with bug filers.

Comment 7 by aga...@chromium.org, Mar 27 2017

Labels: -Milestone-Dogfood Milestone-Launch
This is a pretty obscure corner case. It is related to the case of the user editing the description in the UI, although in that case I think it is more reasonable to expect the user to realize that they need to click the "Rebase" button instead of doing something on the local command line.

Anyway, not a dogfood blocker, but should be revisited before launch.
Labels: -Milestone-Launch Milestone-Afterglow
Project Member

Comment 9 by sheriffbot@chromium.org, Jun 7 2018

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Hotlist-Recharge-Cold
Status: Available (was: Untriaged)
Fairly certain this is still the case, though I personally learned to live & ignore this bug.

Sign in to add a comment