New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 628266 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Jul 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

LayoutTests/compositing/canvas-with-object-fit-contain-in-composited-layer.html is flaky

Project Member Reported by wjmaclean@chromium.org, Jul 14 2016

Issue description

Cc: shivami...@gmail.com
Components: Tests>Flaky
Labels: -Pri-2 Pri-3
Owner: junov@chromium.org
Status: Assigned (was: Untriaged)
Flaked again just now.

"Test passes if a green square inside an orange rectangle shows up without distortion."

https://storage.googleapis.com/chromium-layout-test-archives/WebKit_Linux/67959/layout-test-results/results.html

It appears sometimes there is distortion.

10:01:22.496 20375 [18/168] compositing/canvas-with-object-fit-contain-in-composited-layer.html failed unexpectedly (reference mismatch)
10:01:22.488 17879 worker/1 compositing/canvas-with-object-fit-contain-in-composited-layer.html failed:
10:01:22.488 17879 worker/1  reference mismatch

Assigning to the reviewer of the change that added the test, as the original change author has not acted.

Comment 2 by junov@chromium.org, Jul 25 2016

That flake is such a tiny little glitch, not even visible to the naked eye.  Looks like an antialiasing or filtering artifact.  I think the fix is to make this into a test that does not need to downscale.
Project Member

Comment 3 by bugdroid1@chromium.org, Jul 25 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/74479a00220864f48aaaa78ac0e12c78aaa5e9fd

commit 74479a00220864f48aaaa78ac0e12c78aaa5e9fd
Author: junov <junov@chromium.org>
Date: Mon Jul 25 20:13:54 2016

Make compositing/canvas-with-object-fit-contain-in-composited-layer.html less flaky

Modified layout test to make it less sensitive to anti-aliasing/blending
precision issues to prevent bogus flakiness.

BUG= 628266 

Review-Url: https://codereview.chromium.org/2179913002
Cr-Commit-Position: refs/heads/master@{#407558}

[modify] https://crrev.com/74479a00220864f48aaaa78ac0e12c78aaa5e9fd/third_party/WebKit/LayoutTests/compositing/canvas-with-object-fit-contain-in-composited-layer-expected.html
[modify] https://crrev.com/74479a00220864f48aaaa78ac0e12c78aaa5e9fd/third_party/WebKit/LayoutTests/compositing/canvas-with-object-fit-contain-in-composited-layer.html

Comment 4 by junov@chromium.org, Jul 26 2016

Status: Fixed (was: Assigned)
Labels: hotlist-infra-opportunity

Sign in to add a comment