Issue metadata
Sign in to add a comment
|
Regression: Unnecessary hover effect remains on chevron icon.
Reported by
dmascare...@etouch.net,
Jul 14 2016
|
||||||||||||||||||||||
Issue descriptionChrome Version: 54.0.2796.2 (Official Build) 677b7ff9c1739954e09b0bea21d75cdd1911d062-refs/branch-heads/2796@{#3} OS: Mac Pro (10.10.5,10.11.4),Mac Retina(10.11.4) What steps will reproduce the problem? 1. Launch chrome and bookmark 8-10 webpage such that chevron icon appears on the bookmark bar. 2. Double click on chevron icon and observe. Actual: Unnecessary hover effect remains on chevron icon. Expected: Hover effect highlight should not be seen after step 2. This is regression issue, broken in ‘M 53’ and below is narrow bisect: https://chromium.googlesource.com/chromium/src/+log/89f7b5aa70aefa623f67b4adf8964308aadc9b82..f3dd9f40653004de3cf212352b2e22a11af8bdee?pretty=fuller&n=1000 Suspecting: r401167 Good build:53.0.2774.0 Bad build:53.0.2776.0 Note: Above issue is not reproducible on Windows and Linux OS.
,
Jul 20 2016
,
Jul 22 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1078d2565c0bc53dd9ef982d246fd9ac3dd49309 commit 1078d2565c0bc53dd9ef982d246fd9ac3dd49309 Author: spqchan <spqchan@chromium.org> Date: Fri Jul 22 03:37:26 2016 [Material][Mac] Fixed Bookmark Items Highlight Issues Remove calls to setHighlighted: for MD bookmark items. Ensure that the items aren't highlighted when they are not enabled BUG= 627722 , 628187 , 628204 Review-Url: https://codereview.chromium.org/2169623002 Cr-Commit-Position: refs/heads/master@{#407032} [modify] https://crrev.com/1078d2565c0bc53dd9ef982d246fd9ac3dd49309/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.mm [modify] https://crrev.com/1078d2565c0bc53dd9ef982d246fd9ac3dd49309/chrome/browser/ui/cocoa/bookmarks/bookmark_button.mm [modify] https://crrev.com/1078d2565c0bc53dd9ef982d246fd9ac3dd49309/chrome/browser/ui/cocoa/gradient_button_cell.mm
,
Jul 22 2016
,
Jul 25 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a86349d887b4000f625354c9d6ce396517947729 commit a86349d887b4000f625354c9d6ce396517947729 Author: spqchan <spqchan@chromium.org> Date: Mon Jul 25 17:57:48 2016 [Material][Mac] Fixed Bookmark Items Highlight Issues Remove calls to setHighlighted: for MD bookmark items. Ensure that the items aren't highlighted when they are not enabled BUG= 627722 , 628187 , 628204 Review-Url: https://codereview.chromium.org/2169623002 Cr-Commit-Position: refs/heads/master@{#407032} (cherry picked from commit 1078d2565c0bc53dd9ef982d246fd9ac3dd49309) Review URL: https://codereview.chromium.org/2180963002 . Cr-Commit-Position: refs/branch-heads/2785@{#332} Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382} [modify] https://crrev.com/a86349d887b4000f625354c9d6ce396517947729/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.mm [modify] https://crrev.com/a86349d887b4000f625354c9d6ce396517947729/chrome/browser/ui/cocoa/bookmarks/bookmark_button.mm [modify] https://crrev.com/a86349d887b4000f625354c9d6ce396517947729/chrome/browser/ui/cocoa/gradient_button_cell.mm
,
Jul 26 2016
Issue 631476 has been merged into this issue.
,
Jul 27 2016
Issue 631546 has been merged into this issue.
,
Jul 31 2016
Issue 632907 has been merged into this issue.
,
Aug 1 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/44233fd40b47ebf61fdef0f922f8b910f0e18b11 commit 44233fd40b47ebf61fdef0f922f8b910f0e18b11 Author: spqchan <spqchan@chromium.org> Date: Mon Aug 01 16:56:22 2016 [Material][Mac] Fixed Bookmark Items Highlight Issues Remove calls to setHighlighted: for MD bookmark items. Ensure that the items aren't highlighted when they are not enabled BUG= 627722 , 628187 , 628204 Review-Url: https://codereview.chromium.org/2169623002 Cr-Commit-Position: refs/heads/master@{#407032} (cherry picked from commit 1078d2565c0bc53dd9ef982d246fd9ac3dd49309) Review URL: https://codereview.chromium.org/2180963002 . Cr-Commit-Position: refs/branch-heads/2785@{#434} Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382} [modify] https://crrev.com/44233fd40b47ebf61fdef0f922f8b910f0e18b11/chrome/browser/ui/cocoa/download/download_item_controller.h [modify] https://crrev.com/44233fd40b47ebf61fdef0f922f8b910f0e18b11/chrome/browser/ui/cocoa/download/download_item_controller.mm [modify] https://crrev.com/44233fd40b47ebf61fdef0f922f8b910f0e18b11/chrome/browser/ui/cocoa/download/download_shelf_controller.mm
,
Aug 3 2016
Verified the fix on Mac 10.11.6 using chrome version 53.0.2785.45.Not observed any hover effect while double click on chevron icon. Thanks,
,
Aug 12 2016
Issue 637182 has been merged into this issue.
,
Aug 31 2016
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by sheriffbot@chromium.org
, Jul 14 2016