New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 628189 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Buried. Ping if important.
Closed: Sep 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug



Sign in to add a comment

CSP code uses SpaceSplitString from a worker but it isn't thread safe

Project Member Reported by ClusterFuzz, Jul 14 2016

Issue description

Detailed report: https://cluster-fuzz.appspot.com/testcase?key=6033865827418112

Fuzzer: ochang_domfuzzer
Job Type: linux_tsan_chrome_mp
Platform Id: linux

Crash Type: Data race READ 4
Crash Address: 0x7d080002df50
Crash State:
  blink::SpaceSplitString::Data::create
  blink::SpaceSplitString::set
  blink::Element::classAttributeChanged
  
Regressed: https://cluster-fuzz.appspot.com/revisions?job=linux_tsan_chrome_mp&range=389097:389209

Minimized Testcase (0.75 Kb): https://cluster-fuzz.appspot.com/download/AMIfv94whmkW4EjQgugUAseZ8qocikPeJ6FZ1w0slILHuZHlFkWIwqq6-bWOJITQzLB0fIRNUlHO-bdRjUIisJnEMfLp9YBKjpZ4r15b8XT1smpAnm9QAoUEpTH1oLUV8lSQ-_yoJ8vk0RYzdeNqoMcxeIUGXLRX-g?testcase_id=6033865827418112

Filer: ajha

See https://dev.chromium.org/Home/chromium-security/bugs/reproducing-clusterfuzz-bugs for more information.
 

Comment 1 by ajha@chromium.org, Jul 14 2016

Cc: ajha@chromium.org
Components: Tools>Test>FindIt>NoResult
Labels: Te-Logged M-52
Owner: esprehn@chromium.org
Status: Assigned (was: Available)
Suspected CLs	Analysis of failed component others is not supported by Findit.

Suspected Project: others

Unable to find the exact suspect using the code search hence assigning to chromium//src/third_party/WebKit/Source/core/OWNERS for help in finding an appropriate owner for this.

esprehn@: Could you please take a look at this.

Thank you!
Cc: mkwst@chromium.org
Components: Blink>SecurityFeature
Labels: -Pri-2 Pri-1
Owner: mkwst@chromium.org
Summary: CSP code uses SpaceSplitString from a worker but it isn't thread safe (was: Data race in blink::SpaceSplitString::Data::create)
This is a bug in the CSP code which is using SpaSpaceSplitString which has a static cache, but using it in workers.
Project Member

Comment 3 by ClusterFuzz, Sep 29 2016

ClusterFuzz has detected this issue as fixed in range 421045:421049.

Detailed report: https://cluster-fuzz.appspot.com/testcase?key=6033865827418112

Fuzzer: ochang_domfuzzer
Job Type: linux_tsan_chrome_mp
Platform Id: linux

Crash Type: Data race READ 4
Crash Address: 0x7d080002df50
Crash State:
  blink::SpaceSplitString::Data::create
  blink::SpaceSplitString::set
  blink::Element::classAttributeChanged
  
Regressed: https://cluster-fuzz.appspot.com/revisions?job=linux_tsan_chrome_mp&range=389097:389209
Fixed: https://cluster-fuzz.appspot.com/revisions?job=linux_tsan_chrome_mp&range=421045:421049

Minimized Testcase (0.75 Kb): https://cluster-fuzz.appspot.com/download/AMIfv94whmkW4EjQgugUAseZ8qocikPeJ6FZ1w0slILHuZHlFkWIwqq6-bWOJITQzLB0fIRNUlHO-bdRjUIisJnEMfLp9YBKjpZ4r15b8XT1smpAnm9QAoUEpTH1oLUV8lSQ-_yoJ8vk0RYzdeNqoMcxeIUGXLRX-g?testcase_id=6033865827418112

See https://dev.chromium.org/Home/chromium-security/bugs/reproducing-clusterfuzz-bugs for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 4 by ClusterFuzz, Sep 29 2016

Labels: ClusterFuzz-Verified
Status: Verified (was: Assigned)
ClusterFuzz testcase is verified as fixed, closing issue.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.
Components: -Tools>Test>FindIt>NoResult
Project Member

Comment 6 by sheriffbot@chromium.org, Nov 22 2016

Labels: -Restrict-View-EditIssue
Removing EditIssue view restrictions from ClusterFuzz filed bugs. If you believe that this issue should still be restricted, please reapply the label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Sign in to add a comment