Issue metadata
Sign in to add a comment
|
Regression: Unnecessary highlight is seen on 'empty' sub overlay of 'New folder' on bookmark bar.
Reported by
rk...@etouch.net,
Jul 14 2016
|
||||||||||||||||||||||
Issue descriptionChrome Version:54.0.2796.2 (Official Build) 677b7ff9c1739954e09b0bea21d75cdd1911d062-refs/branch-heads/2796@{#3} (32/64-bit) OS: Mac(10.10.5, 10.11.4) What steps will reproduce the problem? (1) Launch chrome, open NTP and bookmark it by creating 'New folder'. (2) Click on 'New folder' from bookmark bar, delete added bookmark and observe. Unnecessary highlight is seen on 'empty' sub overlay of 'New folder'. No such highlight should seen on 'empty' overlay of 'New folder'. This is a regression issue, broken in 'M-54', below is bisect info: Good Build: 54.0.2794.0 Bad Build: 54.0.2796.0 Narrow Bisect: https://chromium.googlesource.com/chromium/src/+log/f746c62413f7db8758bb21750af0d98938f3308a..565db0d042d2cbc46b04094caf773f210d4d38b0?pretty=fuller&n=100 Suspecting: r404767 Note: Issue is not seen on Windows and Linux OS.
,
Jul 18 2016
spqchan@: Could you please take a look at this.
,
Jul 20 2016
,
Jul 22 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1078d2565c0bc53dd9ef982d246fd9ac3dd49309 commit 1078d2565c0bc53dd9ef982d246fd9ac3dd49309 Author: spqchan <spqchan@chromium.org> Date: Fri Jul 22 03:37:26 2016 [Material][Mac] Fixed Bookmark Items Highlight Issues Remove calls to setHighlighted: for MD bookmark items. Ensure that the items aren't highlighted when they are not enabled BUG= 627722 , 628187 , 628204 Review-Url: https://codereview.chromium.org/2169623002 Cr-Commit-Position: refs/heads/master@{#407032} [modify] https://crrev.com/1078d2565c0bc53dd9ef982d246fd9ac3dd49309/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.mm [modify] https://crrev.com/1078d2565c0bc53dd9ef982d246fd9ac3dd49309/chrome/browser/ui/cocoa/bookmarks/bookmark_button.mm [modify] https://crrev.com/1078d2565c0bc53dd9ef982d246fd9ac3dd49309/chrome/browser/ui/cocoa/gradient_button_cell.mm
,
Jul 22 2016
,
Jul 25 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a86349d887b4000f625354c9d6ce396517947729 commit a86349d887b4000f625354c9d6ce396517947729 Author: spqchan <spqchan@chromium.org> Date: Mon Jul 25 17:57:48 2016 [Material][Mac] Fixed Bookmark Items Highlight Issues Remove calls to setHighlighted: for MD bookmark items. Ensure that the items aren't highlighted when they are not enabled BUG= 627722 , 628187 , 628204 Review-Url: https://codereview.chromium.org/2169623002 Cr-Commit-Position: refs/heads/master@{#407032} (cherry picked from commit 1078d2565c0bc53dd9ef982d246fd9ac3dd49309) Review URL: https://codereview.chromium.org/2180963002 . Cr-Commit-Position: refs/branch-heads/2785@{#332} Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382} [modify] https://crrev.com/a86349d887b4000f625354c9d6ce396517947729/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.mm [modify] https://crrev.com/a86349d887b4000f625354c9d6ce396517947729/chrome/browser/ui/cocoa/bookmarks/bookmark_button.mm [modify] https://crrev.com/a86349d887b4000f625354c9d6ce396517947729/chrome/browser/ui/cocoa/gradient_button_cell.mm
,
Aug 1 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/44233fd40b47ebf61fdef0f922f8b910f0e18b11 commit 44233fd40b47ebf61fdef0f922f8b910f0e18b11 Author: spqchan <spqchan@chromium.org> Date: Mon Aug 01 16:56:22 2016 [Material][Mac] Fixed Bookmark Items Highlight Issues Remove calls to setHighlighted: for MD bookmark items. Ensure that the items aren't highlighted when they are not enabled BUG= 627722 , 628187 , 628204 Review-Url: https://codereview.chromium.org/2169623002 Cr-Commit-Position: refs/heads/master@{#407032} (cherry picked from commit 1078d2565c0bc53dd9ef982d246fd9ac3dd49309) Review URL: https://codereview.chromium.org/2180963002 . Cr-Commit-Position: refs/branch-heads/2785@{#434} Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382} [modify] https://crrev.com/44233fd40b47ebf61fdef0f922f8b910f0e18b11/chrome/browser/ui/cocoa/download/download_item_controller.h [modify] https://crrev.com/44233fd40b47ebf61fdef0f922f8b910f0e18b11/chrome/browser/ui/cocoa/download/download_item_controller.mm [modify] https://crrev.com/44233fd40b47ebf61fdef0f922f8b910f0e18b11/chrome/browser/ui/cocoa/download/download_shelf_controller.mm |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by msrchandra@chromium.org
, Jul 14 2016